Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StableHLO] Failed to layout graph #171

Closed
Nullkooland opened this issue Sep 14, 2024 · 4 comments
Closed

[StableHLO] Failed to layout graph #171

Nullkooland opened this issue Sep 14, 2024 · 4 comments
Assignees
@jinjingforever @yijie-yang @pkgoogle
Labels
back-end For issues where the root is mostly occurring on the back-end and not a specific adapter MLIR adapter For issues where the root is mostly occurring with the MLIR adapter status:awaiting user response This label needs to be added to stale issues and PRs. type:bug Bug

Comments

@Nullkooland
Copy link

I tried to visualize a StableHLO model with model-explorer, but got this error:

Failed to layout graph: RangeError: Maximum call stack size exceeded

Could you take a look of my model IR, I think it is not malformed since it can be processed by stablehlo-opt tool with no problem:
text_encoder_1_77_256.mlir.txt
@pkgoogle
Copy link
Contributor

I was able to reproduce, but I never reached the maximum call stack (Infinite loop). @yijie-yang, can you please take a look? Thanks.

@pkgoogle pkgoogle added type:bug Bug back-end For issues where the root is mostly occurring on the back-end and not a specific adapter MLIR adapter For issues where the root is mostly occurring with the MLIR adapter labels Sep 16, 2024
@yijie-yang
Copy link
Collaborator

The backend adapter was able to convert the mlir to JSON graph successfully. Looks like there are some minor issues in UI layout rendering. Jing is inspecting.

@yijie-yang
Copy link
Collaborator

We found the issue: the default max number of nodes per layer is set to 1000, which can cause rendering issues when graph is huge. Setting to a smaller value will resolve it!
BAorH6QhFPD9Fg6

@pkgoogle pkgoogle added the status:awaiting user response This label needs to be added to stale issues and PRs. label Sep 17, 2024
@Nullkooland
Copy link
Author

We found the issue: the default max number of nodes per layer is set to 1000, which can cause rendering issues when graph is huge. Setting to a smaller value will resolve it! BAorH6QhFPD9Fg6

It works now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinjingforever jinjingforever

@yijie-yang yijie-yang

@pkgoogle pkgoogle

Labels
back-end For issues where the root is mostly occurring on the back-end and not a specific adapter MLIR adapter For issues where the root is mostly occurring with the MLIR adapter status:awaiting user response This label needs to be added to stale issues and PRs. type:bug Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jinjingforever @Nullkooland @yijie-yang @pkgoogle