Skip to content

Commit 76cdad6

Browse files
committed
Update UI tests to work on iOS 18.6, expand on documentation for local testing.
1 parent e191bd5 commit 76cdad6

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

Samples/Swift/DaysUntilBirthday/DaysUntilBirthdayUITests(iOS)/DaysUntilBirthdayUITests_iOS.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class DaysUntilBirthdayUITests_iOS: XCTestCase {
2020
private let signInStaticText =
2121
"“DaysUntilBirthday (iOS)” Wants to Use “google.com” to Sign In"
2222
private let passwordManagerPrompt =
23-
"Would you like to save this password to use with apps and websites?"
23+
"Save Password?"
2424
private let signInDisclaimerHeaderText =
2525
"Sign in to Days Until Birthday"
2626
private let returningUserSignInDisclaimerHeaderText =
@@ -177,6 +177,7 @@ extension DaysUntilBirthdayUITests_iOS {
177177
// Proceed through sign-in disclaimer and/or access request view(s) if needed
178178
handleSignInDisclaimerIfNeeded()
179179
handleAccessRequestIfNeeded()
180+
handleReturningUserSignInDisclaimerIfNeeded()
180181

181182
return true
182183
}
@@ -191,8 +192,9 @@ extension DaysUntilBirthdayUITests_iOS {
191192
return false
192193
}
193194

194-
handleReturningUserSignInDisclaimerIfNeeded()
195+
handleSignInDisclaimerIfNeeded()
195196
handleAccessRequestIfNeeded()
197+
handleReturningUserSignInDisclaimerIfNeeded()
196198

197199
return true
198200
}

Samples/Swift/DaysUntilBirthday/README.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ The email and password that we use are defined as
3535
[secrets](https://docs.github.com/en/actions/learn-github-actions/contexts#secrets-context)
3636
on our GitHub repo, and we retrieve these from the workflow environment.
3737

38-
Locally, both the email and password need to be passed to `xcodebuild` as
39-
arguments: `xcodebuild <other args> EMAIL_SECRET=... PASSWORD_SECRET=...`.
40-
Refer to the repo's Secrets for these values.
38+
When run locally, both the email and password need to be passed to `xcodebuild`.
39+
40+
From in Xcode, you can add arguments by selecting "Edit Scheme > Run > Environment Variables", and replace the variables with your test account. Alternatively, edit Credential.swift directly. WARNING: Don't check these into the repo!
41+
42+
From the command line, you can do this as arguments: `xcodebuild <other args> EMAIL_SECRET=... PASSWORD_SECRET=...`.
43+
44+
For Googlers, refer to CSI internal Workflow documentation for how to access these values, or access them via the repo's Secrets.

0 commit comments

Comments
 (0)