Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up callback flow for sign-in and verify flow. #427

Open
brnnmrls opened this issue May 21, 2024 · 0 comments
Open

Clean up callback flow for sign-in and verify flow. #427

brnnmrls opened this issue May 21, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@brnnmrls
Copy link
Member

Issue found in: #414 (comment)

The current sign-in and verify flow are brittle when processing the authorization response. The current flow will depend on an [authFlow wait] to ensure a token request is made before moving forward. Doing so makes the code harder to understand and easy to break. A way to improve this is by adding completion callbacks to ensure a tokenRequest is made before returning an instance of GIDAuthFlow.

@brnnmrls brnnmrls added bug Something isn't working triage Issues that need to be triaged labels May 21, 2024
@brnnmrls brnnmrls self-assigned this May 21, 2024
@brnnmrls brnnmrls added enhancement New feature or request and removed bug Something isn't working triage Issues that need to be triaged labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant