Skip to content

Conversation

@pemujo
Copy link

@pemujo pemujo commented Nov 24, 2025

Link to an existing issue (if applicable):

No existing issue since this is only a small change to CONTRIBUTING.md

Problem:

  1. Test Isolation: Step 5 currently instructs users to run pytest directly. This may execute tests using system libraries and versions rather than the project's isolated environment, potentially leading to inconsistent results or unknown issues.

  2. Formatter Detection: In Step 6, autoformat.sh checks for pyink and isort on the system path rather than the active virtual environment. Consequently, the script may fail to detect missing libraries or fail to fix formatting errors even if the tools are installed in the project environment.

Solution:

  1. Updated instructions to use uv run pytest to ensure tests run within the active virtual environment with correct dependency versions.

  2. Added a command to explicitly install/verify isort and pyink via uv before running the autoformatter.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @pemujo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the development workflow documentation by standardizing on uv for managing Python packages and executing development tasks. The changes aim to enhance the consistency and reliability of testing and code formatting processes, ensuring that all contributors operate within a well-defined and isolated environment, thereby reducing setup-related issues and improving overall code quality.

Highlights

  • Standardized Test Execution: Updated the CONTRIBUTING.md guide to use uv run pytest for executing unit tests. This change ensures that tests are consistently run within the project's isolated virtual environment, leveraging the correct dependency versions and preventing potential inconsistencies from system-wide installations.
  • Improved Auto-formatting Setup: Modified the auto-formatting instructions in CONTRIBUTING.md to explicitly ensure isort and pyink are installed within the active virtual environment. A new uv sync --extra dev command was added before running autoformat.sh to guarantee these tools are present and correctly detected, resolving issues where formatters might not be found or applied.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the documentation [Component] This issue is related to documentation, it will be transferred to adk-docs label Nov 24, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the contribution guidelines by standardizing on uv for running tests and installing formatting tools, which makes the development setup clearer and more robust. I've provided a couple of suggestions in the CONTRIBUTING.md file to further improve consistency and clarity. Overall, a good documentation update.

Pedro Melendez and others added 2 commits November 24, 2025 13:54
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ryanaiagent ryanaiagent self-assigned this Nov 25, 2025
@ryanaiagent ryanaiagent added the needs-review [Status] The PR is awaiting review from the maintainer label Nov 30, 2025
@ryanaiagent
Copy link
Collaborator

Hi @pemujo , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share.

@ryanaiagent
Copy link
Collaborator

Hi @wyf7107 , can you please review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation [Component] This issue is related to documentation, it will be transferred to adk-docs needs-review [Status] The PR is awaiting review from the maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants