Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor - Move Search Logic from Search.execute() to FhirEngine.search() #2540

Open
itstanany opened this issue May 12, 2024 · 2 comments
Open
Labels
P2 Medium priority issue type:code health

Comments

@itstanany
Copy link
Contributor

Describe the Issue

  • For Improving separation of concerns and single responsibility, I see search logic should be moved from Saerch.execute extension function to the fhir engine search method

Would you like to work on the issue?
Y

itstanany added a commit to itstanany/android-fhir that referenced this issue May 12, 2024
itstanany added a commit to itstanany/android-fhir that referenced this issue May 12, 2024
@santosh-pingle santosh-pingle added P2 Medium priority issue type:code health labels May 16, 2024
@jingtang10
Copy link
Collaborator

thanks for raising this - i actually think it might be cleaner to move the whole thing to the search pacakge... i see a future where the data access (CRUD), search, and sync APIs live in different packages.

can you see how that'll look like?

@jingtang10
Copy link
Collaborator

jingtang10 commented Jun 20, 2024

I commented here: #2541 (comment)

the search

https://github.com/itstanany/android-fhir/blob/601ebe18cd3b3d663fb4396dcf8058c60875c3eb/engine/src/main/java/com/google/android/fhir/FhirEngine.kt#L117

and count

https://github.com/itstanany/android-fhir/blob/601ebe18cd3b3d663fb4396dcf8058c60875c3eb/engine/src/main/java/com/google/android/fhir/FhirEngine.kt#L160

apis are defined in the com.google.android.fhir package. I think it might make more sense for them to be moved to the com.google.android.fhir.search package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority issue type:code health
Projects
Status: New
Development

Successfully merging a pull request may close this issue.

3 participants