-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag for including/excluding license rollup #19
Comments
Hi! |
Yeah, exactly. Though I did also noticed now that it does have a script to add a license header too "all" other files as well. So the final feature would involve more than just the rollup plugin. But basically a flag to toggle this part in rollup.config.mjs and its dependencies: https://github.com/google/aside/blob/main/rollup.config.mjs#L30-L36 license({
banner: {
content: {
file: fileURLToPath(new URL('license-header.txt', import.meta.url)),
},
},
}), Plus the Right not I'm removing all of it manually, which to be fair is not much work, but would be nice to be able to do it on init. |
So basically the aim would be to keep the license situation untouched (don't add and don't remove), correct? |
Yes the aim would be to leave it untouched in that sense. But on init you could potentially then have a flag such as:
|
Wouldn't |
I'd be happy to work on this feature myself. However, before diving in, I wanted to check whether it's within the project's scope. Would you accept a pull request for this? If it's in scope, what would be the preferred method: including or excluding the rollup via a flag?
The text was updated successfully, but these errors were encountered: