Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest using aio.channel when throwing error in async contexts. #71

Open
DeltaEvo opened this issue Jan 2, 2024 · 1 comment
Open

Suggest using aio.channel when throwing error in async contexts. #71

DeltaEvo opened this issue Jan 2, 2024 · 1 comment

Comments

@DeltaEvo
Copy link
Collaborator

DeltaEvo commented Jan 2, 2024

See https://github.com/google/avatar/blob/main/avatar/pandora_client.py#L136 for context.

We should change the error message to something like Trying to use the synchronous gRPC channel from asynchronous code. Use "aio.channel" instead of "channel" to get a "grpc.aio.Channel"
@DeltaEvo
Copy link
Collaborator Author

DeltaEvo commented Jan 2, 2024 •
edited
Loading

Or maybe add a note https://docs.python.org/3/library/exceptions.html#BaseException.add_note

https://peps.python.org/pep-0678/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DeltaEvo