Skip to content

Commit f91f3c2

Browse files
updated unit tests to make sure updated is called
1 parent ac18d30 commit f91f3c2

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

packages/model-viewer/src/extra-model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export class ExtraModelElement extends ReactiveElement {
4444
super.updated(changedProperties);
4545
console.log('updated is called');
4646
if (changedProperties.has('src')) {
47-
this.loaded = false;
47+
this.loaded = true;
4848
console.log('src has changed');
4949
}
5050
if (changedProperties.has('availableVariants')) {

packages/model-viewer/src/test/extra-model-spec.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,10 @@ suite('ExtraModelElement', () => {
4040
});
4141

4242
suite('with src property', () => {
43-
test('set loaded to false at first when src is set', async () => {
43+
test('set loaded to true at first when src is set', async () => {
4444
extraElement.src = assetPath('models/Astronaut.glb');
45-
expect(extraElement.loaded).to.be.false;
45+
await extraElement.updateComplete;
46+
expect(extraElement.loaded).to.be.true;
4647
});
4748
test.skip('dispatches a load event when src is set', async () => {
4849
const sourceLoads = waitForEvent(extraElement, 'load');

0 commit comments

Comments
 (0)