Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mongoose v6 not being traced automatically #1401

Closed
lucamazzilli opened this issue Nov 15, 2021 · 4 comments
Closed

Mongoose v6 not being traced automatically #1401

lucamazzilli opened this issue Nov 15, 2021 · 4 comments
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: will not fix Invalid (untrue/unsound/erroneous), inconsistent with product, not on roadmap. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@lucamazzilli
Copy link

Environment details

  • OS: Win 10 x64
  • Node.js version: 16.13.0
  • npm version: 8.1.0
  • @google-cloud/trace-agent version: 5.1.5
  • Mongoose: 6.0.10

Steps to reproduce

  1. start traceAgent using mongoose 6.0.10
  2. observe the error @google-cloud/trace-agent WARN PluginLoader#onRequire: [mongoose@6.0.10] This module is not supported by the configured set of plugins.
@product-auto-label product-auto-label bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Nov 15, 2021
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Nov 15, 2021
@gkf gkf self-assigned this Nov 16, 2021
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Nov 20, 2021
@gkf
Copy link
Member

gkf commented Dec 7, 2021

Unfortunately only mongoose v4 - v5 is supported according to: https://github.com/googleapis/cloud-trace-nodejs#what-gets-traced. As a workaround, one option is to use the custom tracing API to manually add spans.

I will leave this bug open as a feature request to support mongoose v6. However this is not likely to be prioritized because most development work is going into OpenTelemetry now. Contributed pull requests are always welcome though.

@gkf gkf added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Dec 7, 2021
@gkf gkf removed their assignment Dec 7, 2021
@gkf gkf mentioned this issue Dec 7, 2021
Closed
@punya
Copy link
Contributor

punya commented Aug 15, 2022

opentelemetry-instrumentation-mongoose seems to be active. I raised an issue to ask if they support v6.

@punya
Copy link
Contributor

punya commented Aug 16, 2022

According to #1382 (comment), the OTel mongoose instrumentation supports v6. Closing this issue.

@punya punya closed this as completed Aug 16, 2022
@punya punya added the status: will not fix Invalid (untrue/unsound/erroneous), inconsistent with product, not on roadmap. label Aug 28, 2022
@Wazbat
Copy link

Wazbat commented Sep 30, 2022

Sorry for pinging this old thread, but I wanted to ask. Are we able to use those opentelemetry instrumentations as plugins for this library? I'm a little confused by the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p2 Moderately-important priority. Fix may not be included in next release. status: will not fix Invalid (untrue/unsound/erroneous), inconsistent with product, not on roadmap. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@punya @Wazbat @gkf @yoshi-automation @lucamazzilli