Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If api_key is set in client options, pass it through to auth #319

Closed
andrewsg opened this issue Feb 4, 2025 · 0 comments · Fixed by #321
Closed

If api_key is set in client options, pass it through to auth #319

andrewsg opened this issue Feb 4, 2025 · 0 comments · Fixed by #321
Assignees
@ohmayr

Comments

@andrewsg
Copy link
Contributor

andrewsg commented Feb 4, 2025 •
edited
Loading

The ClientOptions class accepts an api_key argument, and the auth library also accepts an api_key argument. The Client class should pass ClientOptions.api_key to the auth library and plumb it all the way through, if it is specified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ohmayr ohmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Client should pass client_options.api_key to auth library googleapis/python-cloud-core
2 participants
@andrewsg @ohmayr