github-release command quit when get 'Bad pull request title' #2346
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Environment details
release-please
version: 16.12.0Steps to reproduce
Set
"group-pull-request-title-pattern"
value as"chore${scope}: releases packages ${component} ${version}"
like this in monorepo .when in monorepo the merge plugin will make
${component}
${version}
be undefined. so the title output will be "chore(main): releases packages"release-please/src/util/pull-request-title.ts
Line 24 in ace2bd5
/^chore(\((?<branch>[\w-./]+)\))?: releases packages ?(?<component>@?[\w-./]*)? v?(?<version>[0-9].*)$
which won't match the default value: "chore(main): releases packages".This make
github-release
command early return and won't create release and tags. the detail code is inrelease-please/src/strategies/base.ts
Line 591 in ace2bd5
so this will be unable to release a tag.
After a few hours search. My believe the
pullRequestTitle
can be undefined. because the release just need get version from the title inrelease-please/src/strategies/base.ts
Line 651 in ace2bd5
But it can also get from pullRequestBody. so we can just throw the pullRequestTitle away.
I've already test locally and glad to give a pull request if you want.
The text was updated successfully, but these errors were encountered: