Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Tooling should work with js and config files defined in manifest (and should not be hardcoded for index.js / index.json) #67

Open
minhaz opened this issue Oct 22, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@minhaz
Copy link

minhaz commented Oct 22, 2019

No description provided.

@minhaz minhaz added the enhancement New feature or request label Oct 22, 2019
@diminishedprime
Copy link
Contributor

Can you add some additional detail on what you expect vs what's currently implemented? I don't follow this FR.

@minhaz
Copy link
Author

minhaz commented Oct 23, 2019

The tooling/build process assumes the viz config will be called index.json and the code will be index.js. I was not able to find a configurable way to change this.

On the other hand, the manifest defines these two files. It would be best if the tooling could read the manifest and determine the config and code from there. If that is not possible or requires extra work, an easier way to point to the right file would be helpful.

This FR would be a prerequisite in supporting viz packs through the tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants