Skip to content
This repository has been archived by the owner on Aug 8, 2021. It is now read-only.

Nicknames and Role Colors Not Respected for New Messages #28

Open
2 of 4 tasks
awesomehaze opened this issue Jun 19, 2021 · 5 comments
Open
2 of 4 tasks

Nicknames and Role Colors Not Respected for New Messages #28

awesomehaze opened this issue Jun 19, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@awesomehaze
Copy link

awesomehaze commented Jun 19, 2021

How have you installed gord

  • go get
  • Github Releases
  • git clone & go build .
  • Arch User Repository (the AUR)

What happened

When I send a message in a channel, or receive a message, the role color and nickname don't display, only the actual discord name in white.

Error output

How do you reproduce this bug

Send or receive a message from a user with a role/nickname.

Additional Context

Role colors and nicknames are displayed correctly if you relaunch the program.

System information

Key Value
OS Arch Linux
Architecture x86_64
Terminal Kitty
@awesomehaze awesomehaze added the bug Something isn't working label Jun 19, 2021
@awesomehaze awesomehaze changed the title Nicknames and Nicknames and Roll Colors Not Respected for New Messages Jun 19, 2021
@awesomehaze awesomehaze changed the title Nicknames and Roll Colors Not Respected for New Messages Nicknames and Role Colors Not Respected for New Messages Jun 19, 2021
@yellowsink
Copy link
Collaborator

My instinct here is that the code to get old messages gets some details that the new message code misses out on

@awesomehaze
Copy link
Author

Perhaps the new message code should call the same method? I haven't checked out any of the code yet, but that sounds like it might be easier to maintain.

@yellowsink
Copy link
Collaborator

Seems logical but I'm not sure if that's how it works at the moment - something I need to do once I've gotten through some more of the list is to go through and cleanup / refactor a large portion of the codebase.

Some examples of this is the ui/window.go file, at a wonderful ~2000 lines and ui/chatview.go, at ~1000 lines

@MrSpidercat
Copy link

any progress so far?

@yellowsink
Copy link
Collaborator

Not yet :\ I've been working on other stuff but of course this is still on the todos - want to focus on #40 rn

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants