Skip to content

Commit ea8de80

Browse files
authored
Revert "Add in-memory caching to leaderboard endpoints (#141)"
This reverts commit 7c3ffd0.
1 parent 7c3ffd0 commit ea8de80

File tree

2 files changed

+3
-32
lines changed

2 files changed

+3
-32
lines changed

kernelboard/api/leaderboard.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import time
21
from typing import Any
32
from flask import Blueprint
43
from kernelboard.lib.db import get_db_connection
@@ -9,18 +8,9 @@
98

109
leaderboard_bp = Blueprint("leaderboard_bp", __name__, url_prefix="/leaderboard")
1110

12-
# Simple in-memory cache keyed by leaderboard_id
13-
_cache: dict[int, dict] = {}
14-
CACHE_TTL_SECONDS = 60
15-
1611

1712
@leaderboard_bp.route("/<int:leaderboard_id>", methods=["GET"])
1813
def leaderboard(leaderboard_id: int):
19-
now = time.time()
20-
cached = _cache.get(leaderboard_id)
21-
if cached is not None and (now - cached["timestamp"]) < CACHE_TTL_SECONDS:
22-
return http_success(cached["data"])
23-
2414
conn = get_db_connection()
2515
query = _get_query()
2616
with conn.cursor() as cur:
@@ -37,9 +27,6 @@ def leaderboard(leaderboard_id: int):
3727
data = result[0]
3828

3929
res = to_api_leaderboard_item(data)
40-
41-
_cache[leaderboard_id] = {"data": res, "timestamp": now}
42-
4330
return http_success(res)
4431

4532

kernelboard/api/leaderboard_summaries.py

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import time
2-
31
from flask import Blueprint
42
from datetime import datetime, timezone
53
from kernelboard.lib.db import get_db_connection
@@ -10,13 +8,6 @@
108
"leaderboard_summaries_bp", __name__, url_prefix="/leaderboard-summaries"
119
)
1210

13-
# Simple in-memory cache
14-
_cache = {
15-
"data": None,
16-
"timestamp": 0,
17-
}
18-
CACHE_TTL_SECONDS = 60
19-
2011

2112
@leaderboard_summaries_bp.route("", methods=["GET"])
2213
def index():
@@ -37,10 +28,6 @@ def index():
3728
# ],
3829
# }
3930

40-
now = time.time()
41-
if _cache["data"] is not None and (now - _cache["timestamp"]) < CACHE_TTL_SECONDS:
42-
return http_success(_cache["data"])
43-
4431
conn = get_db_connection()
4532
query = _get_query()
4633
with conn.cursor() as cur:
@@ -51,12 +38,9 @@ def index():
5138
if lb["gpu_types"] is None:
5239
lb["gpu_types"] = []
5340

54-
result = {"leaderboards": leaderboards, "now": datetime.now(timezone.utc)}
55-
56-
_cache["data"] = result
57-
_cache["timestamp"] = now
58-
59-
return http_success(result)
41+
return http_success(
42+
{"leaderboards": leaderboards, "now": datetime.now(timezone.utc)}
43+
)
6044

6145

6246
def _get_query():

0 commit comments

Comments
 (0)