Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes timezone validation and cleans up formatting in the leaderboard database module. The main change removes an assertion that required deadline timestamps to have timezone information.
- Remove timezone validation assertion for deadline parameter
- Reformat return statement for better code style
- Clean up extra whitespace
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| gpu_types: list | str, | ||
| ) -> int: | ||
| # to prevent surprises, ensure we have specified a timezone |
There was a problem hiding this comment.
The comment on line 83 mentions ensuring a timezone is specified, but the corresponding assertion has been removed. This comment should be updated or removed to avoid confusion.
| gpu_types: list | str, | |
| ) -> int: | |
| # to prevent surprises, ensure we have specified a timezone |
| return ( | ||
| {"user_id": row[0], "user_name": row[1], "id_type": id_type.value} if row else None | ||
| ) |
There was a problem hiding this comment.
[nitpick] The parentheses around the return statement are unnecessary. The conditional expression can be returned directly without wrapping parentheses.
| return ( | |
| {"user_id": row[0], "user_name": row[1], "id_type": id_type.value} if row else None | |
| ) | |
| return {"user_id": row[0], "user_name": row[1], "id_type": id_type.value} if row else None |
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
2 participants
Description
Please provide a brief summary of the changes in this pull request.
Checklist
Before submitting this PR, ensure the following steps have been completed:
/verifyrunson your own server./verifyruns.runs may take a little longer. The Modal run is typically quick.)
For more information on running a cluster bot on your own server, see
README.md.