Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MergeSourceSetFoldersWorkaround still valid (won't be fixed by Google)? #607

Closed
G00fY2 opened this issue Oct 26, 2023 · 2 comments
Closed

Comments

@G00fY2
Copy link

G00fY2 commented Oct 26, 2023

MergeSourceSetFoldersWorkaround has an empty fixedIn parameter. But actually the status in the linked issue is set:

Status: Won't Fix (Intended Behavior)
We tried to add @DoNotCacheByDefault but got performance regression from some of our benchmarks so we revert the change in I031cf4a63f8c45538cc5247d29e2d30d03cfe21e

Does it make sense to then still ship this workaround?

If Gradle teams still thinks this is required I would expect a new issue with some data to hold against their result.

@runningcode
Copy link
Contributor

Thanks for bringing this up.

The underlying issue was that the MergeSourceSetFolders task launches too many worker actions. See this comment for more details: #225 (comment)

We filed this bug to address it: https://issuetracker.google.com/issues/215395137

The disabling of caching was just a temporary workaround. It makes sense to remove the workaround. We need to figure out in which version it would make sense to start disabling it.

@ribafish
Copy link
Member

This was fixed in AGP 8.4.0-alpha01 and the workaround removed in this PR

@ribafish ribafish closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants