Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compactor and store-gateway to dedicated files #196

Open
pracucci opened this issue Oct 5, 2020 · 3 comments
Open

Move compactor and store-gateway to dedicated files #196

pracucci opened this issue Oct 5, 2020 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@pracucci
Copy link
Collaborator

pracucci commented Oct 5, 2020

The jsonnet definitions for compactor and store-gateway are buried into https://github.com/grafana/cortex-jsonnet/blob/master/cortex/tsdb.libsonnet. We should move them to dedicated files, like any other component.

@pracucci pracucci added the help wanted Extra attention is needed label Oct 5, 2020
@bboreham
Copy link
Contributor

How is tsdb.libsonnet connected to the rest of this thing?
It doesn't seem to be imported anywhere.

@pstibrany
Copy link
Member

We import it manually in clusters that use blocks engine. Clusters that don't use it don't import this file.

@hamishforbes
Copy link
Contributor

We import it manually in clusters that use blocks engine. Clusters that don't use it don't import this file.

This tidbit would be fantastic to have in the readme or even just as a commented out line in the example manifest!
Especially with chunks storage being deprecated and blocks being the preferred default nowadays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants