fix: bump otel #763
fix: bump otel #763
Conversation
|
|
|
|
|
Hey @Netail thank you so much for the contribution. |
Oops, not necessarily a bug in here actually. But nextjs' bundling seems to have an issue (vercel/next.js#74331), where it picks the latest version. The rest of our apps uses 0.57.0, while faro uses 0.53.0, between these versions a function got removed which is now throwing an error in faro |
|
Aaaah got it @Netail thanks that's fine. 🙏 |
|
Could have reverted our versions ofc, but the dependencies here had to updated at some point, so why not xd |
tsconfig.base.cjs.json
Outdated
| @@ -2,6 +2,6 @@ | |||
| "extends": "./tsconfig.base.json", | |||
| "compilerOptions": { | |||
| "module": "CommonJS", | |||
| "target": "ES5" | |||
There was a problem hiding this comment.
Any specific reason to change the target here?
Note:
We have users (at least back in the days) who need ES5 support.
There was a problem hiding this comment.
The build failed locally, because .includes() wasn't available yet
There was a problem hiding this comment.
Might be able to revert it actually
It's already time to update OTEL deps so you had perfect timing :) |
Head branch was pushed to by a user without write access
|
After some ci/cd fixes, it should be good now xd |
|
@Netail I can't promise that we release a new version this week so it might take till Monday. |
|
No worries, thanks :) |
Why
Bump OTEL packages
What
Bump otel packages
Set target to ES2016, else.includeswasn't supported yetnodeto tsconfig types, forglobaltypeLinks
Checklist