Skip to content

Fix: Force recreate when disabling spec.allowCrossNamespaceImport #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Baarsgaard
Copy link
Collaborator

@Baarsgaard Baarsgaard commented Jan 13, 2025

Figured out a validation rule that accomplishes to block true -> false and true -> undefined
Added tests for validating the behavior as well

@Baarsgaard Baarsgaard marked this pull request as ready for review January 13, 2025 23:32
@Baarsgaard Baarsgaard force-pushed the force_recreate_when_disabling_allowCrossNamespaceImport branch from 688c985 to 5ec514a Compare January 14, 2025 00:20
@theSuess theSuess added this pull request to the merge queue Jan 14, 2025
Merged via the queue into grafana:master with commit d94f9e5 Jan 14, 2025
14 checks passed
@Baarsgaard Baarsgaard deleted the force_recreate_when_disabling_allowCrossNamespaceImport branch January 14, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants