Remove ec lint, which we don't really need and also fix some lint issues

Signed-off-by: Pete Wall <pete.wall@grafana.com>

Author: petewall

.github/workflows/reviewdog.yml

@@ -121,16 +121,6 @@ jobs:
           github_token: ${{ secrets.github_token }}
           reporter: github-check
 
-  eclint:
-    name: runner / eclint
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: reviewdog/action-eclint@v1
-        with:
-          github_token: ${{ secrets.github_token }}
-          reporter: github-check
-
   textlint:
     name: runner / textlint
     runs-on: ubuntu-latest

Makefile

@@ -42,40 +42,33 @@ clean:
 ####################################################################
 #                           Linting                                #
 ####################################################################
-.PHONY: lint lint-chart lint-sh lint-md lint-txt lint-yml lint-ec lint-alex lint-misspell lint-actionlint
-lint: lint-chart lint-sh lint-md lint-txt lint-yml lint-ec lint-alex lint-misspell lint-actionlint
+.PHONY: lint lint-sh lint-md lint-txt lint-yml lint-alex lint-misspell lint-actionlint
+lint: lint-sh lint-md lint-txt lint-yml lint-alex lint-misspell lint-actionlint
 
-lint-chart:
-	ct lint --debug --lint-conf .configs/lintconf.yaml --check-version-increment=false
-
-# Shell Linting
+# Shell Linting for checking shell scripts
 lint-sh lint-shell:
 	@./scripts/lint-shell.sh || true
 
-# Markdown Linting
+# Markdown Linting for checking markdown files
 lint-md lint-markdown:
 	@./scripts/lint-markdown.sh || true
 
-# Text Linting
+# Text Linting for checking text files
 lint-txt lint-text:
 	@./scripts/lint-text.sh || true
 
-# Yaml Linting
+# Yaml Linting for checking yaml files
 lint-yml lint-yaml:
 	@./scripts/lint-yaml.sh || true
 
-# Editorconfig Linting
-lint-ec lint-editorconfig:
-	@./scripts/lint-editorconfig.sh || true
-
-# Alex Linting
+# Alex Linting for checking insensitive language
 lint-alex:
 	@./scripts/lint-alex.sh || true
 
-# Misspell Linting
+# Misspell Linting for checking common spelling mistakes
 lint-misspell:
 	@./scripts/lint-misspell.sh || true
 
-# Actionlint Linting
+# Actionlint Linting for checking GitHub Actions
 lint-al lint-actionlint:
 	@./scripts/lint-actionlint.sh || true

charts/feature-cluster-metrics/README.md

@@ -142,6 +142,7 @@ action on the metric list, including filtering based on label or other actions.
 | https://sustainable-computing-io.github.io/kepler-helm-chart | kepler | 0.5.9 |
 <!-- markdownlint-enable no-bare-urls -->
 
+<!-- markdownlint-disable no-space-in-emphasis -->
 ## Values
 
 ### API Server
@@ -320,3 +321,4 @@ action on the metric list, including filtering based on label or other actions.
 | windows-exporter.metricsTuning.includeMetrics | list | `[]` | Metrics to keep. Can use regular expressions. |
 | windows-exporter.metricsTuning.useDefaultAllowList | bool | `true` | Filter the list of metrics from Windows Exporter to the minimal set required for Kubernetes Monitoring. See [Metrics Tuning and Allow Lists](#metrics-tuning-and-allow-lists) |
 | windows-exporter.scrapeInterval | string | `60s` | How frequently to scrape metrics from Windows Exporter. |
+<!-- markdownlint-enable no-space-in-emphasis -->

charts/feature-cluster-metrics/README.md.gotmpl

@@ -136,4 +136,6 @@ action on the metric list, including filtering based on label or other actions.
 {{ template "chart.requirementsSection" . }}
 <!-- markdownlint-enable no-bare-urls -->
 
+<!-- markdownlint-disable no-space-in-emphasis -->
 {{ template "chart.valuesSection" . }}
+<!-- markdownlint-enable no-space-in-emphasis -->

charts/k8s-monitoring/Makefile

@@ -69,7 +69,9 @@ alloy_configs = $(shell \
 	DIR="$(shell dirname $(1))/" yq e 'with_entries(select(.key == "alloy-*")) | select(.[].enabled == true) | to_entries | env(DIR) + .[].key + ".alloy"' $(1) \
 )
 
-# TODO: make this dependent on
+# TODO: Ideally, this shouldn't result in "modified" files if the subchart content is the same.
+# 	    The issue is that tar and gz include things like timestamps in their headers, which will
+#	    result in different hashes for the same content. Not great for Makefiles or modified file checks.
 Chart.lock: Chart.yaml
 	helm dependency update .
 

charts/k8s-monitoring/charts/k8s-monitoring-feature-annotation-autodiscovery-1.0.0.tgz

@@ -17,7 +17,6 @@
   "dependencies": {},
   "devDependencies": {
     "alex": "^11.0.1",
-    "editorconfig-checker": "^5.1.9",
     "markdownlint-cli2": "^0.14.0",
     "textlint": "^14.2.0",
     "textlint-rule-common-misspellings": "^1.0.1",

charts/k8s-monitoring/charts/k8s-monitoring-feature-application-observability-1.0.0.tgz

@@ -889,11 +889,6 @@ eastasianwidth@^0.2.0:
   resolved "https://registry.yarnpkg.com/eastasianwidth/-/eastasianwidth-0.2.0.tgz#696ce2ec0aa0e6ea93a397ffcf24aa7840c827cb"
   integrity sha512-I88TYZWc9XiYHRQ4/3c5rjjfgkjhLyW2luGIheGERbNQ6OY7yTybanSpDXZa8y7VUP9YmDcYa+eyq4ca7iLqWA==
 
-editorconfig-checker@^5.1.9:
-  version "5.1.9"
-  resolved "https://registry.yarnpkg.com/editorconfig-checker/-/editorconfig-checker-5.1.9.tgz#6edf46da8362069c6edab10c7e9318ee8b10d533"
-  integrity sha512-p1XFFxEkhY9Nl+kuMLZA6PzzZ6s+dvy4yBmJD68tC4BwBQdjUh2p1VxA6IbtN5beaX6i7WtHeEsvTK5LF+W+OQ==
-
 emoji-regex@^8.0.0:
   version "8.0.0"
   resolved "https://registry.yarnpkg.com/emoji-regex/-/emoji-regex-8.0.0.tgz#e818fd69ce5ccfcb404594f842963bf53164cc37"