Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.0 name of Alloy modules configmaps do not respect fullnameOverride #994

Open
splichy opened this issue Dec 12, 2024 · 0 comments
Open

v2.0 name of Alloy modules configmaps do not respect fullnameOverride #994

splichy opened this issue Dec 12, 2024 · 0 comments

Comments

@splichy
Copy link

splichy commented Dec 12, 2024

We are using ArgoCD, so our .Release.Name is quite long. For clarity, we are using fullnameOverride where possible.

With the following values:

clusterMetrics:
  enabled: true
  kepler:
    fullnameOverride: kepler
  opencost:
    fullnameOverride: opencost
podLogs:
  enabled: true
nodeLogs:
  enabled: true
clusterEvents:
  enabled: true

alloy-metrics:
  fullnameOverride: alloy-metrics
  enabled: true
alloy-logs:
  fullnameOverride: alloy-logs
  enabled: true
alloy-singleton:
  fullnameOverride: alloy-singleton
  enabled: true

we are getting nice, clean names - except for alloy modules configmaps whose names are like: very-long-release-name-alloy-module-kubernetes

There is hardcoded .Release.Name in https://github.com/grafana/k8s-monitoring-helm/blob/e94d0b5c03d46ecee1f08c25e66e4ac50f87dfa4/charts/k8s-monitoring/templates/alloy-modules-configmaps.yaml#L9C3-L9C91 and on the other places(references to created configmap name in Alloy features).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@splichy