Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priorityClassName to all daemonsets #996

Open
ceastman-r7 opened this issue Dec 12, 2024 · 1 comment
Open

Add priorityClassName to all daemonsets #996

ceastman-r7 opened this issue Dec 12, 2024 · 1 comment
Assignees

Comments

@ceastman-r7
Copy link

I tried enabling profiling but some pods are pending because they don't have a priorityClassName.

I am thinking something like:

alloy-profiles:
  priorityClassName: highPriority
@petewall petewall self-assigned this Dec 13, 2024
@petewall
Copy link
Collaborator

I'm not sure if I want to pre-set a priorityClassName because highPriority might not exist on the particular cluster.

It is already set-able in the Alloy chart: https://github.com/grafana/alloy/blob/main/operations/helm/charts/alloy/values.yaml#L217

Which means that anyone can set it by adding:

alloy-profiles:
  controller:
    priorityClassName: highPriority

I can add a note to the troubleshooting section that shows how to set this, if you think that'd be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants