Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo at comment in values.yaml in autoInstrumentation section #997

Open
timdeluxe opened this issue Dec 13, 2024 · 3 comments
Open

Typo at comment in values.yaml in autoInstrumentation section #997

timdeluxe opened this issue Dec 13, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@timdeluxe
Copy link

Here is a typo: https://github.com/grafana/k8s-monitoring-helm/blob/v1.6.13/charts/k8s-monitoring/values.yaml#L141
It says "Enable gathering Kubernetes Pod logs." but it looks like that is just copied from https://github.com/grafana/k8s-monitoring-helm/blob/v1.6.13/charts/k8s-monitoring/values.yaml#L122

Should be fixed to say something about enabling auto instrumentation.
@petewall
Copy link
Collaborator

Ahh yes! Thanks for catching that.

@petewall petewall added bug Something isn't working good first issue Good for newcomers documentation Improvements or additions to documentation and removed bug Something isn't working labels Dec 13, 2024
@Abhishek022001
Copy link
Contributor

can i work on this issue?

@petewall
Copy link
Collaborator

Absolutely! Update the values.yaml file and run make build to update Readme.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petewall @timdeluxe @Abhishek022001