Fix typo, improve destination validations #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pete Wall <pete.wall@grafana.com>
petewall
commented
Oct 31, 2024
There was a problem hiding this comment.
This allows for invalid types to pass schema validation... only to be caught by the template validation. It greatly improves the quality of the error message if you're missing a type or use an invalid type.
There was a problem hiding this comment.
Doing the destination validation before feature validation to catch these issues earlier.
For example, if your values file had this:
destinations:
- name: prom
type: prom # invalid type
clusterMetrics:
enabled: true
The error message will say that Cluster Metrics requires a metrics destination, not that "prom" is not a valid destination type.
Signed-off-by: Pete Wall <pete.wall@grafana.com>
Signed-off-by: Pete Wall <pete.wall@grafana.com>
petewall
requested review from
a team,
skl,
nevermind89x and
jewbetcha
and removed request for
a team
… is empty Signed-off-by: Pete Wall <pete.wall@grafana.com>
skl
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.