Skip to content

Commit cc356c9

Browse files
authored
chore: capitalize Slack name references (#5421)
Related to grafana/irm#425
1 parent 84411b7 commit cc356c9

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

engine/apps/alerts/incident_log_builder/incident_log_builder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ def _render_escalation_step_plan_from_escalation_policy_snapshot(
536536
)
537537
else:
538538
plan_line = (
539-
f'escalation step "{escalation_policy_snapshot.step_display}" is slack specific. ' f"Skipping"
539+
f'escalation step "{escalation_policy_snapshot.step_display}" is Slack specific. ' f"Skipping"
540540
)
541541

542542
escalation_plan.setdefault(timedelta, []).append({"plan_lines": [plan_line]})
@@ -597,7 +597,7 @@ def _render_escalation_step_plan_from_escalation_policy_snapshot(
597597
)
598598
else:
599599
plan_line = (
600-
f'escalation step "{escalation_policy_snapshot.step_display}" is slack specific. Skipping'
600+
f'escalation step "{escalation_policy_snapshot.step_display}" is Slack specific. Skipping'
601601
)
602602

603603
escalation_plan.setdefault(timedelta, []).append({"plan_lines": [plan_line]})

engine/apps/alerts/tasks/notify_user.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ def _create_notification_finished_user_notification_policy_log_record():
252252
type=UserNotificationPolicyLogRecord.TYPE_PERSONAL_NOTIFICATION_FAILED,
253253
notification_policy=notification_policy,
254254
alert_group=alert_group,
255-
reason="Alert group slack notifications are disabled",
255+
reason="Alert group Slack notifications are disabled",
256256
slack_prevent_posting=prevent_posting_to_thread,
257257
notification_step=notification_policy.step,
258258
notification_channel=notification_policy.notify_by,

engine/apps/api/views/schedule.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,7 @@ def mention_options(self, request):
567567
},
568568
{
569569
"value": True,
570-
"display_name": "Mention person in slack",
570+
"display_name": "Mention person in Slack",
571571
},
572572
]
573573
return Response(options)

engine/apps/slack/scenarios/resolution_note.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ def get_resolution_notes_blocks(
558558
user_verbal = resolution_note.author_verbal(mention=True)
559559
message_timestamp = datetime.datetime.timestamp(resolution_note.created_at)
560560
blocks.append(DIVIDER)
561-
source = "web" if resolution_note.source == ResolutionNote.Source.WEB else "slack"
561+
source = "web" if resolution_note.source == ResolutionNote.Source.WEB else "Slack"
562562

563563
blocks.append(
564564
typing.cast(

engine/apps/slack/scenarios/schedules.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
class EditScheduleShiftNotifyStep(scenario_step.ScenarioStep):
2727
notify_empty_oncall_options = {choice[0]: choice[1] for choice in OnCallSchedule.NotifyEmptyOnCall.choices}
2828
notify_oncall_shift_freq_options = {choice[0]: choice[1] for choice in OnCallSchedule.NotifyOnCallShiftFreq.choices}
29-
mention_oncall_start_options = {1: "Mention person in slack", 0: "Inform in channel without mention"}
30-
mention_oncall_next_options = {1: "Mention person in slack", 0: "Inform in channel without mention"}
29+
mention_oncall_start_options = {1: "Mention person in Slack", 0: "Inform in channel without mention"}
30+
mention_oncall_next_options = {1: "Mention person in Slack", 0: "Inform in channel without mention"}
3131

3232
def process_scenario(
3333
self,

engine/apps/slack/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ def post(self, request):
586586
# just a placeholder value to continute uninstallation until UNIFIED_SLACK_APP_ENABLED is not enabled
587587
removed = True
588588
if not removed:
589-
return Response({"error": "Failed to uninstall slack integration"}, status=500)
589+
return Response({"error": "Failed to uninstall Slack integration"}, status=500)
590590

591591
try:
592592
uninstall_slack_integration(request.user.organization, request.user)

0 commit comments

Comments
 (0)