Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying --vus and --iterations prevents execution of browser checks #915

Open
roobre opened this issue Sep 30, 2024 · 2 comments
Open
Assignees

Comments

@roobre
Copy link
Collaborator

roobre commented Sep 30, 2024

#829 introduced an image flavor that allows running browser checks. However, for them to be fully runnable, we need to get rid of --vus, --iterations, and --duration arguments: grafana/k6#3742

If specified, k6 will yield an error like the following:

ERRO[0000] Uncaught (in promise) GoError: browser not found in registry. make sure to set browser type option in scenario definition in order to use the browser module
	at github.com/grafana/xk6-browser/browser.syncMapBrowser.func7 (native)
	at default (file:///home/roobre/Devel/crocochrome/manualtest/testk6io.js:20:31(3))  executor=shared-iterations scenario=default

We currently specify two of those:

"--vus", "1",
"--iterations", "1",

We should figure out a way to condition those arguments to the check being a browser check, or find another workaround.

Blocked by #928, which will inform the runner of the script type and allow it to not specify these options.

@roobre roobre changed the title Disable --vus and --duration for browser scripts. Disable --vus and --iterations for browser scripts. Sep 30, 2024
@roobre roobre changed the title Disable --vus and --iterations for browser scripts. Disable --vus and --iterations for browser scripts Sep 30, 2024
@peterschretlen
Copy link
Contributor

This is blocking browser checks running in private probes.

@roobre roobre changed the title Disable --vus and --iterations for browser scripts Specifying --vus and --iterations prevents execution of browser checks Oct 11, 2024
@roobre
Copy link
Collaborator Author

roobre commented Oct 11, 2024

Renamed the issue to make it a bit more discoverable.

@roobre roobre self-assigned this Oct 14, 2024
@mem mem self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants