-
Notifications
You must be signed in to change notification settings - Fork 573
Breaking changes to db.system
attribute in OpenTelemetry Semantic Conventions v1.30.0
#4640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like we default to So we would look for the following in order and use the first one we found?
tempo/modules/generator/processor/servicegraphs/servicegraphs.go Lines 295 to 306 in 4ac0715
|
Looking at the current implementation, this ordering would preserve current behavior while supporting the new names:
|
Blocked by: |
@matt-hensley I want to work on this. Can you assign it to me? |
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. |
I'm bumping this issue as discussed with @cedricziel as OTel practitioners no longer see their databases |
As suggested previously, we should make this database name attribute configurable on the service graph processor. That way, if this convention changes yet again, we don't have to worry about making code changes to support the change. See #4656 (review) This was done in the otel contrib service graph connector. This config param was recently to support a prioritized list of attribute names for db identification: open-telemetry/opentelemetry-collector-contrib#39133 |
Is your feature request related to a problem? Please describe.
v1.30.0 of OpenTelemetry Semantic Conventions has two breaking changes to the
db.system
attribute. This will impact the ability for the metrics-generator to create virtual nodes in service graphs.The breaking changes are:
db.system
todb.system.name
Describe the solution you'd like
db.system.name
recognized as a peer attribute for service graph metrics generation.Additional context
Diff between releases v1.29.0 and v1.30.0
The text was updated successfully, but these errors were encountered: