Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Commit c394e60

Browse files
committed
test: change @Ignore to @PendingFeature
Related to gh-164
1 parent 27f1273 commit c394e60

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

examples/pubsub-demo/src/integration-test/groovy/pubsub/demo/TaskControllerSpec.groovy

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import io.micronaut.http.HttpStatus
77
import io.micronaut.http.client.HttpClient
88
import io.micronaut.http.client.exceptions.HttpClientResponseException
99
import spock.lang.AutoCleanup
10-
import spock.lang.Ignore
10+
import spock.lang.PendingFeature
1111
import spock.lang.Shared
1212
import spock.lang.Specification
1313

@@ -25,7 +25,11 @@ class TaskControllerSpec extends Specification {
2525
client = HttpClient.create("http://localhost:$serverPort".toURL())
2626
}
2727

28-
@Ignore
28+
@PendingFeature(reason = '''
29+
For some reason the response body is blank with bootTestRun.
30+
However, when starting the application with bootRun,
31+
the response body is as expected.
32+
''')
2933
void 'test async error handling'() {
3034

3135
when: 'we invoke an endpoint that throws an exception'

grails-async-core/src/test/groovy/grails/async/PromiseMapSpec.groovy

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
/*
2-
* Copyright 2013 SpringSource
2+
* Copyright 2013-2024 the original author or authors
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
66
* You may obtain a copy of the License at
77
*
8-
* http://www.apache.org/licenses/LICENSE-2.0
8+
* https://www.apache.org/licenses/LICENSE-2.0
99
*
1010
* Unless required by applicable law or agreed to in writing, software
1111
* distributed under the License is distributed on an "AS IS" BASIS,
@@ -15,7 +15,7 @@
1515
*/
1616
package grails.async
1717

18-
import spock.lang.Ignore
18+
import spock.lang.PendingFeature
1919
import spock.lang.Specification
2020
import spock.util.concurrent.PollingConditions
2121

@@ -97,7 +97,7 @@ class PromiseMapSpec extends Specification {
9797
err.message == 'java.lang.RuntimeException: bad'
9898
}
9999

100-
@Ignore('''
100+
@PendingFeature(reason = '''
101101
This test fails because the chained call to then does not use the
102102
map returned from the previous closure. So the same first map
103103
is returned over and over.

grails-async-rxjava/src/test/groovy/org/grails/async/factory/rxjava/RxJavaPromiseMapSpec.groovy

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.grails.async.factory.rxjava
22

33
import grails.async.PromiseMap
4-
import spock.lang.Ignore
4+
import spock.lang.PendingFeature
55
import spock.lang.Specification
66
import spock.util.concurrent.PollingConditions
77

@@ -86,7 +86,7 @@ class RxJavaPromiseMapSpec extends Specification{
8686
}
8787
}
8888

89-
@Ignore('''
89+
@PendingFeature(reason = '''
9090
This test fails because the chained call to then does not use the
9191
map returned from the previous closure. So the same first map
9292
is returned over and over.
@@ -97,10 +97,8 @@ class RxJavaPromiseMapSpec extends Specification{
9797
def map = new PromiseMap()
9898
map['one'] = { 1 }
9999
def promise = map.then {
100-
println it
101100
it['four'] = 4; it
102101
}.then {
103-
println it
104102
it['eight'] = 8; it
105103
}
106104
def result = promise.get()

0 commit comments

Comments
 (0)