test: change @Ignore to @PendingFeature

Related to gh-164
grails · Dec 15, 2024 · c394e60 · c394e60
1 parent 27f1273
commit c394e60
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/examples/pubsub-demo/src/integration-test/groovy/pubsub/demo/TaskControllerSpec.groovy b/examples/pubsub-demo/src/integration-test/groovy/pubsub/demo/TaskControllerSpec.groovy
@@ -7,7 +7,7 @@ import io.micronaut.http.HttpStatus
 import io.micronaut.http.client.HttpClient
 import io.micronaut.http.client.exceptions.HttpClientResponseException
 import spock.lang.AutoCleanup
-import spock.lang.Ignore
+import spock.lang.PendingFeature
 import spock.lang.Shared
 import spock.lang.Specification
 
@@ -25,7 +25,11 @@ class TaskControllerSpec extends Specification {
         client = HttpClient.create("http://localhost:$serverPort".toURL())
     }
 
-    @Ignore
+    @PendingFeature(reason = '''
+        For some reason the response body is blank with bootTestRun.
+        However, when starting the application with bootRun,
+        the response body is as expected.
+    ''')
     void 'test async error handling'() {
 
         when: 'we invoke an endpoint that throws an exception'

diff --git a/grails-async-core/src/test/groovy/grails/async/PromiseMapSpec.groovy b/grails-async-core/src/test/groovy/grails/async/PromiseMapSpec.groovy
@@ -1,11 +1,11 @@
 /*
- * Copyright 2013 SpringSource
+ * Copyright 2013-2024 the original author or authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *      http://www.apache.org/licenses/LICENSE-2.0
+ *      https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -15,7 +15,7 @@
  */
 package grails.async
 
-import spock.lang.Ignore
+import spock.lang.PendingFeature
 import spock.lang.Specification
 import spock.util.concurrent.PollingConditions
 
@@ -97,7 +97,7 @@ class PromiseMapSpec extends Specification {
             err.message == 'java.lang.RuntimeException: bad'
     }
 
-    @Ignore('''
+    @PendingFeature(reason = '''
         This test fails because the chained call to then does not use the
         map returned from the previous closure. So the same first map
         is returned over and over.

diff --git a/...-async-rxjava/src/test/groovy/org/grails/async/factory/rxjava/RxJavaPromiseMapSpec.groovy b/...-async-rxjava/src/test/groovy/org/grails/async/factory/rxjava/RxJavaPromiseMapSpec.groovy
@@ -1,7 +1,7 @@
 package org.grails.async.factory.rxjava
 
 import grails.async.PromiseMap
-import spock.lang.Ignore
+import spock.lang.PendingFeature
 import spock.lang.Specification
 import spock.util.concurrent.PollingConditions
 
@@ -86,7 +86,7 @@ class RxJavaPromiseMapSpec extends Specification{
             }
     }
 
-    @Ignore('''
+    @PendingFeature(reason = '''
         This test fails because the chained call to then does not use the
         map returned from the previous closure. So the same first map
         is returned over and over.
@@ -97,10 +97,8 @@ class RxJavaPromiseMapSpec extends Specification{
             def map = new PromiseMap()
             map['one'] = { 1 }
             def promise = map.then {
-                println it
                 it['four'] = 4; it
             }.then {
-                println it
                 it['eight'] = 8; it
             }
             def result = promise.get()