From 1a3d2877a6d005916e96c11493d0f81635d9e01c Mon Sep 17 00:00:00 2001 From: Mattias Reichel Date: Sat, 9 Mar 2024 15:57:37 +0100 Subject: [PATCH] fix(deps): Remove dependency org.hibernate:hibernate-core (#286) There is no need to include this library as a direct dependency for Grails applications. Any libraries/modules that depend on it declares it themselves. --- .../org/grails/forge/feature/database/HibernateGorm.java | 4 ---- grails-forge-core/src/main/resources/pom.xml | 5 ----- .../grails/forge/feature/database/HibernateGormSpec.groovy | 1 - 3 files changed, 10 deletions(-) diff --git a/grails-forge-core/src/main/java/org/grails/forge/feature/database/HibernateGorm.java b/grails-forge-core/src/main/java/org/grails/forge/feature/database/HibernateGorm.java index d0a2db88..b9d85dbf 100644 --- a/grails-forge-core/src/main/java/org/grails/forge/feature/database/HibernateGorm.java +++ b/grails-forge-core/src/main/java/org/grails/forge/feature/database/HibernateGorm.java @@ -87,10 +87,6 @@ public void apply(GeneratorContext generatorContext) { .groupId("org.grails.plugins") .artifactId("hibernate5") .compile()); - generatorContext.addDependency(Dependency.builder() - .groupId("org.hibernate") - .lookupArtifactId("hibernate-core") - .compile()); generatorContext.addDependency(Dependency.builder() .groupId("org.glassfish.web") .lookupArtifactId("el-impl") diff --git a/grails-forge-core/src/main/resources/pom.xml b/grails-forge-core/src/main/resources/pom.xml index 7bc8d7d3..5187445b 100644 --- a/grails-forge-core/src/main/resources/pom.xml +++ b/grails-forge-core/src/main/resources/pom.xml @@ -12,11 +12,6 @@ - - org.hibernate - hibernate-core - 5.6.15.Final - org.glassfish.web el-impl diff --git a/grails-forge-core/src/test/groovy/org/grails/forge/feature/database/HibernateGormSpec.groovy b/grails-forge-core/src/test/groovy/org/grails/forge/feature/database/HibernateGormSpec.groovy index b967c9f4..de56142f 100644 --- a/grails-forge-core/src/test/groovy/org/grails/forge/feature/database/HibernateGormSpec.groovy +++ b/grails-forge-core/src/test/groovy/org/grails/forge/feature/database/HibernateGormSpec.groovy @@ -29,7 +29,6 @@ class HibernateGormSpec extends ApplicationContextSpec implements CommandOutputF then: template.contains('implementation("org.grails.plugins:hibernate5")') - template.contains('implementation("org.hibernate:hibernate-core:5.6.15.Final")') template.contains("runtimeOnly(\"org.glassfish.web:el-impl:2.2.1-b05\")") template.contains("runtimeOnly(\"org.apache.tomcat:tomcat-jdbc\")") template.contains("runtimeOnly(\"com.h2database:h2\")")