-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with sessionStore in v5.0.0 #563
Comments
Thanks for reporting the issue. When we back ported these changes, it looks like this got missed (the session doesn't exist in the later versions). Do you have an example project that reproduces this scenario? |
I created a project to reproduce this error: This is the basic authentication flow through the Google client. In the project, I included a readme that simulates the Google callback (so you don't have to configure an app on Google). The error occurs on the first call |
If you can release the release with these changes I would really appreciate it. |
Thank you for doing the leg work on the project. This will make sure we get a test added so it doesn't break in the future. I'll get the snapshot done today. Can you test with it first then we'll release? |
Sure, I can test it |
fix #563 - set the session store to JEESessionStore.INSTANCE
I've merged the pull request after testing it locally. It's now published (https://github.com/grails/grails-spring-security-rest/actions/runs/12355344062/job/34478858931) Assuming you have a repository in your
Then you should be able to use |
It worked! Thanks for solving the problem. |
You are welcome. I'll see if I can get this released quickly. |
5.0.1 is released with this change. |
Issue description
I'm using grails-spring-security-rest version 5.0.0 with grails 6.2.2
When trying to log in with Google2Client, I'm getting the following error:
Trying to debug, I saw that in RestOauthService it is passing the sessionStore as null:
And it's used in
final Optional<Credentials> getCredentials
:What could I be doing wrong?
If I customize the client, overriding
retrieveCredentials
to useJEESessionStore.INSTANCE
.The exception is thrown in
cleanAttemptedAuthentication
. which I was unable to override.The text was updated successfully, but these errors were encountered: