Use local OS' path separator

[csm10495]

I use diskcache and save the cache directory to a share drive. Later on, I use diskcache again to pull / update the data.

The problem I recently hit was when I added a Linux host to my previously-all-Windows pool:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/diskcache/core.py", line 1173, in get
    value = self._disk.fetch(mode, filename, db_value, read)
  File "/usr/local/lib/python3.10/site-packages/diskcache/core.py", line 281, in fetch
    with open(op.join(self._directory, filename), 'rb') as reader:
OSError: [Errno 22] Invalid argument: '/mnt/z-drive/Temp/shared/csmutil.cache/32\\25\\8a75134ac891498afaeb4efa3ec7.val'

It seems like diskcache saves a path inside the db based off the OS' path separator., which leads to this error ^. Can the path be normalized to the local-OS' path seperater?

[csm10495]

(One other side note: it was a bit of a pain to find this error, since the default value was getting used since it caught the OSError). Maybe the caught error could be more granular in the future :)

[csm10495]

Lots of possible ways to allow this:

• Maybe an option to chose the path separator, with a default of today's behavior.
• Maybe just .replace('\\', '/') on the paths in fetch() and i think remove()
• Maybe just always swap to using forward slashes regardless of OS. I can't think of an OS that at user-level doesn't allow forward slashes.

[csm10495]

For anyone out there who hits this, you can resolve via:

<diskcache_obj>._sql('UPDATE Cache SET filename = REPLACE(filename, "\\", "/") WHERE filename is not NULL').fetchall()

I run this every time i get a cache object just in case.

[dwr-psandhu]

I am hitting this as well and the fixes suggested by @csm10495 seem to point in the right direction. Any possibility of getting this fixed ? @ddorian @grantjenks ?

[ddorian]

Feel free to create a pull request.

[dwr-psandhu]

@ddorian I forked the repo but when I setup it fails (removing pylibmc deps fixed this). However for python 3.12 it doesn't seem to support python setup.py test for testing. Let me know if there are instructions other than https://grantjenks.com/docs/diskcache/development.html

[ddorian]

I used tox when running tests IIRC. I only used those instructions.