Client auth #191
Open
Client auth #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj3cheun
reviewed
Jul 31, 2025
| iframeStyle, iframeClassName, iframeProps, allowFullScreen, | ||
| tolerateLoadErrors | ||
| tolerateLoadErrors, | ||
| authToken |
Contributor
There was a problem hiding this comment.
move this out of generateiframeref if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR works with another PR on the main graphistry repo (dev/postmessage-auth-update branch) that handles the iframe side of the auth flow. Full end-to-end testing requires both PRs to land, but you can partially test the client-side auth flow through Storybook.
For testing:
cd projects/client-api-reactnpm run storybookIf the iframe doesn't load, check line 38 in
Graphistry.stories.jsxand hardcode:graphistryHost: 'https://hub.graphistry.com'and you can auth and check logs there. swapping out datasets though requires the PR in the main repo to land