From b95b73843175cdf789dda469af1d854b889d5459 Mon Sep 17 00:00:00 2001 From: David Buckley Date: Thu, 20 Nov 2025 22:38:15 +0000 Subject: [PATCH 1/2] fix running test_aggregator_buffers independently `carbon.service` makes patches to `carbon.state`, but when testing the suite, that's imported elsewhere. --- lib/carbon/tests/test_aggregator_buffers.py | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/carbon/tests/test_aggregator_buffers.py b/lib/carbon/tests/test_aggregator_buffers.py index 44a6669e..27cfa86f 100644 --- a/lib/carbon/tests/test_aggregator_buffers.py +++ b/lib/carbon/tests/test_aggregator_buffers.py @@ -6,6 +6,7 @@ from carbon import instrumentation from carbon.aggregator.buffers import BufferManager, IntervalBuffer, MetricBuffer from carbon.tests.util import TestSettings +import carbon.service # creates carbon.state.events class AggregationBufferManagerTest(TestCase): From a0eb400533cac4817b37b93f421fafb48daeacdc Mon Sep 17 00:00:00 2001 From: David Buckley Date: Thu, 20 Nov 2025 22:39:27 +0000 Subject: [PATCH 2/2] fix silly error in test --- lib/carbon/tests/test_aggregator_buffers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/carbon/tests/test_aggregator_buffers.py b/lib/carbon/tests/test_aggregator_buffers.py index 27cfa86f..46531261 100644 --- a/lib/carbon/tests/test_aggregator_buffers.py +++ b/lib/carbon/tests/test_aggregator_buffers.py @@ -202,7 +202,7 @@ def test_compute_value_deletes_too_many_buffers(self, metric_generated_mock): interval_buffer = IntervalBuffer(interval) interval_buffer.input((interval, 1.0)) self.metric_buffer.interval_buffers[interval] = interval_buffer - calls = [call("carbon.foo.bar", (interval, 1.0))] + calls.append(call("carbon.foo.bar", (interval, 1.0))) with patch("time.time", new=Mock(return_value=600)): self.metric_buffer.compute_value()