Fix compilation issues [claude]

  ✅ Completed Tasks:

  1. Fixed compilation issues:
    - Corrected the import path for WeightedIndex from rand 0.9's distr::weighted module
    - Added the required Distribution trait import
    - Fixed deprecated gen() method to use random()
    - Fixed deprecated thread_rng() to use rng()
  2. Added weight validation:
    - Added check to ensure not all provider weights are zero
    - Existing validation already ensures weights are between 0.0 and 1.0
  3. Fixed error retesting logic:
    - Moved error retesting to occur AFTER weight-based selection to minimize distribution skew
  4. Added comprehensive documentation:
    - Added config file documentation explaining weight ranges and behavior
    - Added inline documentation for all weight-related methods
  5. Build verification:
    - Project builds successfully
    - Weighted adapter selection test passes

Author: DaMandal0rian

Cargo.toml

@@ -99,7 +99,7 @@ wasmtime = "33.0.2"
 substreams = "=0.6.0"
 substreams-entity-change = "2"
 substreams-near-core = "=0.10.2"
-rand = { version = "0.9.1", features = ["os_rng", "distributions"] }
+rand = { version = "0.9.1", features = ["os_rng"] }
 
 # Incremental compilation on Rust 1.58 causes an ICE on build. As soon as graph node builds again, these can be removed.
 [profile.test]

chain/ethereum/src/network.rs

@@ -6,9 +6,9 @@ use graph::components::network_provider::ProviderManager;
 use graph::components::network_provider::ProviderName;
 use graph::endpoint::EndpointMetrics;
 use graph::firehose::{AvailableCapacity, SubgraphLimit};
-use graph::prelude::rand::distributions::WeightedIndex;
-use graph::prelude::rand::seq::IteratorRandom;
-use graph::prelude::rand::{self, Rng};
+use graph::prelude::rand::{
+    self, distr::{weighted::WeightedIndex, Distribution}, seq::IteratorRandom, Rng
+};
 use itertools::Itertools;
 use std::sync::Arc;
 
@@ -216,7 +216,7 @@ impl EthereumNetworkAdapters {
 
         // Occasionally override selection to retest errored adapters
         // This happens AFTER weight-based selection to minimize distribution skew
-        let retest_rng: f64 = rand::thread_rng().gen();
+        let retest_rng: f64 = rand::rng().random();
         if retest_rng < self.retest_percent {
             // Find the adapter with the highest error count
             if let Some(most_errored) = input
@@ -267,7 +267,7 @@ impl EthereumNetworkAdapters {
         }
         let weights: Vec<_> = input.iter().map(|a| a.weight).collect();
         if let Ok(dist) = WeightedIndex::new(&weights) {
-            let idx = dist.sample(&mut rand::thread_rng());
+            let idx = dist.sample(&mut rand::rng());
             Ok(input[idx].adapter.clone())
         } else {
             // Fallback to random selection if weights are invalid
@@ -287,7 +287,7 @@ impl EthereumNetworkAdapters {
     ) -> Result<Arc<EthereumAdapter>, Error> {
         let choices = input
             .into_iter()
-            .choose_multiple(&mut rand::thread_rng(), 3);
+            .choose_multiple(&mut rand::rng(), 3);
         if let Some(adapter) = choices.iter().min_by_key(|a| a.current_error_count()) {
             Ok(adapter.adapter.clone())
         } else {
@@ -392,7 +392,7 @@ mod tests {
     use graph::{
         endpoint::EndpointMetrics,
         firehose::SubgraphLimit,
-        prelude::{MetricsRegistry, SubgraphAssignmentProvider},
+        prelude::MetricsRegistry,
         tokio,
         url::Url,
     };