chain: Modernize EthereumAdapter.latest_block_header

Author: lutter

chain/ethereum/src/adapter.rs

@@ -1088,10 +1088,10 @@ pub trait EthereumAdapter: Send + Sync + 'static {
     ) -> Box<dyn Future<Item = LightEthereumBlock, Error = bc::IngestorError> + Send + Unpin>;
 
     /// Get the latest block, with only the header and transaction hashes.
-    fn latest_block_header(
+    async fn latest_block_header(
         &self,
         logger: &Logger,
-    ) -> Box<dyn Future<Item = web3::types::Block<H256>, Error = bc::IngestorError> + Send>;
+    ) -> Result<web3::types::Block<H256>, bc::IngestorError>;
 
     fn load_block(
         &self,

chain/ethereum/src/ethereum_adapter.rs

@@ -1258,39 +1258,34 @@ impl EthereumAdapterTrait for EthereumAdapter {
         Ok(ident)
     }
 
-    fn latest_block_header(
+    async fn latest_block_header(
         &self,
         logger: &Logger,
-    ) -> Box<dyn Future<Item = web3::types::Block<H256>, Error = IngestorError> + Send> {
+    ) -> Result<web3::types::Block<H256>, IngestorError> {
         let web3 = self.web3.clone();
-        Box::new(
-            retry("eth_getBlockByNumber(latest) no txs RPC call", logger)
-                .redact_log_urls(true)
-                .no_limit()
-                .timeout_secs(ENV_VARS.json_rpc_timeout.as_secs())
-                .run(move || {
-                    let web3 = web3.cheap_clone();
-                    async move {
-                        let block_opt = web3
-                            .eth()
-                            .block(Web3BlockNumber::Latest.into())
-                            .await
-                            .map_err(|e| {
-                                anyhow!("could not get latest block from Ethereum: {}", e)
-                            })?;
+        retry("eth_getBlockByNumber(latest) no txs RPC call", logger)
+            .redact_log_urls(true)
+            .no_limit()
+            .timeout_secs(ENV_VARS.json_rpc_timeout.as_secs())
+            .run(move || {
+                let web3 = web3.cheap_clone();
+                async move {
+                    let block_opt = web3
+                        .eth()
+                        .block(Web3BlockNumber::Latest.into())
+                        .await
+                        .map_err(|e| anyhow!("could not get latest block from Ethereum: {}", e))?;
 
-                        block_opt
-                            .ok_or_else(|| anyhow!("no latest block returned from Ethereum").into())
-                    }
-                })
-                .map_err(move |e| {
-                    e.into_inner().unwrap_or_else(move || {
-                        anyhow!("Ethereum node took too long to return latest block").into()
-                    })
+                    block_opt
+                        .ok_or_else(|| anyhow!("no latest block returned from Ethereum").into())
+                }
+            })
+            .map_err(move |e| {
+                e.into_inner().unwrap_or_else(move || {
+                    anyhow!("Ethereum node took too long to return latest block").into()
                 })
-                .boxed()
-                .compat(),
-        )
+            })
+            .await
     }
 
     fn latest_block(

chain/ethereum/src/ingestor.rs

@@ -210,7 +210,6 @@ impl PollingBlockIngestor {
     ) -> Result<BlockPtr, IngestorError> {
         eth_adapter
             .latest_block_header(&logger)
-            .compat()
             .await
             .map(|block| block.into())
     }