graph :Add spec version validations for composed subgraphs

Author: incrypto32

graph/src/data/subgraph/mod.rs

@@ -672,6 +672,56 @@ pub type SubgraphManifest<C> =
 pub struct UnvalidatedSubgraphManifest<C: Blockchain>(SubgraphManifest<C>);
 
 impl<C: Blockchain> UnvalidatedSubgraphManifest<C> {
+    fn validate_subgraph_datasources(
+        data_sources: &[DataSource<C>],
+        spec_version: &Version,
+    ) -> Vec<SubgraphManifestValidationError> {
+        let mut errors = Vec::new();
+
+        // Check spec version support for subgraph datasources
+        if *spec_version < SPEC_VERSION_1_3_0 {
+            if data_sources
+                .iter()
+                .any(|ds| matches!(ds, DataSource::Subgraph(_)))
+            {
+                errors.push(SubgraphManifestValidationError::DataSourceValidation(
+                    "subgraph".to_string(),
+                    anyhow!(
+                        "Subgraph datasources are not supported prior to spec version {}",
+                        SPEC_VERSION_1_3_0
+                    ),
+                ));
+                return errors;
+            }
+        }
+
+        let subgraph_ds_count = data_sources
+            .iter()
+            .filter(|ds| matches!(ds, DataSource::Subgraph(_)))
+            .count();
+
+        if subgraph_ds_count > 1 {
+            errors.push(SubgraphManifestValidationError::DataSourceValidation(
+                "subgraph".to_string(),
+                anyhow!("Cannot have more than one subgraph datasource"),
+            ));
+        }
+
+        let has_subgraph_ds = subgraph_ds_count > 0;
+        let has_onchain_ds = data_sources
+            .iter()
+            .any(|d| matches!(d, DataSource::Onchain(_)));
+
+        if has_subgraph_ds && has_onchain_ds {
+            errors.push(SubgraphManifestValidationError::DataSourceValidation(
+                "subgraph".to_string(),
+                anyhow!("Subgraph datasources cannot be used alongside onchain datasources"),
+            ));
+        }
+
+        errors
+    }
+
     /// Entry point for resolving a subgraph definition.
     /// Right now the only supported links are of the form:
     /// `/ipfs/QmUmg7BZC1YP1ca66rRtWKxpXp77WgVHrnv263JtDuvs2k`
@@ -742,6 +792,12 @@ impl<C: Blockchain> UnvalidatedSubgraphManifest<C> {
             }
         }
 
+        // Validate subgraph datasource constraints
+        errors.extend(Self::validate_subgraph_datasources(
+            &self.0.data_sources,
+            &self.0.spec_version,
+        ));
+
         match errors.is_empty() {
             true => Ok(self.0),
             false => Err(errors),
@@ -1005,6 +1061,17 @@ impl<C: Blockchain> UnresolvedSubgraphManifest<C> {
             );
         }
 
+        // Validate subgraph datasource constraints
+        if let Some(error) = UnvalidatedSubgraphManifest::<C>::validate_subgraph_datasources(
+            &data_sources,
+            &spec_version,
+        )
+        .into_iter()
+        .next()
+        {
+            return Err(anyhow::Error::from(error).into());
+        }
+
         // Check the min_spec_version of each data source against the spec version of the subgraph
         let min_spec_version_mismatch = data_sources
             .iter()

store/test-store/tests/chain/ethereum/manifest.rs

@@ -1706,3 +1706,115 @@ dataSources:
         assert_eq!(3, decls.len());
     });
 }
+
+#[tokio::test]
+async fn multiple_subgraph_ds_manifest_should_fail() {
+    let yaml = "
+schema:
+  file:
+    /: /ipfs/Qmschema
+dataSources:
+  - name: SubgraphSource1
+    kind: subgraph
+    entities:
+        - User
+    network: mainnet
+    source: 
+      address: 'QmSource'
+      startBlock: 9562480
+    mapping:
+      apiVersion: 0.0.6
+      language: wasm/assemblyscript
+      entities:
+        - TestEntity
+      file:
+        /: /ipfs/Qmmapping
+      handlers:
+        - handler: handleEntity
+          entity: User
+  - name: SubgraphSource2
+    kind: subgraph
+    entities:
+        - Profile
+    network: mainnet
+    source:
+      address: 'QmSource2'
+      startBlock: 9562500
+    mapping:
+      apiVersion: 0.0.6
+      language: wasm/assemblyscript
+      entities:
+        - TestEntity
+      file:
+        /: /ipfs/Qmmapping
+      handlers:
+        - handler: handleProfile
+          entity: Profile
+specVersion: 1.3.0
+";
+
+    let result = try_resolve_manifest(yaml, SPEC_VERSION_1_3_0).await;
+    assert!(result.is_err());
+    let err = result.unwrap_err();
+    assert!(err
+        .to_string()
+        .contains("Cannot have more than one subgraph datasource"));
+}
+
+#[tokio::test]
+async fn mixed_subgraph_and_onchain_ds_manifest_should_fail() {
+    let yaml = "
+schema:
+  file:
+    /: /ipfs/Qmschema
+dataSources:
+  - name: SubgraphSource
+    kind: subgraph
+    entities:
+        - User
+    network: mainnet
+    source: 
+      address: 'QmSource'
+      startBlock: 9562480
+    mapping:
+      apiVersion: 0.0.6
+      language: wasm/assemblyscript
+      entities:
+        - TestEntity
+      file:
+        /: /ipfs/Qmmapping
+      handlers:
+        - handler: handleEntity
+          entity: User
+  - kind: ethereum/contract
+    name: Gravity
+    network: mainnet
+    source:
+      address: '0x2E645469f354BB4F5c8a05B3b30A929361cf77eC'
+      abi: Gravity
+      startBlock: 1
+    mapping:
+      kind: ethereum/events
+      apiVersion: 0.0.6
+      language: wasm/assemblyscript
+      entities:
+        - Gravatar
+      abis:
+        - name: Gravity
+          file:
+            /: /ipfs/Qmabi
+      file:
+        /: /ipfs/Qmmapping
+      handlers:
+        - event: NewGravatar(uint256,address,string,string)
+          handler: handleNewGravatar
+specVersion: 1.3.0
+";
+
+    let result = try_resolve_manifest(yaml, SPEC_VERSION_1_3_0).await;
+    assert!(result.is_err());
+    let err = result.unwrap_err();
+    assert!(err
+        .to_string()
+        .contains("Subgraph datasources cannot be used alongside onchain datasources"));
+}