test: verify SubgraphNotFound error for non-existent subgraph removal

Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>

Author: dimitrovmaksim

server/graphman/tests/deployment_mutation.rs

@@ -403,17 +403,44 @@ fn graphql_cannot_remove_subgraph_with_invalid_name() {
         )
         .await;
 
-        let success_resp = json!({
-            "data": {
-                "deployment": {
-                    "remove": {
-                        "success": true,
+        let data = &resp["data"]["deployment"];
+        let errors = resp["errors"].as_array().unwrap();
+
+        assert!(data.is_null());
+        assert_eq!(errors.len(), 1);
+        assert_eq!(
+            errors[0]["message"].as_str().unwrap(),
+            "store error: Subgraph name must contain only a-z, A-Z, 0-9, '-' and '_'"
+        );
+    });
+}
+
+#[test]
+fn graphql_remove_returns_error_for_non_existing_subgraph() {
+    run_test(|| async {
+        let resp = send_graphql_request(
+            json!({
+                "query": r#"mutation RemoveNonExistingSubgraph {
+                    deployment {
+                        remove(name: "non_existing_subgraph") {
+                            success
+                        }
                     }
-                }
-            }
-        });
+                }"#
+            }),
+            VALID_TOKEN,
+        )
+        .await;
 
-        assert_ne!(resp, success_resp);
+        let data = &resp["data"]["deployment"];
+        let errors = resp["errors"].as_array().unwrap();
+
+        assert!(data.is_null());
+        assert_eq!(errors.len(), 1);
+        assert_eq!(
+            errors[0]["message"].as_str().unwrap(),
+            "store error: subgraph not found: non_existing_subgraph"
+        );
     });
 }
 

store/test-store/tests/postgres/subgraph.rs

@@ -1232,3 +1232,18 @@ fn fail_unfail_non_deterministic_error_noop() {
         test_store::remove_subgraphs().await;
     })
 }
+
+#[test]
+fn remove_nonexistent_subgraph_returns_not_found() {
+    test_store::run_test_sequentially(|store| async move {
+        remove_subgraphs().await;
+
+        let name = SubgraphName::new("nonexistent/subgraph").unwrap();
+        let result = store.subgraph_store().remove_subgraph(name.clone()).await;
+
+        assert!(matches!(
+            result,
+            Err(StoreError::SubgraphNotFound(n)) if n == name.to_string()
+        ));
+    })
+}