graph: Prevent duplicate source subgraphs in manifest validation

Author: incrypto32

graph/src/data/subgraph/mod.rs

@@ -719,6 +719,23 @@ impl<C: Blockchain> UnvalidatedSubgraphManifest<C> {
             ));
         }
 
+        // Check for duplicate source subgraphs
+        let mut seen_sources = std::collections::HashSet::new();
+        for ds in data_sources.iter() {
+            if let DataSource::Subgraph(ds) = ds {
+                let source_id = ds.source.address();
+                if !seen_sources.insert(source_id.clone()) {
+                    errors.push(SubgraphManifestValidationError::DataSourceValidation(
+                        "subgraph".to_string(),
+                        anyhow!(
+                            "Multiple subgraph datasources cannot use the same source subgraph {}",
+                            source_id
+                        ),
+                    ));
+                }
+            }
+        }
+
         errors
     }
 

graph/src/data_source/subgraph.rs

@@ -292,9 +292,7 @@ impl UnresolvedDataSource {
             .iter()
             .any(|ds| matches!(ds, crate::data_source::DataSource::Subgraph(_)))
         {
-            return Err(anyhow!(
-                "Nested subgraph data sources are not supported."
-            ));
+            return Err(anyhow!("Nested subgraph data sources are not supported."));
         }
 
         if source_spec_version < &SPEC_VERSION_1_3_0 {

store/test-store/tests/chain/ethereum/manifest.rs

@@ -318,7 +318,7 @@ dataSources:
         - Profile
     network: mainnet
     source:
-      address: 'QmSource'
+      address: 'QmSource2'
       startBlock: 9562500
     mapping:
       apiVersion: 0.0.6
@@ -1708,60 +1708,6 @@ dataSources:
     });
 }
 
-#[tokio::test]
-async fn multiple_subgraph_ds_manifest_should_fail() {
-    let yaml = "
-schema:
-  file:
-    /: /ipfs/Qmschema
-dataSources:
-  - name: SubgraphSource1
-    kind: subgraph
-    entities:
-        - User
-    network: mainnet
-    source: 
-      address: 'QmSource'
-      startBlock: 9562480
-    mapping:
-      apiVersion: 0.0.6
-      language: wasm/assemblyscript
-      entities:
-        - TestEntity
-      file:
-        /: /ipfs/Qmmapping
-      handlers:
-        - handler: handleEntity
-          entity: User
-  - name: SubgraphSource2
-    kind: subgraph
-    entities:
-        - Profile
-    network: mainnet
-    source:
-      address: 'QmSource2'
-      startBlock: 9562500
-    mapping:
-      apiVersion: 0.0.6
-      language: wasm/assemblyscript
-      entities:
-        - TestEntity
-      file:
-        /: /ipfs/Qmmapping
-      handlers:
-        - handler: handleProfile
-          entity: Profile
-specVersion: 1.3.0
-";
-
-    let result = try_resolve_manifest(yaml, SPEC_VERSION_1_3_0).await;
-    assert!(result.is_err());
-    let err = result.unwrap_err();
-    assert!(err
-        .to_string()
-        .contains("Cannot have more than one subgraph datasource"));
-}
-
 #[tokio::test]
 async fn mixed_subgraph_and_onchain_ds_manifest_should_fail() {
     let yaml = "