Add YAML parsing support to WASM runtime#5785
Merged
Conversation
2 tasks
isum
force-pushed
the
ion/add-yaml-parsing-support-to-wasm-runtime
branch
2 times, most recently
from
169124a to
c3b3ffb
Compare
mangas
reviewed
Feb 11, 2025
| } | ||
| } | ||
|
|
||
| /// For debugging, it might be useful to know exactly which bytes could not be parsed as YAML, but |
Contributor
There was a problem hiding this comment.
Do we have a better indication of where the error is? If so the error could be more relevant and show the part that broke. Not super important just a thought
Member
Author
There was a problem hiding this comment.
There is no straightforward way to do this nicely. All the logging context should be enough to identify the cause of a parsing error, so I will leave it as is for now
isum
force-pushed
the
ion/add-yaml-parsing-support-to-wasm-runtime
branch
from
c3b3ffb to
ed04edb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements two host functions that are exported to WASM mappings, allowing them to easily parse YAML documents.
The main use case for this feature is to parse subgrah manifests, but it is flexible enough to allow parsing any YAML document.
Part of #5772
AssemblyScript types are defined in graphprotocol/graph-tooling#1935
Todos