Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denied sender aggregates too slow #599

Open
gusinacio opened this issue Jan 31, 2025 · 0 comments
Open

Denied sender aggregates too slow #599

gusinacio opened this issue Jan 31, 2025 · 0 comments
Labels
meta:good-first-issue Good for newcomers p2 Medium priority type:bug Something isn't working

Comments

@gusinacio
Copy link
Member

Describe the bug
When a sender is denied, it aggregates too slow since rav requests are only triggered by UpdateReceiptFees message.
Those messages are only sent when the rav request finishes or after retry_interval (~30 secs).

This makes the aggregation process too slow in cases where the aggregator is UP. Our logic currently treats that the aggregator is down but what might have happened is that tap-agent was down for a while and now the sender is denied.

Solution
We should use the backoff_information to retry aggregating instead of a fixed retry_interval.

@gusinacio gusinacio added meta:good-first-issue Good for newcomers p2 Medium priority type:bug Something isn't working labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta:good-first-issue Good for newcomers p2 Medium priority type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant