github: annotation's message was empty(#88)

* github: annotation's message was empty

Author: kamilkisiela

.gitignore

@@ -5,3 +5,5 @@ yarn-error.log
 **/*/dist/
 **/*/build/
 **/*/yarn-error.log
+.env
+private-key.pem

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ### vNEXT
 
+- **github**: annotation's `message` was empty [PR #87](https://github.com/kamilkisiela/graphql-inspector/pull/87)
+
 ### v0.13.1
 
 - **cli**: bump `apollo-server@2.4.0` [PR #86](https://github.com/kamilkisiela/graphql-inspector/pull/86)

app.js

@@ -0,0 +1,4 @@
+// For quick tests
+const appFn = require('@graphql-inspector/github').default;
+
+module.exports = appFn;

package.json

@@ -42,7 +42,7 @@
     "husky": "1.2.0",
     "immer": "1.10.0",
     "lerna": "3.6.0",
-    "netlify-lambda": "1.1.1",
+    "netlify-lambda": "1.4.2",
     "shelljs": "0.8.3"
   },
   "workspaces": [

packages/github-actions/package.json

@@ -34,7 +34,7 @@
   "dependencies": {
     "@graphql-inspector/github": "0.0.0-PLACEHOLDER",
     "graphql": "14.0.2",
-    "probot": "7.4.0",
+    "probot": "7.5.0",
     "uuid": "3.3.2"
   },
   "devDependencies": {

packages/github/package.json

@@ -24,7 +24,7 @@
   },
   "scripts": {
     "start": "probot run ./dist/index.js",
-    "dev": "yarn build && yarn now-start",
+    "dev": "yarn build && yarn start",
     "build": "tsc",
     "clean": "rm -rf dist/",
     "deploy": "now --docker",
@@ -42,7 +42,7 @@
     "@types/express": "4.16.0",
     "@types/graphql": "14.0.3",
     "graphql": "14.0.2",
-    "probot": "7.4.0",
+    "probot": "7.5.0",
     "smee-client": "1.0.2",
     "typescript": "3.2.2"
   }

packages/github/src/diff.ts

@@ -82,7 +82,7 @@ function annotate({
     title: change.message,
     annotation_level: levelMap[level],
     path,
-    message: change.criticality.reason || '',
+    message: change.criticality.reason || change.message,
     start_line: loc.line,
     end_line: loc.line,
   };

packages/github/src/probot.ts

@@ -180,6 +180,8 @@ export async function handleAction({
           summary: issueInfo,
         };
 
+  context.log.info(`Sending annotations (${annotations.length})`);
+
   await check.annotations({
     url,
     context,
@@ -188,9 +190,13 @@ export async function handleAction({
     annotations,
   });
 
+  context.log.info(`Finishing check (${conclusion})`);
+
   await check.complete({
     url,
     context,
     conclusion,
   });
+
+  context.log.info(`Completed`);
 }

yarn.lock

@@ -5487,10 +5487,10 @@ dotenv@6.0.0:
   resolved "https://registry.yarnpkg.com/dotenv/-/dotenv-6.0.0.tgz#24e37c041741c5f4b25324958ebbc34bca965935"
   integrity sha512-FlWbnhgjtwD+uNLUGHbMykMOYQaTivdHEmYwAKFjn6GKe/CqY0fNae93ZHTd20snh9ZLr8mTzIL9m0APQ1pjQg==
 
-dotenv@~6.1.0:
-  version "6.1.0"
-  resolved "https://registry.yarnpkg.com/dotenv/-/dotenv-6.1.0.tgz#9853b6ca98292acb7dec67a95018fa40bccff42c"
-  integrity sha512-/veDn2ztgRlB7gKmE3i9f6CmDIyXAy6d5nBq+whO9SLX+Zs1sXEgFLPi+aSuWqUuusMfbi84fT8j34fs1HaYUw==
+dotenv@~6.2.0:
+  version "6.2.0"
+  resolved "https://registry.yarnpkg.com/dotenv/-/dotenv-6.2.0.tgz#941c0410535d942c8becf28d3f357dbd9d476064"
+  integrity sha512-HygQCKUBSFl8wKQZBSemMywRWcEDNidvNbjGVyZu3nbZ8qq9ubiPoGLMdRDpfSrpkkm9BXYFkpKxxFX38o/76w==
 
 dtrace-provider@~0.8:
   version "0.8.7"
@@ -9301,6 +9301,11 @@ jws@^3.1.5:
     jwa "^1.2.0"
     safe-buffer "^5.0.1"
 
+jwt-decode@^2.2.0:
+  version "2.2.0"
+  resolved "https://registry.yarnpkg.com/jwt-decode/-/jwt-decode-2.2.0.tgz#7d86bd56679f58ce6a84704a657dd392bba81a79"
+  integrity sha1-fYa9VmefWM5qhHBKZX3TkruoGnk=
+
 killable@^1.0.0:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/killable/-/killable-1.0.1.tgz#4c8ce441187a061c7474fb87ca08e2a638194892"
@@ -10445,10 +10450,10 @@ neo-async@^2.5.0:
   resolved "https://registry.yarnpkg.com/neo-async/-/neo-async-2.6.0.tgz#b9d15e4d71c6762908654b5183ed38b753340835"
   integrity sha512-MFh0d/Wa7vkKO3Y3LlacqAEeHK0mckVqzDieUKTT+KGxi+zIpeVsFxymkIiRpbpDziHc290Xr9A1O4Om7otoRA==
 
-netlify-lambda@1.1.1:
-  version "1.1.1"
-  resolved "https://registry.yarnpkg.com/netlify-lambda/-/netlify-lambda-1.1.1.tgz#6f824502f1ed7c3aa2267edea673060b3e3639c9"
-  integrity sha512-/wfjyDLBk4Qfatl7UYJfsV5oArJEbGwLf/IO6V/ii0FvtMDfVbILZSICeuZqLiQgHHYGmTe1wrqZPGBiBdZ28A==
+netlify-lambda@1.4.2:
+  version "1.4.2"
+  resolved "https://registry.yarnpkg.com/netlify-lambda/-/netlify-lambda-1.4.2.tgz#cd4972c942e449c64b30d58ca7d7725a58547fb7"
+  integrity sha512-Iy9SoS0sAyAHP8Bg93kLO+/RJkSf8Q0NqzBchMNAa6xKbDmcTxqg6crMk3mRNkCewgWhvN5uGSWmaA7FZHN1sQ==
   dependencies:
     "@babel/core" "^7.0.0"
     "@babel/plugin-proposal-class-properties" "^7.0.0"
@@ -10460,6 +10465,7 @@ netlify-lambda@1.1.1:
     commander "^2.17.1"
     express "^4.16.3"
     express-logging "^1.1.1"
+    jwt-decode "^2.2.0"
     toml "^2.3.3"
     webpack "^4.17.1"
     webpack-merge "^4.1.4"
@@ -12098,10 +12104,10 @@ private@^0.1.6, private@^0.1.8:
   resolved "https://registry.yarnpkg.com/private/-/private-0.1.8.tgz#2381edb3689f7a53d653190060fcf822d2f368ff"
   integrity sha512-VvivMrbvd2nKkiG38qjULzlc+4Vx4wm/whI9pQD35YrARNnhxeiRktSOhSukRLFNlzg6Br/cJPet5J/u19r/mg==
 
-probot@7.4.0:
-  version "7.4.0"
-  resolved "https://registry.yarnpkg.com/probot/-/probot-7.4.0.tgz#96a70148e8a114bcba75fd1a261155a559916cc5"
-  integrity sha512-xyvra7baRi8o/KortENZHFae8TZCBHvrKKTVvL1l5DhLBb1mfey+6AM2bxEai5ajDkrKnNiA69aDtb32WO5bRQ==
+probot@7.5.0:
+  version "7.5.0"
+  resolved "https://registry.yarnpkg.com/probot/-/probot-7.5.0.tgz#17f4441210c95b822a53dc9748fb17261a1aacdf"
+  integrity sha512-i7YCcSWf0tT2FPlIqgtJC2ZV/jelB2y3tf+TRWrvt4kJAgYEhgrofyM2pl/f+lg7xdULP/9FNAayn0sjv/u7kg==
   dependencies:
     "@octokit/rest" "^15.18.0"
     "@octokit/webhooks" "^5.0.2"
@@ -12112,7 +12118,7 @@ probot@7.4.0:
     bunyan-sentry-stream "^1.1.0"
     cache-manager "^2.4.0"
     commander "^2.19.0"
-    dotenv "~6.1.0"
+    dotenv "~6.2.0"
     express "^4.16.2"
     express-async-errors "^3.0.0"
     hbs "^4.0.1"
@@ -12125,7 +12131,7 @@ probot@7.4.0:
     raven "^2.4.2"
     resolve "^1.4.0"
     semver "^5.5.0"
-    supports-color "^5.5.0"
+    supports-color "^6.0.0"
     update-dotenv "^1.1.0"
     uuid "^3.2.1"