Skip to content

Commit 5ff52a5

Browse files
authored
fix chart typos (#49073)
1 parent 3c3b0b9 commit 5ff52a5

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

examples/chart/teleport-cluster/templates/_helpers.tpl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ if serviceAccount is not defined or serviceAccount.name is empty, use .Release.N
1010
Create the name of the service account to use in the auth config check hook.
1111
1212
If the chart is creating service accounts, we know we can create new arbitrary service accounts.
13-
We cannot reuse the same name as the deployment SA because the non-hook sevrice account might
13+
We cannot reuse the same name as the deployment SA because the non-hook service account might
1414
not exist yet. We tried being smart with hooks but ArgoCD doesn't differentiate between install
1515
and upgrade, causing various issues on update and eventually forcing us to use a separate SA.
1616
@@ -22,7 +22,7 @@ so we can use the same SA for deployments and hooks.
2222
{{- include "teleport-cluster.auth.serviceAccountName" . -}}
2323
{{- if .Values.serviceAccount.create -}}
2424
-hook
25-
{{- end}}
25+
{{- end -}}
2626
{{- end -}}
2727

2828
{{- define "teleport-cluster.proxy.serviceAccountName" -}}
@@ -33,7 +33,7 @@ so we can use the same SA for deployments and hooks.
3333
Create the name of the service account to use in the proxy config check hook.
3434
3535
If the chart is creating service accounts, we know we can create new arbitrary service accounts.
36-
We cannot reuse the same name as the deployment SA because the non-hook sevrice account might
36+
We cannot reuse the same name as the deployment SA because the non-hook service account might
3737
not exist yet. We tried being smart with hooks but ArgoCD doesn't differentiate between install
3838
and upgrade, causing various issues on update and eventually forcing us to use a separate SA.
3939
@@ -45,7 +45,7 @@ so we can use the same SA for deployments and hooks.
4545
{{- include "teleport-cluster.proxy.serviceAccountName" . -}}
4646
{{- if .Values.serviceAccount.create -}}
4747
-hook
48-
{{- end}}
48+
{{- end -}}
4949
{{- end -}}
5050

5151
{{- define "teleport-cluster.version" -}}

examples/chart/teleport-cluster/tests/predeploy_test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ tests:
212212
path: spec.template.spec.serviceAccountName
213213
value: helm-test-sa-hook
214214

215-
- it: should use serviceAccount.name for auth predeploy job SA when set in values and we're not cretaing SAs
215+
- it: should use serviceAccount.name for auth predeploy job SA when set in values and we're not creating SAs
216216
template: auth/predeploy_job.yaml
217217
set:
218218
clusterName: helm-lint
@@ -244,7 +244,7 @@ tests:
244244
path: spec.template.spec.serviceAccountName
245245
value: helm-test-sa-proxy-hook
246246

247-
- it: should use serviceAccount.name for proxy predeploy job SA when set in values and we're not cretaing SAs
247+
- it: should use serviceAccount.name for proxy predeploy job SA when set in values and we're not creating SAs
248248
template: proxy/predeploy_job.yaml
249249
set:
250250
clusterName: helm-lint

0 commit comments

Comments
 (0)