Skip to content

Commit 931c4b9

Browse files
authored
rfd updates (#50535)
1 parent 074d584 commit 931c4b9

12 files changed

+11
-19
lines changed

rfd/0016-dynamic-configuration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ ensure backward compatibility with the already established workflows.
6565
#### Choice 2.A
6666

6767
In this option, dynamic-configuration resources are understood to exist only
68-
if they have been comitted as a result of having been specified in static
68+
if they have been committed as a result of having been specified in static
6969
configuration or via `tctl create`.
7070

7171
3. The command `tctl get cap` would therefore return an error saying

rfd/0047-drop-vendor.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ which is difficult to maintain in a cross-platform way, and has broken
9797
[gopls integration](https://github.com/gravitational/teleport/blob/30effc1f08b6a699772ff22f79ebe756fe1a1e34/Makefile#L942-L952)
9898
a common tool used in Go development environments.
9999

100-
Lastly, there is no guarantee that the code comitted to vendor actually
100+
Lastly, there is no guarantee that the code committed to vendor actually
101101
reflects the contents of go.mod. The onus is on the developer to remember to run
102102
`make update-vendor` and commit the results after making changes to
103103
dependencies. This has created several cases of confusing build results amongst

rfd/0055-webui-ss-paginate-filter.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ This technique does not support sorting, but provides faster performance and is
7777

7878
The web UI will not request for the entire list of resources upfront, but will provide a user with a `fetch more` button if a user desires to see the next page if any.
7979

80-
We can branch off into two functions with current `ListResources` based on if sorting was requested (orting will be disabled for `tsh`, so that `tsh` performance will not be affected):
80+
We can branch off into two functions with current `ListResources` based on if sorting was requested (sorting will be disabled for `tsh`, so that `tsh` performance will not be affected):
8181

8282
- `listResources` (keeps current behavior)
8383
- `listResourcesWithSort`

rfd/0067-desktop-access-file-system-sharing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@ requested by RDP.
490490

491491
For files, `last_modified` is the last modified time of the file as specified by the [`mtime`](https://www.makeuseof.com/linux-file-timestamps/), in milliseconds
492492
since the [UNIX epoch](https://en.wikipedia.org/wiki/Unix_time). For directories, `last_modified` should also be set to the
493-
[directory's `mtime`](https://stackoverflow.com/a/3620704/6277051) when suchinformation is available. If such information is unavailable for a directory, such as
493+
[directory's `mtime`](https://stackoverflow.com/a/3620704/6277051) when such information is available. If such information is unavailable for a directory, such as
494494
in a browser environment, this value should be assigned the UNIX epoch itself (0).
495495

496496
For files, `size` is the size of the file in bytes. For directories, `size` is not the total size of the contents of the

rfd/0073-discover.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ auto-discovery by going through the following flow:
202202
3. The selected agent will perform initial discovery according to the provided
203203
filters. This can be implemented by providing an API for the web UI to create
204204
a "discovery request" which agents will watch.
205-
4. The agent will attempt to fullfill the discovery request and will report
205+
4. The agent will attempt to fulfill the discovery request and will report
206206
errors, e.g. insufficient IAM policy, to the user. This can be implemented by
207207
filling out a Status field on the agent's resource spec.
208208
5. If successful, the UI wizard will display all resources matching the

rfd/0083-machine-id-host-certs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ Are you sure you want to continue connecting (yes/no/[fingerprint])?
165165
This is nearly identical to the usual ssh TOFU message, save for the
166166
easy-to-miss "Certificate invalid: expired" message. Users are likely
167167
conditioned to accept this, and if that happens the expired or invalid host key
168-
will be comitted to their `known_hosts` permanently, after which the "expired"
168+
will be committed to their `known_hosts` permanently, after which the "expired"
169169
message will not be shown again.
170170

171171
We'll need to document this caveat along with a workaround (e.g. a

rfd/0084-license-expiration-warnings.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ state: implemented
99
## Required approvers
1010

1111
- Engineering: `@r0mant`
12-
- Product: `@klizentas && @xinding33`
12+
- Product: `@klizhentas && @xinding33`
1313
- Security: `@reedloden`
1414

1515
## What

rfd/0089-merge-webapps.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ build systems to successfully build Teleport.
187187
- [ ] Remove `/webassets` submodule
188188
- This submodule is no longer required as the web UI will be built on-demand.
189189
- The folder will remain as the output location of the on-demand build but
190-
will not be comitted.
190+
will not be committed.
191191
- [ ] Clone the [Webapps repository](https://github.com/gravitational/webapps) into
192192
the Teleport root. [Maintaining their respective git histories](https://stackoverflow.com/questions/13040958/merge-two-git-repositories-without-breaking-file-history)
193193
- [ ] This will need to be done for every respective version branch (v9, v10, v11)

rfd/0122-moderated-file-transfers.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ OnApprove:
136136
3. We can then use a policy checker to see if the approvers fulfill any moderation policy on the original requester. We can treat this check the same as the `checkIfStart` conditional for opening a session. If this comes back true, we notify the original requester with an event containing the ID of the `FileTransferRequest`
137137

138138
Once the client receives this final "approved" message, we can automatically send a "normal" SFTP request (over HTTP) with two new optional params, `sessionID` and `commandRequestId` (similar to the new optional `webauthn` param in this same request). The benefits of using the normal SFTP request is that we can conditionally choose to skip this entire approval process flow for non-moderated sessions.
139-
If the session is not moderated, just send the SFTP request as usual. If it is, do the song and dance perscribed above.
139+
If the session is not moderated, just send the SFTP request as usual. If it is, do the song and dance prescribed above.
140140

141141
### Updated file transfer api handler
142142

rfd/0133-connect-my-computer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ agent. This follows from the behavior described in the “Downloading the agent
417417
418418
#### Log rotation
419419
420-
The MVP is not going to perform any extra log rotation beyond what the Teleport agent offerts out of
420+
The MVP is not going to perform any extra log rotation beyond what the Teleport agent offers out of
421421
the box which is creating a new log file every 24 hours. The logs are thus stored in the same
422422
directory as the data directory of the agent and are removed together with the agent.
423423

rfd/0143-external-k8s-joining.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ traced back to a specific Kubernetes pod.
294294

295295
## Alternatives
296296

297-
### Introducing a seperate `kubernetes_remote` join method
297+
### Introducing a separate `kubernetes_remote` join method
298298

299299
One alternative implementation was to introduce a new `kubernetes_remote` join
300300
method that would use a bi-di gRPC RPC to create a challenge and response flow

rfd/cspell.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,6 @@
322322
"cmpopts",
323323
"cockroachdb",
324324
"codingllama",
325-
"comitted",
326325
"committerdate",
327326
"commonfolk",
328327
"compat",
@@ -395,7 +394,6 @@
395394
"fspmarshall",
396395
"ftruncate",
397396
"fullchain",
398-
"fullfill",
399397
"fxamacker",
400398
"gcpxyz",
401399
"germaine",
@@ -465,7 +463,6 @@
465463
"keypresses",
466464
"keyv",
467465
"kimlisa",
468-
"klizentas",
469466
"klizhentas",
470467
"kubeconfig",
471468
"kubeconfigs",
@@ -554,7 +551,6 @@
554551
"objc",
555552
"octocats",
556553
"offboarding",
557-
"offerts",
558554
"olekukonko",
559555
"omitempty",
560556
"oncall",
@@ -568,7 +564,6 @@
568564
"opentelemetry",
569565
"oqzt",
570566
"orapki",
571-
"orting",
572567
"osascript",
573568
"otel",
574569
"otelaws",
@@ -583,7 +578,6 @@
583578
"partman",
584579
"passwordless",
585580
"pchar",
586-
"perscribed",
587581
"pgbouncer",
588582
"pgconn",
589583
"pgoutput",
@@ -677,7 +671,6 @@
677671
"selfsubjectaccessreviews",
678672
"selfsubjectrulesreviews",
679673
"sendmsg",
680-
"seperate",
681674
"serviceaccount",
682675
"serviceaccounts",
683676
"servicecfg",
@@ -734,7 +727,6 @@
734727
"subselection",
735728
"subselects",
736729
"subtests",
737-
"suchinformation",
738730
"sudoer",
739731
"sudoersfile",
740732
"supercede",

0 commit comments

Comments
 (0)