Skip to content

Commit c68e919

Browse files
authored
rfd updates (#50099)
1 parent a191cc1 commit c68e919

7 files changed

+19
-19
lines changed

rfd/0054-passwordless-macos.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ allowed by Apple). It is likely possible to make use of those APIs for Teleport
389389
Cloud, but we would need a solution for other installations regardless.
390390
391391
A final consequence of the above is that Passkey support (aka iCloud-stored
392-
credentials) for CLIs is out of the roadmap for the forseeable future (but
392+
credentials) for CLIs is out of the roadmap for the foreseeable future (but
393393
Passkeys _can_ be used for Safari-based access).
394394
395395
References:

rfd/0162-machine-id-token-join-method-bot-instance.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Terminology:
2222
- Bot instance: A single instance of `tbot` running on a host.
2323

2424
This RFD proposes improvements to the management of fleets of Machine ID Bots.
25-
These improvements are mostly targetted at on-prem deployments, where the
25+
These improvements are mostly targeted at on-prem deployments, where the
2626
delegated join methods are not available.
2727

2828
The improvements will focus on three points:
@@ -564,7 +564,7 @@ Existing analytics for join, renewal and certificate generation should be
564564
extended to include the BotInstance ID anonymized. This will allow them to be
565565
linked together.
566566

567-
### Migration/Compatability
567+
### Migration/Compatibility
568568

569569
The "create if not exists" behaviour of the BotInstance resource will mean that
570570
existing Bot instances will have a BotInstance resource created on their first

rfd/0167-debug-service.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ $ teleport debug profile heap,goroutine > profile.tar.gz
197197
### Security
198198

199199
Items listed on this section are have their impact limited due to the fact that
200-
the service will not be exposed outsite the machine/container running the
200+
the service will not be exposed outside the machine/container running the
201201
Teleport instance.
202202

203203
#### CPU and Memory consumption during profiling

rfd/0173-terraform-machine-id.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ $ terraform apply ...
176176
Please check if you have the rights to create role, bot and token resources. You might need to re-log in for new rights to take effect.
177177
(tsh logout --proxy="mytenant.teleport.sh:443" --user="hugo.hervieux@goteleport.com")
178178
```
179-
- run a one-shot tbot to retrieve certificates via the bot for the terraformn role
179+
- run a one-shot tbot to retrieve certificates via the bot for the terraform role
180180
- set the environment variable `TF_TELEPORT_IDENTITY_FILE_BASE64`
181181
- echo a user-friendly message containing the bot name and the certificate validity
182182

rfd/0178-github-proxy.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@ for GitHub repositories.
2020
GitHub Enterprise provides a security feature to bring your own SSH certificate
2121
authorities (CA). Once a CA is added, your organization can sign short-lived
2222
client SSH certificates to access organization resources on GitHub. You can
23-
also require your memebers to use these SSH certificates, which disables Git
23+
also require your members to use these SSH certificates, which disables Git
2424
access using personal tokens.
2525

2626
The concept of short-lived SSH certificates to access organization resources
2727
aligns well with Teleport, where a Teleport user begins their day with a 'tsh'
2828
session, accessing only what their roleset permits. Teleport can also easily
2929
provide the capability to issue of short-lived client SSH certificates for
30-
GitHub organzations so Teleport customers do not need to implement a separate
30+
GitHub organizations so Teleport customers do not need to implement a separate
3131
system for issuing these certificates.
3232

3333
Teleport also offers other GitHub-related features, such as [GitHub IAM
@@ -185,14 +185,14 @@ $ tsh git clone git@github.com:my-org/my-repo.git
185185

186186
The first `git` command (including the `clone`) will open a browser window to
187187
trigger the GitHub OAuth flow for Teleport to grab Bob's GitHub ID and
188-
username. Once Bob sees "Login Successful" from the brower and goes back to his
188+
username. Once Bob sees "Login Successful" from the browser and goes back to his
189189
terminal.
190190

191191
The repo is cloned by now, and Bob can `cd` into the directory and perform regular
192192
`git` commands naturally, without using `tsh`. Bob can also find the
193193
"authorized" GitHub username in `tsh status` or `tsh git ls`.
194194

195-
On the second day (as the `tsh` session expiress), when Bob tries to `git
195+
On the second day (as the `tsh` session expires), when Bob tries to `git
196196
fetch` from the repo, the command prompts to login into Teleport. The command
197197
proceeds as usual once Teleport login is successful.
198198

@@ -264,7 +264,7 @@ Charlie is an auditor and is able to see the audit events from Web UI:
264264
#### Alice wants to understand the available break glass options
265265

266266
Alice, a system administrator, manages the Teleport cluster by checking
267-
Terrafrom scripts and values into various GitHub repos. CI/CD then picks the
267+
Terraform scripts and values into various GitHub repos. CI/CD then picks the
268268
changes and apply to the Teleport cluster.
269269

270270
A change to the Terraform script may break the Teleport cluster and the GitHub
@@ -275,7 +275,7 @@ at the organization level and does not want to allow it for security purpose.
275275

276276
Alice still has a few options to access the organization repos when the GitHub
277277
proxy is unavailable:
278-
- Alice can still logs into GitHub through a browser and make chnages there if
278+
- Alice can still logs into GitHub through a browser and make changes there if
279279
necessary.
280280
- Alice can manually sign an user certificate according to [GitHub
281281
spec](https://docs.github.com/en/enterprise-cloud@latest/organizations/managing-git-access-to-your-organizations-repositories/about-ssh-certificate-authorities#issuing-certificates).
@@ -471,7 +471,7 @@ matched against the hidden label from the `git_server` resources.
471471
#### SSH transport
472472

473473
Existing [SSH
474-
transprt](https://github.com/gravitational/teleport/blob/master/rfd/0100-proxy-ssh-grpc.md)
474+
transport](https://github.com/gravitational/teleport/blob/master/rfd/0100-proxy-ssh-grpc.md)
475475
is used for proxying Git commands.
476476

477477
No change is necessary on the client side or on the GRPC protocol to support
@@ -509,7 +509,7 @@ message GenerateGitHubUserCertRequest {
509509
bytes public_key = 2;
510510
// UserID is the GitHub user ID.
511511
string user_id = 3;
512-
// KeyId is the certficate ID, usually the Teleport username.
512+
// KeyId is the certificate ID, usually the Teleport username.
513513
string key_id = 4;
514514
// Ttl is the duration the certificate will be valid for.
515515
google.protobuf.Duration ttl = 5;
@@ -548,7 +548,7 @@ hint: use 'tsh git clone <git-clone-ssh-url>' to clone a new repository
548548
To forward SSH traffic from `git` to Teleport, the Git repo will be configured
549549
with
550550
[`core.sshCommand`](https://git-scm.com/docs/git-config#Documentation/git-config.txt-coresshCommand)
551-
set to `tsh git ssh --githb-org <my-org>`. The `core.sshCommand` makes `git` to
551+
set to `tsh git ssh --github-org <my-org>`. The `core.sshCommand` makes `git` to
552552
call this command instead of `ssh`.
553553

554554
`tsh git ssh` is a hidden command that basically does `tsh ssh
@@ -565,7 +565,7 @@ In addition, `tsh` provides two helper commands to automatically configures
565565
make a clone. Before cloning, the GitHub organization is parsed from the
566566
`<git-url>`, and a GitHub proxy server with its logins is retrieved matching
567567
the GitHub organization. If more than one GitHub logins are available, users
568-
can expliclitly specify one using `--username` when running `tsh git clone`.
568+
can explicitly specify one using `--username` when running `tsh git clone`.
569569

570570
`tsh git config` checks Teleport-related configurations in the current Git dir
571571
by running `git config --local --default "" --get core.sshCommand`.
@@ -633,7 +633,7 @@ message GitCommandAction {
633633

634634
There is no heartbeats for `git_server` with subkind `github` (yet).
635635

636-
Exising `SessionStartEvent` will be expanded to include git metadata with
636+
Existing `SessionStartEvent` will be expanded to include git metadata with
637637
`session_type` of `git`:
638638
```grpc
639639
// SessionStartGitMetadata contains additional information about git commands.
@@ -752,7 +752,7 @@ integration on each Auth service and combines all the keys.
752752
Support for Git servers should be implemented similar to how SSH is supported
753753
today for Machine ID.
754754
755-
As mentinoned earlier, since services like GitHub actions are not affected by
755+
As mentioned earlier, since services like GitHub actions are not affected by
756756
this feature (by not using Teleport), Machine ID supported can be added after
757757
the MVP.
758758

rfd/0182-multi-port-tcp-app-access.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ ports.
186186

187187
##### Embedding the port within SNI or an ALPN protocol
188188

189-
The port number could be included within TLS config on the client side, either as a special sudomain
189+
The port number could be included within TLS config on the client side, either as a special subdomain
190190
in the SNI, e.g. `app-teleport-proxy-target-port-1337.teleport.cluster.local`, or a new ALPN
191191
protocol, say `teleport-tcp@1337`.
192192

rfd/0184-agent-auto-updates.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1656,7 +1656,7 @@ $ ls -l /usr/local/bin/teleport
16561656
$ ls -l /usr/local/bin/teleport-update
16571657
/usr/local/teleport/clusterA/bin/teleport-update -> /var/lib/teleport/install/clusterA/versions/15.0.0/bin/teleport-update
16581658
$ ls -l /usr/local/lib/systemd/system/teleport-clusterA.service
1659-
/usr/local/lib/systemd/system/teleport-clutserA.service -> /var/lib/teleport/install/clusterA/versions/15.0.0/etc/systemd/teleport.service
1659+
/usr/local/lib/systemd/system/teleport-clusterA.service -> /var/lib/teleport/install/clusterA/versions/15.0.0/etc/systemd/teleport.service
16601660
```
16611661

16621662
##### update.yaml

0 commit comments

Comments
 (0)