From daa9898ebc15c8ca20433efa77f83d366d81934c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Cie=C5=9Blak?= Date: Thu, 28 Nov 2024 11:54:03 +0100 Subject: [PATCH] Add TODO comment about validating local port --- lib/vnet/app_resolver.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/vnet/app_resolver.go b/lib/vnet/app_resolver.go index fa284dce6a64c..d2fd0b3bc9d9a 100644 --- a/lib/vnet/app_resolver.go +++ b/lib/vnet/app_resolver.go @@ -325,6 +325,8 @@ func (h *tcpAppHandler) getOrInitializeLocalProxy(ctx context.Context, localPort if len(h.app.GetTCPPorts()) == 0 { localPort = 0 } + // TODO(ravicious): For multi-port apps, check if localPort is valid and surface the error in UI. + // https://github.com/gravitational/teleport/blob/master/rfd/0182-multi-port-tcp-app-access.md#incorrect-port lp, ok := h.portToLocalProxy[localPort] if ok {