From de519c76d1e64962dafb41d9fb722824e9939ce4 Mon Sep 17 00:00:00 2001 From: Gabriel Corado Date: Tue, 18 Jun 2024 15:11:44 -0300 Subject: [PATCH] Fix `TestInitDatabaseService/enabled_invalid_databases` flakiness (#43196) * test(service): assert teleport ready event instead of context deadline * test(service): remove loop variable --- lib/service/service_test.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/service/service_test.go b/lib/service/service_test.go index f02f6870c45f7..f1c4e37d43489 100644 --- a/lib/service/service_test.go +++ b/lib/service/service_test.go @@ -1793,17 +1793,16 @@ func TestInitDatabaseService(t *testing.T) { }) require.NoError(t, process.Start()) - ctx, cancel := context.WithTimeout(context.Background(), time.Second) + ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second) defer cancel() - event, err := process.WaitForEvent(ctx, ServiceExitedWithErrorEvent) if !test.expectErr { - // should timeout without the process exit event. - require.Error(t, err) - require.ErrorIs(t, err, context.DeadlineExceeded) + _, err := process.WaitForEvent(ctx, TeleportReadyEvent) + require.NoError(t, err) return } + event, err := process.WaitForEvent(ctx, ServiceExitedWithErrorEvent) require.NoError(t, err) require.NotNil(t, event) exitPayload, ok := event.Payload.(ExitEventPayload)