Add TODO comment about validating local port

ravicious · ravicious · commit f880b58be7e5 · 2024-12-03T15:21:08.000+01:00
diff --git a/lib/vnet/app_resolver.go b/lib/vnet/app_resolver.go
@@ -325,6 +325,8 @@ func (h *tcpAppHandler) getOrInitializeLocalProxy(ctx context.Context, localPort
 	if len(h.app.GetTCPPorts()) == 0 {
 		localPort = 0
 	}
+	// TODO(ravicious): For multi-port apps, check if localPort is valid and surface the error in UI.
+	// https://github.com/gravitational/teleport/blob/master/rfd/0182-multi-port-tcp-app-access.md#incorrect-port
 
 	lp, ok := h.portToLocalProxy[localPort]
 	if ok {

Original file line number	Diff line number	Diff line change
`@@ -325,6 +325,8 @@ func (h *tcpAppHandler) getOrInitializeLocalProxy(ctx context.Context, localPort`
`325`	`325`	`if len(h.app.GetTCPPorts()) == 0 {`
`326`	`326`	`localPort = 0`
`327`	`327`	`}`
	`328`	`+ // TODO(ravicious): For multi-port apps, check if localPort is valid and surface the error in UI.`
	`329`	`+ // https://github.com/gravitational/teleport/blob/master/rfd/0182-multi-port-tcp-app-access.md#incorrect-port`
`328`	`330`
`329`	`331`	`lp, ok := h.portToLocalProxy[localPort]`
`330`	`332`	`if ok {`