Skip to content

Forgetting to register the Service Provider does not trigger any error #9

Open
@clarkwinkelmann

Description

@clarkwinkelmann

If we use the package but do not register the Service Provider, it's not immediately obvious why requests do not work as expected.

Because Gravure\Api\Http\Request is resolved by the IOC as a new blank query, none of the actual parameters are passed back to it, in particular pagination and include parameters.

The package should probably throw an error if the Request object it receives did not come through the expected Container Binding from the Service Provider.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions