Skip to content

Conversation

@ArneTR
Copy link
Member

@ArneTR ArneTR commented Dec 4, 2025

This PR adds the functionality to:

  • Archive runs. Effectively hiding them from the default search view
  • Add Notes to runs
Screenshot 2025-12-04 at 2 37 08 PM Screenshot 2025-12-04 at 12 45 12 PM Screenshot 2025-12-05 at 9 32 25 AM Screenshot 2025-12-05 at 9 32 29 AM

Greptile Overview

Greptile Summary

This PR adds archive, note, and public functionality to runs, allowing users to hide runs from default search, add notes, and make runs publicly viewable.

Critical Issues Found:

  • SQL syntax error in api/api_helpers.py:255 - references undefined table alias r.public in get_comparison_details()
  • Migration schema mismatch - missing NOT NULL constraints on archived and public columns compared to structure.sql

Implementation Notes:

  • The show_archived parameter is correctly handled by FastAPI's boolean conversion ("0" → False, "1" → True)
  • The update endpoint silently succeeds when updating non-existent or unauthorized runs (affects 0 rows), which differs from the update_job pattern but may be intentional
  • Note field properly escapes content using .value and .innerText to prevent XSS

@ArneTR
Copy link
Member Author

ArneTR commented Dec 4, 2025

@greptileai

* main:
  Refactoring of unneeded double querySelector
  Bump fastapi[standard] from 0.123.2 to 0.123.5 (#1466)
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

@ArneTR
Copy link
Member Author

ArneTR commented Dec 4, 2025

@greptileail

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. docker/structure.sql, line 257-283 (link)

    logic: missing archived and note columns in runs table schema

9 files reviewed, 5 comments

Edit Code Review Agent Settings | Greptile

@ArneTR
Copy link
Member Author

ArneTR commented Dec 5, 2025

@greptileai

@ArneTR
Copy link
Member Author

ArneTR commented Dec 5, 2025

@davidkopp Love your feedback if this solves your requirement for having note functionalt and archive functionality or if you would like some tweaks / different implementation

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

@ArneTR
Copy link
Member Author

ArneTR commented Dec 5, 2025

Also added the feature to make runs public
Screenshot 2025-12-05 at 11 12 59 AM

@ArneTR
Copy link
Member Author

ArneTR commented Dec 5, 2025

@greptileai

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants