-
Notifications
You must be signed in to change notification settings - Fork 40
Archive and Note functionality added to GMT #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* main: Refactoring of unneeded double querySelector Bump fastapi[standard] from 0.123.2 to 0.123.5 (#1466)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 files reviewed, 4 comments
|
@greptileail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
docker/structure.sql, line 257-283 (link)logic: missing
archivedandnotecolumns in runs table schema
9 files reviewed, 5 comments
* main: Refactoring of unneeded double querySelector Adds variables to the submit form (#1459)
|
@davidkopp Love your feedback if this solves your requirement for having note functionalt and archive functionality or if you would like some tweaks / different implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 files reviewed, 3 comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 files reviewed, 2 comments

This PR adds the functionality to:
Greptile Overview
Greptile Summary
This PR adds archive, note, and public functionality to runs, allowing users to hide runs from default search, add notes, and make runs publicly viewable.
Critical Issues Found:
api/api_helpers.py:255- references undefined table aliasr.publicinget_comparison_details()NOT NULLconstraints onarchivedandpubliccolumns compared tostructure.sqlImplementation Notes:
show_archivedparameter is correctly handled by FastAPI's boolean conversion ("0" → False, "1" → True)update_jobpattern but may be intentional.valueand.innerTextto prevent XSS