From a08ddcc91d28afa33401a0a6e3393a40fec8f69d Mon Sep 17 00:00:00 2001
From: achour94 <berrahmaachour@gmail.com>
Date: Wed, 14 Jan 2026 15:46:50 +0100
Subject: [PATCH 1/9] Migrate twt creation

Signed-off-by: achour94 <berrahmaachour@gmail.com>
---
 ...transformer-characteristics-pane-utils.ts} |  19 +-
 ...ings-transformer-characteristics-pane.tsx} |  13 +-
 ...er-creation-characteristics-pane-utils.ts} |   4 +
 ...sformer-creation-characteristics-pane.tsx} |  18 +-
 ...gs-transformer-creation-dialog-header.tsx} |   3 +-
 ...ings-transformer-creation-dialog-tabs.tsx} |  17 +-
 ...-windings-transformer-creation-dialog.tsx} | 276 +++++++++++-------
 .../two-windings-transformer.types.ts         |  71 ++++-
 src/services/study/network-modifications.ts   |   3 +-
 9 files changed, 298 insertions(+), 126 deletions(-)
 rename src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/{two-windings-transformer-characteristics-pane-utils.js => two-windings-transformer-characteristics-pane-utils.ts} (80%)
 rename src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/{two-windings-transformer-characteristics-pane.jsx => two-windings-transformer-characteristics-pane.tsx} (90%)
 rename src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/{two-windings-transformer-creation-characteristics-pane-utils.js => two-windings-transformer-creation-characteristics-pane-utils.ts} (92%)
 rename src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/{two-windings-transformer-creation-characteristics-pane.jsx => two-windings-transformer-creation-characteristics-pane.tsx} (88%)
 rename src/components/dialogs/network-modifications/two-windings-transformer/creation/{two-windings-transformer-creation-dialog-header.jsx => two-windings-transformer-creation-dialog-header.tsx} (93%)
 rename src/components/dialogs/network-modifications/two-windings-transformer/creation/{two-windings-transformer-creation-dialog-tabs.jsx => two-windings-transformer-creation-dialog-tabs.tsx} (83%)
 rename src/components/dialogs/network-modifications/two-windings-transformer/creation/{two-windings-transformer-creation-dialog.jsx => two-windings-transformer-creation-dialog.tsx} (77%)

diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane-utils.js b/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane-utils.ts
similarity index 80%
rename from src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane-utils.js
rename to src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane-utils.ts
index 8b60a92bbe..b5d3c9a329 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane-utils.js
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane-utils.ts
@@ -8,7 +8,20 @@
 import { CHARACTERISTICS, G, B, RATED_S, RATED_U1, RATED_U2, R, X } from 'components/utils/field-constants';
 import yup from 'components/utils/yup-config';
 
-const characteristicsValidationSchema = (isModification, additionalFields) => ({
+export interface CharacteristicsValues {
+    [R]?: number | null;
+    [X]?: number | null;
+    [G]?: number | null;
+    [B]?: number | null;
+    [RATED_S]?: number | null;
+    [RATED_U1]?: number | null;
+    [RATED_U2]?: number | null;
+}
+
+type AdditionalValidationFields = Record<string, yup.AnySchema>;
+type AdditionalDataFields = Record<string, unknown>;
+
+const characteristicsValidationSchema = (isModification: boolean, additionalFields: AdditionalValidationFields) => ({
     [CHARACTERISTICS]: yup.object().shape({
         [R]: isModification
             ? yup.number().nullable().min(0, 'mustBeGreaterOrEqualToZero')
@@ -33,7 +46,7 @@ export const getCharacteristicsValidationSchema = (isModification = false, addit
     return characteristicsValidationSchema(isModification, additionalFields);
 };
 
-const characteristicsEmptyFormData = (additionalFields) => ({
+const characteristicsEmptyFormData = (additionalFields: AdditionalDataFields) => ({
     [CHARACTERISTICS]: {
         [R]: null,
         [X]: null,
@@ -51,7 +64,7 @@ export const getCharacteristicsEmptyFormData = (additionalFields = {}) => {
 };
 
 export const getCharacteristicsFormData = (
-    { r = null, x = null, g = null, b = null, ratedS = null, ratedU1 = null, ratedU2 = null },
+    { r = null, x = null, g = null, b = null, ratedS = null, ratedU1 = null, ratedU2 = null }: CharacteristicsValues,
     additionalFields = {}
 ) => {
     return {
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.jsx b/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.tsx
similarity index 90%
rename from src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.jsx
rename to src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.tsx
index 7ad2e2f2c2..9a0364d930 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.jsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.tsx
@@ -13,8 +13,19 @@ import { B, CHARACTERISTICS, G, R, RATED_S, RATED_U1, RATED_U2, X } from 'compon
 import PropertiesForm from '../../common/properties/properties-form';
 import GridSection from '../../../commons/grid-section';
 import GridItem from '../../../commons/grid-item';
+import { TwoWindingsTransformerData } from '../two-windings-transformer.types';
 
-const TwoWindingsTransformerCharacteristicsPane = ({ id = CHARACTERISTICS, twtToModify, isModification = false }) => {
+export interface TwoWindingsTransformerCharacteristicsPaneProps {
+    id?: string;
+    twtToModify?: TwoWindingsTransformerData | null;
+    isModification?: boolean;
+}
+
+const TwoWindingsTransformerCharacteristicsPane = ({
+    id = CHARACTERISTICS,
+    twtToModify,
+    isModification = false,
+}: TwoWindingsTransformerCharacteristicsPaneProps) => {
     const width = isModification ? 12 : 8;
 
     const seriesResistanceField = (
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane-utils.js b/src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane-utils.ts
similarity index 92%
rename from src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane-utils.js
rename to src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane-utils.ts
index d97ba4c2f4..5ae1688ea8 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane-utils.js
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane-utils.ts
@@ -11,6 +11,7 @@ import {
     getConnectivityWithPositionValidationSchema,
 } from '../../../../connectivity/connectivity-form-utils';
 import {
+    CharacteristicsValues,
     getCharacteristicsEmptyFormData,
     getCharacteristicsFormData,
     getCharacteristicsValidationSchema,
@@ -46,6 +47,9 @@ export const getTwoWindingsTransformerFormData = ({
     ratedU2 = null,
     connectivity1 = null,
     connectivity2 = null,
+}: CharacteristicsValues & {
+    connectivity1?: Record<string, unknown> | null;
+    connectivity2?: Record<string, unknown> | null;
 }) =>
     getCharacteristicsFormData(
         {
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane.jsx b/src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane.tsx
similarity index 88%
rename from src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane.jsx
rename to src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane.tsx
index 218dc2fc5e..efd7dbc4db 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane.jsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane.tsx
@@ -15,7 +15,9 @@ import useVoltageLevelsListInfos from '../../../../../../hooks/use-voltage-level
 import GridSection from '../../../../commons/grid-section';
 import GridItem from '../../../../commons/grid-item';
 import { TwoWindingsTransformerCreationDialogTab } from '../../two-windings-transformer-utils';
-import { LimitsPane } from '../../../../limits/limits-pane.tsx';
+import { LimitsPane } from '../../../../limits/limits-pane';
+import { UUID } from 'node:crypto';
+import { CurrentTreeNode } from 'components/graph/tree-node.type';
 
 const styles = {
     h3: {
@@ -25,13 +27,21 @@ const styles = {
     },
 };
 
+export interface TwoWindingsTransformerCreationCharacteristicsPaneProps {
+    id?: string;
+    studyUuid: UUID;
+    currentNode: CurrentTreeNode;
+    currentRootNetworkUuid: UUID;
+    tabIndex: number;
+}
+
 const TwoWindingsTransformerCreationCharacteristicsPane = ({
     id = CHARACTERISTICS,
     studyUuid,
     currentNode,
     currentRootNetworkUuid,
     tabIndex,
-}) => {
+}: TwoWindingsTransformerCreationCharacteristicsPaneProps) => {
     const voltageLevelOptions = useVoltageLevelsListInfos(studyUuid, currentNode?.id, currentRootNetworkUuid);
     const connectivity1Field = (
         <ConnectivityForm
@@ -59,7 +69,7 @@ const TwoWindingsTransformerCreationCharacteristicsPane = ({
         <>
             <Box hidden={tabIndex !== TwoWindingsTransformerCreationDialogTab.CHARACTERISTICS_TAB} p={1}>
                 <GridSection title="Connectivity" customStyle={styles.h3} />
-                <GridSection title="Side1" heading={4} size="6" />
+                <GridSection title="Side1" heading={4} size={6} />
                 <Grid container spacing={2}>
                     <Grid item container direction="column">
                         <Grid container direction="column" spacing={2}>
@@ -67,7 +77,7 @@ const TwoWindingsTransformerCreationCharacteristicsPane = ({
                         </Grid>
                     </Grid>
                 </Grid>
-                <GridSection title="Side2" heading={4} size="6" />
+                <GridSection title="Side2" heading={4} size={6} />
                 <Grid container spacing={2}>
                     <Grid item container>
                         <Grid container direction="column" spacing={2}>
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-header.jsx b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-header.tsx
similarity index 93%
rename from src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-header.jsx
rename to src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-header.tsx
index 08472eb020..c6026a425d 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-header.jsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-header.tsx
@@ -14,8 +14,7 @@ import {
     RATIO_TAP_CHANGER,
 } from 'components/utils/field-constants';
 import { filledTextField } from '../../../dialog-utils';
-import { TextInput } from '@gridsuite/commons-ui';
-import { SwitchInput } from '@gridsuite/commons-ui';
+import { TextInput, SwitchInput } from '@gridsuite/commons-ui';
 import GridItem from '../../../commons/grid-item';
 
 const TwoWindingsTransformerCreationDialogHeader = () => {
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-tabs.jsx b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-tabs.tsx
similarity index 83%
rename from src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-tabs.jsx
rename to src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-tabs.tsx
index 91c0610436..58b0c401c6 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-tabs.jsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog-tabs.tsx
@@ -5,14 +5,27 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-import { Grid, Tab, Tabs } from '@mui/material';
+import { Breakpoint, Grid, Tab, Tabs } from '@mui/material';
 import { FormattedMessage } from 'react-intl';
 import { useWatch } from 'react-hook-form';
 import { ENABLED, PHASE_TAP_CHANGER, RATIO_TAP_CHANGER } from 'components/utils/field-constants';
 import { getTabIndicatorStyle, getTabStyle } from '../../../../utils/tab-utils';
 import { TwoWindingsTransformerCreationDialogTab } from '../two-windings-transformer-utils';
+import { Dispatch, SetStateAction } from 'react';
 
-const TwoWindingsTransformerCreationDialogTabs = ({ tabIndex, tabIndexesWithError, setTabIndex, setDialogWidth }) => {
+export interface TwoWindingsTransformerCreationDialogTabsProps {
+    tabIndex: number;
+    tabIndexesWithError: number[];
+    setTabIndex: Dispatch<SetStateAction<number>>;
+    setDialogWidth: Dispatch<SetStateAction<Breakpoint>>;
+}
+
+const TwoWindingsTransformerCreationDialogTabs = ({
+    tabIndex,
+    tabIndexesWithError,
+    setTabIndex,
+    setDialogWidth,
+}: TwoWindingsTransformerCreationDialogTabsProps) => {
     const ratioTapChangerEnabledWatch = useWatch({
         name: `${RATIO_TAP_CHANGER}.${ENABLED}`,
     });
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.jsx b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
similarity index 77%
rename from src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.jsx
rename to src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
index ebe21e7821..c847fbae2a 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.jsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
@@ -12,9 +12,10 @@ import {
     FieldType,
     snackWithFallback,
     useSnackMessage,
+    EquipmentType,
 } from '@gridsuite/commons-ui';
 import { yupResolver } from '@hookform/resolvers/yup';
-import { Grid } from '@mui/material';
+import { Breakpoint, Grid } from '@mui/material';
 import {
     B,
     BUS_OR_BUSBAR_SECTION,
@@ -57,10 +58,8 @@ import {
     X,
 } from 'components/utils/field-constants';
 import { EQUIPMENT_TYPES } from 'components/utils/equipment-types';
-import PropTypes from 'prop-types';
 import { useCallback, useEffect, useState } from 'react';
-import { useForm } from 'react-hook-form';
-import { FetchStatus } from '../../../../../services/utils';
+import { Resolver, useForm } from 'react-hook-form';
 import { sanitizeString } from '../../../dialog-utils';
 import EquipmentSearchDialog from '../../../equipment-search-dialog';
 import { useFormSearchCopy } from '../../../commons/use-form-search-copy';
@@ -106,11 +105,23 @@ import {
     copyEquipmentPropertiesForCreation,
     creationPropertiesSchema,
     emptyProperties,
+    Equipment,
     getPropertiesFromModification,
     toModificationProperties,
 } from '../../common/properties/property-utils';
 import { TwoWindingsTransformerCreationDialogTab } from '../two-windings-transformer-utils';
-
+import { UUID } from 'node:crypto';
+import { CurrentTreeNode } from 'components/graph/tree-node.type';
+import { FetchStatus } from 'services/utils.type';
+import {
+    RatioTapChangerData,
+    TapChangerData,
+    TapChangerStep,
+    TwoWindingsTransformerData,
+} from '../two-windings-transformer.types';
+import { TwoWindingsTransformerCreationInfo } from 'services/network-modification-types';
+import { OperationalLimitsGroupFormSchema } from 'components/dialogs/limits/operational-limits-groups-types';
+import { CharacteristicsValues } from '../characteristics-pane/two-windings-transformer-characteristics-pane-utils';
 /**
  * Dialog to create a two windings transformer in the network
  * @param studyUuid the study we are currently working on
@@ -138,13 +149,84 @@ const formSchema = yup
         [EQUIPMENT_ID]: yup.string().required(),
         [EQUIPMENT_NAME]: yup.string().nullable(),
         ...getTwoWindingsTransformerValidationSchema(),
-        ...getLimitsValidationSchema(),
-        ...getRatioTapChangerValidationSchema(),
-        ...getPhaseTapChangerValidationSchema(),
+        [LIMITS]: yup.object().shape(getLimitsValidationSchema()).required(),
+        [RATIO_TAP_CHANGER]: yup.object().shape(getRatioTapChangerValidationSchema()).required(),
+        [PHASE_TAP_CHANGER]: yup.object().shape(getPhaseTapChangerValidationSchema()).required(),
     })
     .concat(creationPropertiesSchema)
     .required();
 
+export const PHASE_TAP = 'dephasing';
+export const RATIO_TAP = 'ratio';
+interface ConnectivityData {
+    [VOLTAGE_LEVEL]?: { [ID]?: string };
+    [BUS_OR_BUSBAR_SECTION]?: { [ID]?: string };
+    [CONNECTION_NAME]?: string;
+    [CONNECTION_DIRECTION]?: string;
+    [CONNECTION_POSITION]?: number | null;
+    [CONNECTED]?: boolean | null;
+}
+
+interface CharacteristicsFormValues extends CharacteristicsValues {
+    [CONNECTIVITY_1]?: ConnectivityData;
+    [CONNECTIVITY_2]?: ConnectivityData;
+}
+
+interface LimitsFormValues {
+    [OPERATIONAL_LIMITS_GROUPS]?: OperationalLimitsGroupFormSchema[];
+    [SELECTED_OPERATIONAL_LIMITS_GROUP_ID1]?: string | null;
+    [SELECTED_OPERATIONAL_LIMITS_GROUP_ID2]?: string | null;
+}
+
+interface RatioTapChangerFormValues {
+    [ENABLED]?: boolean;
+    [LOAD_TAP_CHANGING_CAPABILITIES]?: boolean;
+    [REGULATION_MODE]?: string | null;
+    [REGULATION_TYPE]?: string | null;
+    [REGULATION_SIDE]?: string | null;
+    [TARGET_V]?: number | null;
+    [TARGET_DEADBAND]?: number | null;
+    [LOW_TAP_POSITION]?: number | null;
+    [TAP_POSITION]?: number | null;
+    [STEPS]?: TapChangerStep[];
+    [EQUIPMENT]?: { id?: string; type?: string };
+    [VOLTAGE_LEVEL]?: { [ID]?: string };
+}
+
+interface PhaseTapChangerFormValues {
+    [ENABLED]?: boolean;
+    [REGULATION_MODE]?: string | null;
+    [REGULATION_TYPE]?: string | null;
+    [REGULATION_SIDE]?: string | null;
+    [CURRENT_LIMITER_REGULATING_VALUE]?: number | null;
+    [FLOW_SET_POINT_REGULATING_VALUE]?: number | null;
+    [TARGET_DEADBAND]?: number | null;
+    [LOW_TAP_POSITION]?: number | null;
+    [TAP_POSITION]?: number | null;
+    [STEPS]?: TapChangerStep[];
+    [EQUIPMENT]?: { id?: string; type?: string };
+    [VOLTAGE_LEVEL]?: { [ID]?: string };
+}
+
+export interface TwoWindingsTransformerCreationFormValues {
+    [EQUIPMENT_ID]: string;
+    [EQUIPMENT_NAME]?: string | null;
+    [CHARACTERISTICS]: CharacteristicsFormValues;
+    [LIMITS]: LimitsFormValues;
+    [RATIO_TAP_CHANGER]: RatioTapChangerFormValues;
+    [PHASE_TAP_CHANGER]: PhaseTapChangerFormValues;
+}
+
+export interface TwoWindingsTransformerCreationDialogProps {
+    editData?: TwoWindingsTransformerData;
+    studyUuid: UUID;
+    currentNode: CurrentTreeNode;
+    currentRootNetworkUuid: UUID;
+    isUpdate?: boolean;
+    editDataFetchStatus?: (typeof FetchStatus)[keyof typeof FetchStatus];
+    onClose: () => void;
+    onValidated?: () => void;
+}
 const TwoWindingsTransformerCreationDialog = ({
     editData,
     studyUuid,
@@ -153,22 +235,24 @@ const TwoWindingsTransformerCreationDialog = ({
     isUpdate,
     editDataFetchStatus,
     ...dialogProps
-}) => {
+}: TwoWindingsTransformerCreationDialogProps) => {
     const currentNodeUuid = currentNode?.id;
     const { snackError } = useSnackMessage();
 
-    const formMethods = useForm({
+    const formMethods = useForm<TwoWindingsTransformerCreationFormValues>({
         defaultValues: emptyFormData,
-        resolver: yupResolver(formSchema),
+        resolver: yupResolver(formSchema) as unknown as Resolver<TwoWindingsTransformerCreationFormValues>,
     });
 
     const { reset } = formMethods;
 
     const [tabIndex, setTabIndex] = useState(TwoWindingsTransformerCreationDialogTab.CHARACTERISTICS_TAB);
-    const [tabIndexesWithError, setTabIndexesWithError] = useState([]);
-    const [dialogWidth, setDialogWidth] = useState('xl');
+    const [tabIndexesWithError, setTabIndexesWithError] = useState<number[]>([]);
+    const [dialogWidth, setDialogWidth] = useState<Breakpoint>('xl');
 
-    const computeRatioTapChangerRegulationMode = (ratioTapChangerFormValues) => {
+    const computeRatioTapChangerRegulationMode = (
+        ratioTapChangerFormValues: RatioTapChangerData | null | undefined
+    ) => {
         if (ratioTapChangerFormValues?.[REGULATING]) {
             return RATIO_REGULATION_MODES.VOLTAGE_REGULATION.id;
         } else {
@@ -176,40 +260,38 @@ const TwoWindingsTransformerCreationDialog = ({
         }
     };
 
-    const getTapSideForEdit = (twt, tap) => {
-        return tap?.terminalRefConnectableId === twt.equipmentId
-            ? tap?.terminalRefConnectableVlId === twt?.voltageLevelId1
-                ? SIDE.SIDE1.id
-                : SIDE.SIDE2.id
-            : null;
+    const getTapSideForEdit = (twt: TwoWindingsTransformerData, tap: TapChangerData | null | undefined) => {
+        if (tap?.terminalRefConnectableId !== twt.equipmentId) {
+            return null;
+        }
+        return tap?.terminalRefConnectableVlId === twt?.voltageLevelId1 ? SIDE.SIDE1.id : SIDE.SIDE2.id;
     };
 
-    const getTapSideForCopy = (twt, tap) => {
-        return tap?.regulatingTerminalConnectableId === twt.id
-            ? tap?.terminalRefConnectableVlId === twt?.voltageLevelId1
-                ? SIDE.SIDE1.id
-                : SIDE.SIDE2.id
-            : null;
+    const getTapSideForCopy = (twt: TwoWindingsTransformerData, tap: TapChangerData | null | undefined) => {
+        if (tap?.regulatingTerminalConnectableId !== twt.id) {
+            return null;
+        }
+        return tap?.terminalRefConnectableVlId === twt?.voltageLevelId1 ? SIDE.SIDE1.id : SIDE.SIDE2.id;
     };
 
-    const getRegulationTypeForEdit = (twt, tap) => {
-        return tap?.terminalRefConnectableId != null
-            ? tap?.terminalRefConnectableId === twt.equipmentId
-                ? REGULATION_TYPES.LOCAL.id
-                : REGULATION_TYPES.DISTANT.id
-            : null;
+    const getRegulationTypeForEdit = (twt: TwoWindingsTransformerData, tap: TapChangerData | null | undefined) => {
+        if (tap?.terminalRefConnectableId == null) {
+            return null;
+        }
+        return tap.terminalRefConnectableId === twt.equipmentId
+            ? REGULATION_TYPES.LOCAL.id
+            : REGULATION_TYPES.DISTANT.id;
     };
 
-    const getRegulationTypeForCopy = (twt, tap) => {
-        return tap?.regulatingTerminalConnectableId != null
-            ? tap?.regulatingTerminalConnectableId === twt.id
-                ? REGULATION_TYPES.LOCAL.id
-                : REGULATION_TYPES.DISTANT.id
-            : null;
+    const getRegulationTypeForCopy = (twt: TwoWindingsTransformerData, tap: TapChangerData | null | undefined) => {
+        if (tap?.regulatingTerminalConnectableId == null) {
+            return null;
+        }
+        return tap.regulatingTerminalConnectableId === twt.id ? REGULATION_TYPES.LOCAL.id : REGULATION_TYPES.DISTANT.id;
     };
 
     const fromEditDataToFormValues = useCallback(
-        (twt) => {
+        (twt: TwoWindingsTransformerData) => {
             reset({
                 [EQUIPMENT_ID]: twt.equipmentId,
                 [EQUIPMENT_NAME]: twt.equipmentName,
@@ -224,7 +306,7 @@ const TwoWindingsTransformerCreationDialog = ({
                     ...getConnectivityFormData(
                         {
                             busbarSectionId: twt.busOrBusbarSectionId1,
-                            connectionDirection: twt.connectionDirection1,
+                            connectionDirection: twt.connectionDirection1 ?? null,
                             connectionName: twt.connectionName1,
                             connectionPosition: twt.connectionPosition1,
                             voltageLevelId: twt.voltageLevelId1,
@@ -235,7 +317,7 @@ const TwoWindingsTransformerCreationDialog = ({
                     ...getConnectivityFormData(
                         {
                             busbarSectionId: twt.busOrBusbarSectionId2,
-                            connectionDirection: twt.connectionDirection2,
+                            connectionDirection: twt.connectionDirection2 ?? null,
                             connectionName: twt.connectionName2,
                             connectionPosition: twt.connectionPosition2,
                             voltageLevelId: twt.voltageLevelId2,
@@ -270,9 +352,9 @@ const TwoWindingsTransformerCreationDialog = ({
                             : null,
                     targetDeadband: twt?.[PHASE_TAP_CHANGER]?.[TARGET_DEADBAND],
                     lowTapPosition: twt?.[PHASE_TAP_CHANGER]?.[LOW_TAP_POSITION],
-                    highTapPosition: computeHighTapPosition(twt?.[PHASE_TAP_CHANGER]?.[STEPS]),
+                    highTapPosition: computeHighTapPosition(twt?.[PHASE_TAP_CHANGER]?.[STEPS] ?? []),
                     tapPosition: twt?.[PHASE_TAP_CHANGER]?.[TAP_POSITION],
-                    steps: addSelectedFieldToRows(twt?.[PHASE_TAP_CHANGER]?.[STEPS]),
+                    steps: addSelectedFieldToRows(twt?.[PHASE_TAP_CHANGER]?.[STEPS] ?? []),
                     equipmentId: twt?.[PHASE_TAP_CHANGER]?.terminalRefConnectableId,
                     equipmentType: twt?.[PHASE_TAP_CHANGER]?.terminalRefConnectableType,
                     voltageLevelId: twt?.[PHASE_TAP_CHANGER]?.terminalRefConnectableVlId,
@@ -286,9 +368,9 @@ const TwoWindingsTransformerCreationDialog = ({
                     targetV: twt?.[RATIO_TAP_CHANGER]?.[TARGET_V],
                     targetDeadband: twt?.[RATIO_TAP_CHANGER]?.[TARGET_DEADBAND],
                     lowTapPosition: twt?.[RATIO_TAP_CHANGER]?.[LOW_TAP_POSITION],
-                    highTapPosition: computeHighTapPosition(twt?.[RATIO_TAP_CHANGER]?.[STEPS]),
+                    highTapPosition: computeHighTapPosition(twt?.[RATIO_TAP_CHANGER]?.[STEPS] ?? []),
                     tapPosition: twt?.[RATIO_TAP_CHANGER]?.[TAP_POSITION],
-                    steps: addSelectedFieldToRows(twt?.[RATIO_TAP_CHANGER]?.[STEPS]),
+                    steps: addSelectedFieldToRows(twt?.[RATIO_TAP_CHANGER]?.[STEPS] ?? []),
                     equipmentId: twt?.[RATIO_TAP_CHANGER]?.terminalRefConnectableId,
                     equipmentType: twt?.[RATIO_TAP_CHANGER]?.terminalRefConnectableType,
                     voltageLevelId: twt?.[RATIO_TAP_CHANGER]?.terminalRefConnectableVlId,
@@ -300,7 +382,7 @@ const TwoWindingsTransformerCreationDialog = ({
     );
 
     const fromSearchCopyToFormValues = useCallback(
-        (twt) => {
+        (twt: TwoWindingsTransformerData) => {
             reset(
                 {
                     [EQUIPMENT_ID]: twt.id + '(1)',
@@ -316,7 +398,7 @@ const TwoWindingsTransformerCreationDialog = ({
                         ...getConnectivityFormData(
                             {
                                 busbarSectionId: twt.busOrBusbarSectionId1,
-                                connectionDirection: twt.connectablePosition1?.connectionDirection,
+                                connectionDirection: twt.connectablePosition1?.connectionDirection ?? null,
                                 connectionName: twt.connectablePosition1?.connectionName,
                                 voltageLevelId: twt.voltageLevelId1,
                             },
@@ -325,7 +407,7 @@ const TwoWindingsTransformerCreationDialog = ({
                         ...getConnectivityFormData(
                             {
                                 busbarSectionId: twt.busOrBusbarSectionId2,
-                                connectionDirection: twt.connectablePosition2?.connectionDirection,
+                                connectionDirection: twt.connectablePosition2?.connectionDirection ?? null,
                                 connectionName: twt.connectablePosition2?.connectionName,
                                 voltageLevelId: twt.voltageLevelId2,
                             },
@@ -333,7 +415,7 @@ const TwoWindingsTransformerCreationDialog = ({
                         ),
                     }),
                     ...getAllLimitsFormData(
-                        formatCompleteCurrentLimit(twt.currentLimits),
+                        formatCompleteCurrentLimit(twt.currentLimits ?? []),
                         twt.selectedOperationalLimitsGroupId1 ?? null,
                         twt.selectedOperationalLimitsGroupId2 ?? null
                     ),
@@ -344,13 +426,13 @@ const TwoWindingsTransformerCreationDialog = ({
                         regulationType: getRegulationTypeForCopy(twt, twt?.[RATIO_TAP_CHANGER]),
                         regulationSide: getTapSideForCopy(twt, twt?.[RATIO_TAP_CHANGER]),
                         targetV: twt?.[RATIO_TAP_CHANGER]?.[TARGET_V],
-                        targetDeadband: isNaN(twt?.[RATIO_TAP_CHANGER]?.[TARGET_DEADBAND])
+                        targetDeadband: isNaN(twt?.[RATIO_TAP_CHANGER]?.[TARGET_DEADBAND] ?? NaN)
                             ? null
                             : twt?.[RATIO_TAP_CHANGER]?.[TARGET_DEADBAND],
                         lowTapPosition: twt?.[RATIO_TAP_CHANGER]?.[LOW_TAP_POSITION],
-                        highTapPosition: computeHighTapPosition(twt?.[RATIO_TAP_CHANGER]?.[STEPS]),
+                        highTapPosition: computeHighTapPosition(twt?.[RATIO_TAP_CHANGER]?.[STEPS] ?? []),
                         tapPosition: twt?.[RATIO_TAP_CHANGER]?.[TAP_POSITION],
-                        steps: addSelectedFieldToRows(twt?.[RATIO_TAP_CHANGER]?.[STEPS]),
+                        steps: addSelectedFieldToRows(twt?.[RATIO_TAP_CHANGER]?.[STEPS] ?? []),
                         equipmentId: twt?.[RATIO_TAP_CHANGER]?.regulatingTerminalConnectableId,
                         equipmentType: twt?.[RATIO_TAP_CHANGER]?.regulatingTerminalConnectableType,
                         voltageLevelId: twt?.[RATIO_TAP_CHANGER]?.terminalRefConnectableVlId,
@@ -371,18 +453,18 @@ const TwoWindingsTransformerCreationDialog = ({
                             PHASE_REGULATION_MODES.ACTIVE_POWER_CONTROL.id
                                 ? twt?.[PHASE_TAP_CHANGER]?.regulationValue
                                 : null,
-                        targetDeadband: isNaN(twt?.[PHASE_TAP_CHANGER]?.[TARGET_DEADBAND])
+                        targetDeadband: isNaN(twt?.[PHASE_TAP_CHANGER]?.[TARGET_DEADBAND] ?? NaN)
                             ? null
                             : twt?.[PHASE_TAP_CHANGER]?.[TARGET_DEADBAND],
                         lowTapPosition: twt?.[PHASE_TAP_CHANGER]?.[LOW_TAP_POSITION],
-                        highTapPosition: computeHighTapPosition(twt?.[PHASE_TAP_CHANGER]?.[STEPS]),
+                        highTapPosition: computeHighTapPosition(twt?.[PHASE_TAP_CHANGER]?.[STEPS] ?? []),
                         tapPosition: twt?.[PHASE_TAP_CHANGER]?.[TAP_POSITION],
-                        steps: addSelectedFieldToRows(twt?.[PHASE_TAP_CHANGER]?.[STEPS]),
+                        steps: addSelectedFieldToRows(twt?.[PHASE_TAP_CHANGER]?.[STEPS] ?? []),
                         voltageLevelId: twt?.[PHASE_TAP_CHANGER]?.terminalRefConnectableVlId,
                         equipmentId: twt?.[PHASE_TAP_CHANGER]?.regulatingTerminalConnectableId,
                         equipmentType: twt?.[PHASE_TAP_CHANGER]?.regulatingTerminalConnectableType,
                     }),
-                    ...copyEquipmentPropertiesForCreation(twt),
+                    ...copyEquipmentPropertiesForCreation(twt as Equipment),
                 },
                 { keepDefaultValues: true }
             );
@@ -410,18 +492,18 @@ const TwoWindingsTransformerCreationDialog = ({
         </Grid>
     );
 
-    const computeRatioTapChangerRegulating = (ratioTapChangerFormValues) => {
+    const computeRatioTapChangerRegulating = (ratioTapChangerFormValues: RatioTapChangerFormValues) => {
         return ratioTapChangerFormValues?.[REGULATION_MODE] === RATIO_REGULATION_MODES.VOLTAGE_REGULATION.id;
     };
 
-    const computePhaseTapChangerRegulating = (phaseTapChangerFormValues) => {
+    const computePhaseTapChangerRegulating = (phaseTapChangerFormValues: PhaseTapChangerFormValues) => {
         return (
             phaseTapChangerFormValues?.[REGULATION_MODE] === PHASE_REGULATION_MODES.CURRENT_LIMITER.id ||
             phaseTapChangerFormValues?.[REGULATION_MODE] === PHASE_REGULATION_MODES.ACTIVE_POWER_CONTROL.id
         );
     };
 
-    const computeRegulationModeValue = (phaseTapChangerFormValues) => {
+    const computeRegulationModeValue = (phaseTapChangerFormValues: PhaseTapChangerFormValues) => {
         if (phaseTapChangerFormValues?.[REGULATION_MODE] === PHASE_REGULATION_MODES.OFF.id) {
             return null;
         }
@@ -429,18 +511,18 @@ const TwoWindingsTransformerCreationDialog = ({
         return phaseTapChangerFormValues?.[REGULATION_MODE];
     };
 
-    const computePhaseTapChangerRegulationValue = (phaseTapChangerFormValues) => {
+    const computePhaseTapChangerRegulationValue = (phaseTapChangerFormValues: PhaseTapChangerFormValues) => {
         switch (phaseTapChangerFormValues?.[REGULATION_MODE]) {
             case PHASE_REGULATION_MODES.ACTIVE_POWER_CONTROL.id:
-                return phaseTapChangerFormValues?.[FLOW_SET_POINT_REGULATING_VALUE];
+                return phaseTapChangerFormValues?.[FLOW_SET_POINT_REGULATING_VALUE] ?? undefined;
             case PHASE_REGULATION_MODES.CURRENT_LIMITER.id:
-                return phaseTapChangerFormValues?.[CURRENT_LIMITER_REGULATING_VALUE];
+                return phaseTapChangerFormValues?.[CURRENT_LIMITER_REGULATING_VALUE] ?? undefined;
             default:
                 return undefined;
         }
     };
 
-    const computeRegulatingTerminalType = (tapChangerValue) => {
+    const computeRegulatingTerminalType = (tapChangerValue: RatioTapChangerFormValues | PhaseTapChangerFormValues) => {
         if (tapChangerValue?.[EQUIPMENT]?.type) {
             return tapChangerValue?.[EQUIPMENT]?.type;
         }
@@ -452,7 +534,11 @@ const TwoWindingsTransformerCreationDialog = ({
         return undefined;
     };
 
-    const computeTapTerminalVlId = (tapChangerValue, connectivity1, connectivity2) => {
+    const computeTapTerminalVlId = (
+        tapChangerValue: TapChangerData | RatioTapChangerFormValues | PhaseTapChangerFormValues,
+        connectivity1: ConnectivityData | undefined,
+        connectivity2: ConnectivityData | undefined
+    ) => {
         if (tapChangerValue?.[REGULATION_TYPE] === REGULATION_TYPES.LOCAL.id) {
             if (tapChangerValue?.[REGULATION_SIDE] === SIDE.SIDE1.id) {
                 return connectivity1?.[VOLTAGE_LEVEL]?.[ID];
@@ -464,7 +550,10 @@ const TwoWindingsTransformerCreationDialog = ({
         }
     };
 
-    const computeRegulatingTerminalId = (tapChangerValue, currentTwtId) => {
+    const computeRegulatingTerminalId = (
+        tapChangerValue: TapChangerData | RatioTapChangerFormValues | PhaseTapChangerFormValues,
+        currentTwtId: string
+    ) => {
         if (tapChangerValue?.[REGULATION_TYPE] === REGULATION_TYPES.LOCAL.id) {
             return currentTwtId;
         } else {
@@ -473,7 +562,7 @@ const TwoWindingsTransformerCreationDialog = ({
     };
 
     const onSubmit = useCallback(
-        (twt) => {
+        (twt: TwoWindingsTransformerCreationFormValues) => {
             const enablePhaseTapChanger = twt[PHASE_TAP_CHANGER]?.[ENABLED];
             const enableRatioTapChanger = twt[RATIO_TAP_CHANGER]?.[ENABLED];
             const characteristics = twt[CHARACTERISTICS];
@@ -487,32 +576,28 @@ const TwoWindingsTransformerCreationDialog = ({
                 const ratioTapChangerFormValues = twt[RATIO_TAP_CHANGER];
                 const hasLoadTapCapabilities = ratioTapChangerFormValues[LOAD_TAP_CHANGING_CAPABILITIES];
 
-                const getRegulatingValue = (computeFunc, ...args) => {
-                    return hasLoadTapCapabilities ? computeFunc(...args) : null;
-                };
-
-                const getValueOrDefault = (key) => {
+                const getValueOrDefault = <K extends keyof RatioTapChangerFormValues>(
+                    key: K
+                ): RatioTapChangerFormValues[K] | null => {
                     return hasLoadTapCapabilities ? ratioTapChangerFormValues[key] : null;
                 };
 
                 ratioTap = {
                     ...ratioTapChangerFormValues,
                     isRegulating: computeRatioTapChangerRegulating(ratioTapChangerFormValues),
-                    terminalRefConnectableId: getRegulatingValue(
-                        computeRegulatingTerminalId,
-                        ratioTapChangerFormValues,
-                        twt[EQUIPMENT_ID]
-                    ),
-                    terminalRefConnectableType: getRegulatingValue(
-                        computeRegulatingTerminalType,
-                        ratioTapChangerFormValues
-                    ),
-                    terminalRefConnectableVlId: getRegulatingValue(
-                        computeTapTerminalVlId,
-                        ratioTapChangerFormValues,
-                        characteristics[CONNECTIVITY_1],
-                        characteristics[CONNECTIVITY_2]
-                    ),
+                    terminalRefConnectableId: hasLoadTapCapabilities
+                        ? computeRegulatingTerminalId(ratioTapChangerFormValues, twt[EQUIPMENT_ID])
+                        : null,
+                    terminalRefConnectableType: hasLoadTapCapabilities
+                        ? computeRegulatingTerminalType(ratioTapChangerFormValues)
+                        : null,
+                    terminalRefConnectableVlId: hasLoadTapCapabilities
+                        ? computeTapTerminalVlId(
+                              ratioTapChangerFormValues,
+                              characteristics[CONNECTIVITY_1],
+                              characteristics[CONNECTIVITY_2]
+                          )
+                        : null,
                     targetV: getValueOrDefault(TARGET_V),
                     targetDeadband: getValueOrDefault(TARGET_DEADBAND),
                     regulationType: getValueOrDefault(REGULATION_TYPE),
@@ -549,7 +634,7 @@ const TwoWindingsTransformerCreationDialog = ({
                 ratedS: characteristics[RATED_S] ?? '',
                 ratedU1: characteristics[RATED_U1],
                 ratedU2: characteristics[RATED_U2],
-                limitsGroups: sanitizeLimitsGroups(limits[OPERATIONAL_LIMITS_GROUPS]),
+                limitsGroups: sanitizeLimitsGroups(limits[OPERATIONAL_LIMITS_GROUPS] ?? []),
                 selectedLimitsGroup1: limits[SELECTED_OPERATIONAL_LIMITS_GROUP_ID1],
                 selectedLimitsGroup2: limits[SELECTED_OPERATIONAL_LIMITS_GROUP_ID2],
                 voltageLevelId1: characteristics[CONNECTIVITY_1]?.[VOLTAGE_LEVEL]?.[ID],
@@ -570,8 +655,8 @@ const TwoWindingsTransformerCreationDialog = ({
                 connectionPosition2: characteristics[CONNECTIVITY_2]?.[CONNECTION_POSITION] ?? null,
                 connected1: characteristics[CONNECTIVITY_1]?.[CONNECTED] ?? null,
                 connected2: characteristics[CONNECTIVITY_2]?.[CONNECTED] ?? null,
-                properties: toModificationProperties(twt),
-            }).catch((error) => {
+                properties: toModificationProperties(twt as unknown as Record<string, unknown>),
+            } as TwoWindingsTransformerCreationInfo).catch((error) => {
                 snackWithFallback(snackError, error, { headerId: 'TwoWindingsTransformerCreationError' });
             });
         },
@@ -579,7 +664,7 @@ const TwoWindingsTransformerCreationDialog = ({
     );
 
     const onValidationError = useCallback(
-        (errors) => {
+        (errors: Record<string, unknown>) => {
             const tabsInError = [];
             if (errors?.[PHASE_TAP_CHANGER] !== undefined) {
                 tabsInError.push(TwoWindingsTransformerCreationDialogTab.PHASE_TAP_TAB);
@@ -646,7 +731,7 @@ const TwoWindingsTransformerCreationDialog = ({
                 <EquipmentSearchDialog
                     open={searchCopy.isDialogSearchOpen}
                     onClose={searchCopy.handleCloseSearchDialog}
-                    equipmentType={EQUIPMENT_TYPES.TWO_WINDINGS_TRANSFORMER}
+                    equipmentType={EquipmentType.TWO_WINDINGS_TRANSFORMER}
                     onSelectionChange={searchCopy.handleSelectionChange}
                     currentNodeUuid={currentNodeUuid}
                     currentRootNetworkUuid={currentRootNetworkUuid}
@@ -656,13 +741,4 @@ const TwoWindingsTransformerCreationDialog = ({
     );
 };
 
-TwoWindingsTransformerCreationDialog.propTypes = {
-    editData: PropTypes.object,
-    studyUuid: PropTypes.string,
-    currentNode: PropTypes.object,
-    currentRootNetworkUuid: PropTypes.string,
-    isUpdate: PropTypes.bool,
-    editDataFetchStatus: PropTypes.string,
-};
-
 export default TwoWindingsTransformerCreationDialog;
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts b/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
index a9166c2486..129c8b64bc 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
@@ -4,18 +4,26 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
-
+import { CommonBranchEquipmentInfos } from 'components/tooltips/equipment-popover-type';
 import { Identifiable } from '@gridsuite/commons-ui';
 import { CurrentTreeNode } from 'components/graph/tree-node.type';
 import {
+    CURRENT_LIMITER_REGULATING_VALUE,
     ENABLED,
+    EQUIPMENT,
+    FLOW_SET_POINT_REGULATING_VALUE,
     HIGH_TAP_POSITION,
+    LOAD_TAP_CHANGING_CAPABILITIES,
     LOW_TAP_POSITION,
+    PHASE_TAP_CHANGER,
+    RATIO_TAP_CHANGER,
     REGULATING,
     REGULATING_TERMINAL_CONNECTABLE_ID,
     REGULATING_TERMINAL_CONNECTABLE_TYPE,
     REGULATING_TERMINAL_VOLTAGE_LEVEL_ID,
     REGULATION_MODE,
+    REGULATION_SIDE,
+    REGULATION_TYPE,
     REGULATION_VALUE,
     SELECTED,
     STEPS,
@@ -28,8 +36,14 @@ import {
     STEPS_TAP,
     TAP_POSITION,
     TARGET_DEADBAND,
+    TARGET_V,
+    VOLTAGE_LEVEL,
 } from 'components/utils/field-constants';
 import { UUID } from 'node:crypto';
+import { ConnectablePositionFormInfos } from 'components/dialogs/connectivity/connectivity.type';
+import { CurrentLimitsData } from 'services/study/network-map.type';
+import { OperationalLimitsGroupFormSchema } from 'components/dialogs/limits/operational-limits-groups-types';
+import { Property } from '../common/properties/property-utils';
 
 export const PHASE_TAP = 'dephasing';
 export const RATIO_TAP = 'ratio';
@@ -58,17 +72,25 @@ export interface TapChangerData {
     [STEPS]?: TapChangerStep[];
     [TAP_POSITION]?: number;
     [TARGET_DEADBAND]?: number;
-}
-
-export interface RatioTapChangerData extends TapChangerData {
-    hasLoadTapChangingCapabilities?: boolean;
+    terminalRefConnectableId?: string;
+    terminalRefConnectableVlId?: string;
+    terminalRefConnectableType?: string;
+    [REGULATION_MODE]?: string;
+    [REGULATION_VALUE]?: number;
+    [REGULATION_TYPE]?: string;
+    [REGULATION_SIDE]?: string;
+    [LOAD_TAP_CHANGING_CAPABILITIES]?: boolean;
     loadTapChangingCapabilities?: boolean;
-    targetV?: number | null;
+    [TARGET_V]?: number | null;
+    [EQUIPMENT]?: Record<string, unknown>;
+    [VOLTAGE_LEVEL]?: Identifiable | null;
 }
 
+export interface RatioTapChangerData extends TapChangerData {}
+
 export interface PhaseTapChangerData extends TapChangerData {
-    [REGULATION_MODE]?: string;
-    [REGULATION_VALUE]?: number;
+    [FLOW_SET_POINT_REGULATING_VALUE]?: number;
+    [CURRENT_LIMITER_REGULATING_VALUE]?: number;
 }
 
 export interface TapChangerPaneProps {
@@ -85,12 +107,35 @@ export interface TapChangerPaneProps {
 export type PhaseTapChangerPaneProps = TapChangerPaneProps;
 export type RatioTapChangerPaneProps = TapChangerPaneProps;
 
-export interface TwoWindingsTransformerData {
-    id?: string;
-    name?: string;
+export interface TwoWindingsTransformerData extends CommonBranchEquipmentInfos {
+    uuid?: UUID;
+    equipmentId?: string;
+    equipmentName?: string;
+    g?: number;
+    b?: number;
+    ratedU1?: number;
+    ratedU2?: number;
+    ratedS?: number;
+    busOrBusbarSectionId1?: string;
+    busOrBusbarSectionId2?: string;
+    connectionDirection1?: string;
+    connectionDirection2?: string;
+    connectablePosition1?: ConnectablePositionFormInfos;
+    connectablePosition2?: ConnectablePositionFormInfos;
+    connectionName1?: string;
+    connectionName2?: string;
+    connectionPosition1?: number;
+    connectionPosition2?: number;
+    currentLimits?: CurrentLimitsData[] | null;
     voltageLevelId1?: string;
     voltageLevelId2?: string;
-    ratioTapChanger?: RatioTapChangerData;
-    phaseTapChanger?: PhaseTapChangerData;
+    connected1?: boolean;
+    connected2?: boolean;
+    operationalLimitsGroups?: OperationalLimitsGroupFormSchema[];
+    selectedOperationalLimitsGroupId1?: string;
+    selectedOperationalLimitsGroupId2?: string;
+    [RATIO_TAP_CHANGER]?: RatioTapChangerData;
+    [PHASE_TAP_CHANGER]?: PhaseTapChangerData;
+    properties?: Property[] | null;
     [key: string]: unknown;
 }
diff --git a/src/services/study/network-modifications.ts b/src/services/study/network-modifications.ts
index 85d99d6627..acfbf8e583 100644
--- a/src/services/study/network-modifications.ts
+++ b/src/services/study/network-modifications.ts
@@ -961,7 +961,8 @@ export function createTwoWindingsTransformer({
     connected1,
     connected2,
     properties,
-}: TwoWindingsTransformerCreationInfo) {
+}: Partial<TwoWindingsTransformerCreationInfo> &
+    Pick<TwoWindingsTransformerCreationInfo, 'modificationUuid' | 'nodeUuid'>) {
     let createTwoWindingsTransformerUrl = getNetworkModificationUrl(studyUuid, nodeUuid);
 
     if (isUpdate) {

From 9240bcddf3b61fb0fbfd72204b3723a532f309ab Mon Sep 17 00:00:00 2001
From: achour94 <berrahmaachour@gmail.com>
Date: Wed, 14 Jan 2026 16:16:26 +0100
Subject: [PATCH 2/9] Fix Sonar issues

Signed-off-by: achour94 <berrahmaachour@gmail.com>
---
 .../creation/two-windings-transformer-creation-dialog.tsx   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
index c847fbae2a..3182d2f05e 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
@@ -385,7 +385,7 @@ const TwoWindingsTransformerCreationDialog = ({
         (twt: TwoWindingsTransformerData) => {
             reset(
                 {
-                    [EQUIPMENT_ID]: twt.id + '(1)',
+                    [EQUIPMENT_ID]: String(twt.id) + '(1)',
                     [EQUIPMENT_NAME]: twt.name ?? '',
                     ...getTwoWindingsTransformerFormData({
                         r: twt.r,
@@ -426,7 +426,7 @@ const TwoWindingsTransformerCreationDialog = ({
                         regulationType: getRegulationTypeForCopy(twt, twt?.[RATIO_TAP_CHANGER]),
                         regulationSide: getTapSideForCopy(twt, twt?.[RATIO_TAP_CHANGER]),
                         targetV: twt?.[RATIO_TAP_CHANGER]?.[TARGET_V],
-                        targetDeadband: isNaN(twt?.[RATIO_TAP_CHANGER]?.[TARGET_DEADBAND] ?? NaN)
+                        targetDeadband: Number.isNaN(twt?.[RATIO_TAP_CHANGER]?.[TARGET_DEADBAND] ?? NaN)
                             ? null
                             : twt?.[RATIO_TAP_CHANGER]?.[TARGET_DEADBAND],
                         lowTapPosition: twt?.[RATIO_TAP_CHANGER]?.[LOW_TAP_POSITION],
@@ -453,7 +453,7 @@ const TwoWindingsTransformerCreationDialog = ({
                             PHASE_REGULATION_MODES.ACTIVE_POWER_CONTROL.id
                                 ? twt?.[PHASE_TAP_CHANGER]?.regulationValue
                                 : null,
-                        targetDeadband: isNaN(twt?.[PHASE_TAP_CHANGER]?.[TARGET_DEADBAND] ?? NaN)
+                        targetDeadband: Number.isNaN(twt?.[PHASE_TAP_CHANGER]?.[TARGET_DEADBAND] ?? NaN)
                             ? null
                             : twt?.[PHASE_TAP_CHANGER]?.[TARGET_DEADBAND],
                         lowTapPosition: twt?.[PHASE_TAP_CHANGER]?.[LOW_TAP_POSITION],

From ccf982d59e877cba6b06fb66f117f79bc67fec82 Mon Sep 17 00:00:00 2001
From: achour94 <berrahmaachour@gmail.com>
Date: Wed, 14 Jan 2026 16:25:10 +0100
Subject: [PATCH 3/9] Fix Sonar issues

Signed-off-by: achour94 <berrahmaachour@gmail.com>
---
 .../creation/two-windings-transformer-creation-dialog.tsx   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
index 3182d2f05e..07316e2c8e 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
@@ -385,7 +385,7 @@ const TwoWindingsTransformerCreationDialog = ({
         (twt: TwoWindingsTransformerData) => {
             reset(
                 {
-                    [EQUIPMENT_ID]: String(twt.id) + '(1)',
+                    [EQUIPMENT_ID]: twt.id + '(1)',
                     [EQUIPMENT_NAME]: twt.name ?? '',
                     ...getTwoWindingsTransformerFormData({
                         r: twt.r,
@@ -426,7 +426,7 @@ const TwoWindingsTransformerCreationDialog = ({
                         regulationType: getRegulationTypeForCopy(twt, twt?.[RATIO_TAP_CHANGER]),
                         regulationSide: getTapSideForCopy(twt, twt?.[RATIO_TAP_CHANGER]),
                         targetV: twt?.[RATIO_TAP_CHANGER]?.[TARGET_V],
-                        targetDeadband: Number.isNaN(twt?.[RATIO_TAP_CHANGER]?.[TARGET_DEADBAND] ?? NaN)
+                        targetDeadband: Number.isNaN(twt?.[RATIO_TAP_CHANGER]?.[TARGET_DEADBAND] ?? Number.NaN)
                             ? null
                             : twt?.[RATIO_TAP_CHANGER]?.[TARGET_DEADBAND],
                         lowTapPosition: twt?.[RATIO_TAP_CHANGER]?.[LOW_TAP_POSITION],
@@ -453,7 +453,7 @@ const TwoWindingsTransformerCreationDialog = ({
                             PHASE_REGULATION_MODES.ACTIVE_POWER_CONTROL.id
                                 ? twt?.[PHASE_TAP_CHANGER]?.regulationValue
                                 : null,
-                        targetDeadband: Number.isNaN(twt?.[PHASE_TAP_CHANGER]?.[TARGET_DEADBAND] ?? NaN)
+                        targetDeadband: Number.isNaN(twt?.[PHASE_TAP_CHANGER]?.[TARGET_DEADBAND] ?? Number.NaN)
                             ? null
                             : twt?.[PHASE_TAP_CHANGER]?.[TARGET_DEADBAND],
                         lowTapPosition: twt?.[PHASE_TAP_CHANGER]?.[LOW_TAP_POSITION],

From 8bc0f36031991a7d1ce9c3b8c39b1b3561778c69 Mon Sep 17 00:00:00 2001
From: achour94 <berrahmaachour@gmail.com>
Date: Fri, 16 Jan 2026 09:35:12 +0100
Subject: [PATCH 4/9] migrate modification dialog

Signed-off-by: achour94 <berrahmaachour@gmail.com>
---
 .../dialogs/limits/limits-pane-utils.ts       |   2 +-
 ...o-windings-transformer-creation-dialog.tsx |  96 +---
 ...ransformer-modification-dialog-header.tsx} |  12 +-
 ...-transformer-modification-dialog-tabs.tsx} |  12 +-
 ...dings-transformer-modification-dialog.tsx} | 459 +++++++++++-------
 .../phase-tap-changer-pane-steps.tsx          |   4 +-
 .../two-windings-transformer.types.ts         |  91 +++-
 src/components/utils/utils.ts                 |  10 +-
 src/services/network-modification-types.ts    |  26 +-
 9 files changed, 430 insertions(+), 282 deletions(-)
 rename src/components/dialogs/network-modifications/two-windings-transformer/modification/{two-windings-transformer-modification-dialog-header.jsx => two-windings-transformer-modification-dialog-header.tsx} (84%)
 rename src/components/dialogs/network-modifications/two-windings-transformer/modification/{two-windings-transformer-modification-dialog-tabs.jsx => two-windings-transformer-modification-dialog-tabs.tsx} (90%)
 rename src/components/dialogs/network-modifications/two-windings-transformer/modification/{two-windings-transformer-modification-dialog.jsx => two-windings-transformer-modification-dialog.tsx} (66%)

diff --git a/src/components/dialogs/limits/limits-pane-utils.ts b/src/components/dialogs/limits/limits-pane-utils.ts
index b550923a1e..883fa449be 100644
--- a/src/components/dialogs/limits/limits-pane-utils.ts
+++ b/src/components/dialogs/limits/limits-pane-utils.ts
@@ -163,7 +163,7 @@ export const getLimitsEmptyFormData = (isModification = true, id = LIMITS) => {
 };
 
 export const formatOpLimitGroupsToFormInfos = (
-    limitGroups: OperationalLimitsGroup[]
+    limitGroups?: OperationalLimitsGroup[]
 ): OperationalLimitsGroupFormSchema[] => {
     if (!limitGroups) {
         return [];
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
index 07316e2c8e..0413f8f892 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
@@ -114,14 +114,14 @@ import { UUID } from 'node:crypto';
 import { CurrentTreeNode } from 'components/graph/tree-node.type';
 import { FetchStatus } from 'services/utils.type';
 import {
+    CharacteristicsFormData,
+    ConnectivityFormData,
+    LimitsFormData,
     RatioTapChangerData,
     TapChangerData,
-    TapChangerStep,
     TwoWindingsTransformerData,
 } from '../two-windings-transformer.types';
 import { TwoWindingsTransformerCreationInfo } from 'services/network-modification-types';
-import { OperationalLimitsGroupFormSchema } from 'components/dialogs/limits/operational-limits-groups-types';
-import { CharacteristicsValues } from '../characteristics-pane/two-windings-transformer-characteristics-pane-utils';
 /**
  * Dialog to create a two windings transformer in the network
  * @param studyUuid the study we are currently working on
@@ -149,72 +149,23 @@ const formSchema = yup
         [EQUIPMENT_ID]: yup.string().required(),
         [EQUIPMENT_NAME]: yup.string().nullable(),
         ...getTwoWindingsTransformerValidationSchema(),
-        [LIMITS]: yup.object().shape(getLimitsValidationSchema()).required(),
-        [RATIO_TAP_CHANGER]: yup.object().shape(getRatioTapChangerValidationSchema()).required(),
-        [PHASE_TAP_CHANGER]: yup.object().shape(getPhaseTapChangerValidationSchema()).required(),
+        ...getLimitsValidationSchema(),
+        ...getRatioTapChangerValidationSchema(),
+        ...getPhaseTapChangerValidationSchema(),
     })
     .concat(creationPropertiesSchema)
     .required();
 
 export const PHASE_TAP = 'dephasing';
 export const RATIO_TAP = 'ratio';
-interface ConnectivityData {
-    [VOLTAGE_LEVEL]?: { [ID]?: string };
-    [BUS_OR_BUSBAR_SECTION]?: { [ID]?: string };
-    [CONNECTION_NAME]?: string;
-    [CONNECTION_DIRECTION]?: string;
-    [CONNECTION_POSITION]?: number | null;
-    [CONNECTED]?: boolean | null;
-}
-
-interface CharacteristicsFormValues extends CharacteristicsValues {
-    [CONNECTIVITY_1]?: ConnectivityData;
-    [CONNECTIVITY_2]?: ConnectivityData;
-}
-
-interface LimitsFormValues {
-    [OPERATIONAL_LIMITS_GROUPS]?: OperationalLimitsGroupFormSchema[];
-    [SELECTED_OPERATIONAL_LIMITS_GROUP_ID1]?: string | null;
-    [SELECTED_OPERATIONAL_LIMITS_GROUP_ID2]?: string | null;
-}
-
-interface RatioTapChangerFormValues {
-    [ENABLED]?: boolean;
-    [LOAD_TAP_CHANGING_CAPABILITIES]?: boolean;
-    [REGULATION_MODE]?: string | null;
-    [REGULATION_TYPE]?: string | null;
-    [REGULATION_SIDE]?: string | null;
-    [TARGET_V]?: number | null;
-    [TARGET_DEADBAND]?: number | null;
-    [LOW_TAP_POSITION]?: number | null;
-    [TAP_POSITION]?: number | null;
-    [STEPS]?: TapChangerStep[];
-    [EQUIPMENT]?: { id?: string; type?: string };
-    [VOLTAGE_LEVEL]?: { [ID]?: string };
-}
-
-interface PhaseTapChangerFormValues {
-    [ENABLED]?: boolean;
-    [REGULATION_MODE]?: string | null;
-    [REGULATION_TYPE]?: string | null;
-    [REGULATION_SIDE]?: string | null;
-    [CURRENT_LIMITER_REGULATING_VALUE]?: number | null;
-    [FLOW_SET_POINT_REGULATING_VALUE]?: number | null;
-    [TARGET_DEADBAND]?: number | null;
-    [LOW_TAP_POSITION]?: number | null;
-    [TAP_POSITION]?: number | null;
-    [STEPS]?: TapChangerStep[];
-    [EQUIPMENT]?: { id?: string; type?: string };
-    [VOLTAGE_LEVEL]?: { [ID]?: string };
-}
 
 export interface TwoWindingsTransformerCreationFormValues {
     [EQUIPMENT_ID]: string;
     [EQUIPMENT_NAME]?: string | null;
-    [CHARACTERISTICS]: CharacteristicsFormValues;
-    [LIMITS]: LimitsFormValues;
-    [RATIO_TAP_CHANGER]: RatioTapChangerFormValues;
-    [PHASE_TAP_CHANGER]: PhaseTapChangerFormValues;
+    [CHARACTERISTICS]: CharacteristicsFormData;
+    [LIMITS]: LimitsFormData;
+    [RATIO_TAP_CHANGER]: TapChangerData;
+    [PHASE_TAP_CHANGER]: TapChangerData;
 }
 
 export interface TwoWindingsTransformerCreationDialogProps {
@@ -492,18 +443,18 @@ const TwoWindingsTransformerCreationDialog = ({
         </Grid>
     );
 
-    const computeRatioTapChangerRegulating = (ratioTapChangerFormValues: RatioTapChangerFormValues) => {
+    const computeRatioTapChangerRegulating = (ratioTapChangerFormValues: TapChangerData) => {
         return ratioTapChangerFormValues?.[REGULATION_MODE] === RATIO_REGULATION_MODES.VOLTAGE_REGULATION.id;
     };
 
-    const computePhaseTapChangerRegulating = (phaseTapChangerFormValues: PhaseTapChangerFormValues) => {
+    const computePhaseTapChangerRegulating = (phaseTapChangerFormValues: TapChangerData) => {
         return (
             phaseTapChangerFormValues?.[REGULATION_MODE] === PHASE_REGULATION_MODES.CURRENT_LIMITER.id ||
             phaseTapChangerFormValues?.[REGULATION_MODE] === PHASE_REGULATION_MODES.ACTIVE_POWER_CONTROL.id
         );
     };
 
-    const computeRegulationModeValue = (phaseTapChangerFormValues: PhaseTapChangerFormValues) => {
+    const computeRegulationModeValue = (phaseTapChangerFormValues: TapChangerData) => {
         if (phaseTapChangerFormValues?.[REGULATION_MODE] === PHASE_REGULATION_MODES.OFF.id) {
             return null;
         }
@@ -511,7 +462,7 @@ const TwoWindingsTransformerCreationDialog = ({
         return phaseTapChangerFormValues?.[REGULATION_MODE];
     };
 
-    const computePhaseTapChangerRegulationValue = (phaseTapChangerFormValues: PhaseTapChangerFormValues) => {
+    const computePhaseTapChangerRegulationValue = (phaseTapChangerFormValues: TapChangerData) => {
         switch (phaseTapChangerFormValues?.[REGULATION_MODE]) {
             case PHASE_REGULATION_MODES.ACTIVE_POWER_CONTROL.id:
                 return phaseTapChangerFormValues?.[FLOW_SET_POINT_REGULATING_VALUE] ?? undefined;
@@ -522,7 +473,7 @@ const TwoWindingsTransformerCreationDialog = ({
         }
     };
 
-    const computeRegulatingTerminalType = (tapChangerValue: RatioTapChangerFormValues | PhaseTapChangerFormValues) => {
+    const computeRegulatingTerminalType = (tapChangerValue: TapChangerData) => {
         if (tapChangerValue?.[EQUIPMENT]?.type) {
             return tapChangerValue?.[EQUIPMENT]?.type;
         }
@@ -535,9 +486,9 @@ const TwoWindingsTransformerCreationDialog = ({
     };
 
     const computeTapTerminalVlId = (
-        tapChangerValue: TapChangerData | RatioTapChangerFormValues | PhaseTapChangerFormValues,
-        connectivity1: ConnectivityData | undefined,
-        connectivity2: ConnectivityData | undefined
+        tapChangerValue: TapChangerData,
+        connectivity1: ConnectivityFormData | undefined,
+        connectivity2: ConnectivityFormData | undefined
     ) => {
         if (tapChangerValue?.[REGULATION_TYPE] === REGULATION_TYPES.LOCAL.id) {
             if (tapChangerValue?.[REGULATION_SIDE] === SIDE.SIDE1.id) {
@@ -550,10 +501,7 @@ const TwoWindingsTransformerCreationDialog = ({
         }
     };
 
-    const computeRegulatingTerminalId = (
-        tapChangerValue: TapChangerData | RatioTapChangerFormValues | PhaseTapChangerFormValues,
-        currentTwtId: string
-    ) => {
+    const computeRegulatingTerminalId = (tapChangerValue: TapChangerData, currentTwtId: string) => {
         if (tapChangerValue?.[REGULATION_TYPE] === REGULATION_TYPES.LOCAL.id) {
             return currentTwtId;
         } else {
@@ -576,9 +524,7 @@ const TwoWindingsTransformerCreationDialog = ({
                 const ratioTapChangerFormValues = twt[RATIO_TAP_CHANGER];
                 const hasLoadTapCapabilities = ratioTapChangerFormValues[LOAD_TAP_CHANGING_CAPABILITIES];
 
-                const getValueOrDefault = <K extends keyof RatioTapChangerFormValues>(
-                    key: K
-                ): RatioTapChangerFormValues[K] | null => {
+                const getValueOrDefault = <K extends keyof TapChangerData>(key: K): TapChangerData[K] | null => {
                     return hasLoadTapCapabilities ? ratioTapChangerFormValues[key] : null;
                 };
 
@@ -702,7 +648,7 @@ const TwoWindingsTransformerCreationDialog = ({
     });
 
     return (
-        <CustomFormProvider validationSchema={formSchema} {...formMethods}>
+        <CustomFormProvider validationSchema={formSchema as any} {...formMethods}>
             <ModificationDialog
                 fullWidth
                 onClear={clear}
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog-header.jsx b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog-header.tsx
similarity index 84%
rename from src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog-header.jsx
rename to src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog-header.tsx
index 4d01e99e55..d148e29dc9 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog-header.jsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog-header.tsx
@@ -11,7 +11,15 @@ import { filledTextField } from '../../../dialog-utils';
 import { SwitchInput, TextInput } from '@gridsuite/commons-ui';
 import GridItem from '../../../commons/grid-item';
 
-const TwoWindingsTransformerModificationDialogHeader = ({ equipmentToModify, equipmentId }) => {
+interface TwoWindingsTransformerModificationDialogHeaderProps {
+    equipmentToModify?: string;
+    equipmentId: string | null;
+}
+
+const TwoWindingsTransformerModificationDialogHeader = ({
+    equipmentToModify,
+    equipmentId,
+}: TwoWindingsTransformerModificationDialogHeaderProps) => {
     const twoWindingsTransformerIdField = (
         <TextField
             size="small"
@@ -31,7 +39,7 @@ const TwoWindingsTransformerModificationDialogHeader = ({ equipmentToModify, equ
             name={EQUIPMENT_NAME}
             label="Name"
             formProps={filledTextField}
-            previousValue={equipmentToModify?.name}
+            previousValue={equipmentToModify}
             clearable
         />
     );
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog-tabs.jsx b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog-tabs.tsx
similarity index 90%
rename from src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog-tabs.jsx
rename to src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog-tabs.tsx
index 14657e3f21..38995fa559 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog-tabs.jsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog-tabs.tsx
@@ -12,7 +12,17 @@ import { ENABLED, PHASE_TAP_CHANGER, RATIO_TAP_CHANGER } from 'components/utils/
 import { getTabIndicatorStyle, getTabStyle } from '../../../../utils/tab-utils';
 import { TwoWindingsTransformerModificationDialogTab } from '../two-windings-transformer-utils';
 
-const TwoWindingsTransformerModificationDialogTabs = ({ tabIndex, tabIndexesWithError, setTabIndex }) => {
+interface TwoWindingsTransformerModificationDialogTabsProps {
+    tabIndex: number;
+    tabIndexesWithError: number[];
+    setTabIndex: (index: number) => void;
+}
+
+const TwoWindingsTransformerModificationDialogTabs = ({
+    tabIndex,
+    tabIndexesWithError,
+    setTabIndex,
+}: TwoWindingsTransformerModificationDialogTabsProps) => {
     const phaseTapChangerEnabledWatch = useWatch({
         name: `${PHASE_TAP_CHANGER}.${ENABLED}`,
     });
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.jsx b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
similarity index 66%
rename from src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.jsx
rename to src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
index 272d348301..1957809e15 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.jsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
@@ -71,8 +71,8 @@ import {
     VOLTAGE_LEVEL,
     X,
 } from 'components/utils/field-constants';
-import PropTypes from 'prop-types';
 import { useCallback, useEffect, useState } from 'react';
+import { FieldErrors, Resolver } from 'react-hook-form';
 import { sanitizeString } from '../../../dialog-utils';
 import {
     FORM_LOADING_DELAY,
@@ -85,6 +85,7 @@ import { ModificationDialog } from '../../../commons/modificationDialog';
 import TwoWindingsTransformerModificationDialogTabs from './two-windings-transformer-modification-dialog-tabs';
 import TwoWindingsTransformerCharacteristicsPane from '../characteristics-pane/two-windings-transformer-characteristics-pane';
 import {
+    CharacteristicsValues,
     getCharacteristicsEmptyFormData,
     getCharacteristicsFormData,
     getCharacteristicsValidationSchema,
@@ -130,6 +131,7 @@ import { fetchNetworkElementInfos } from '../../../../../services/study/network'
 import { FetchStatus } from '../../../../../services/utils';
 import {
     emptyProperties,
+    Equipment,
     getConcatenatedProperties,
     getPropertiesFromModification,
     modificationPropertiesSchema,
@@ -143,9 +145,9 @@ import {
     getConnectivityFormData,
     getCont1Cont2WithPositionEmptyFormData,
 } from '../../../connectivity/connectivity-form-utils';
-import BranchActiveReactivePowerMeasurementsForm from '../../common/measurements/branch-active-reactive-power-form.tsx';
+import BranchActiveReactivePowerMeasurementsForm from '../../common/measurements/branch-active-reactive-power-form';
 import { TwoWindingsTransformerModificationDialogTab } from '../two-windings-transformer-utils';
-import { ToBeEstimatedForm } from './2wt-to-be-estimated/to-be-estimated-form.tsx';
+import { ToBeEstimatedForm } from './2wt-to-be-estimated/to-be-estimated-form';
 import {
     getStateEstimationEditData,
     getStateEstimationEmptyFormData,
@@ -154,6 +156,64 @@ import {
 import { LimitsPane } from '../../../limits/limits-pane';
 import { useIntl } from 'react-intl';
 import { useFormWithDirtyTracking } from 'components/dialogs/commons/use-form-with-dirty-tracking';
+import { UUID } from 'node:crypto';
+import { CurrentTreeNode } from 'components/graph/tree-node.type';
+import {
+    TwoWindingsTransformerData,
+    TapChangerStep,
+    ConnectivityFormData,
+    LimitsFormData,
+    TapChangerData,
+    TwoWindingsTransformerEditData,
+    TapChangerEditData,
+} from '../two-windings-transformer.types';
+import { LineModificationFormInfos } from '../../line/modification/line-modification-type';
+import { BranchInfos } from 'services/study/network-map.type';
+import { ToBeEstimatedInfo } from './2wt-to-be-estimated/to-be-estimated.type';
+
+interface MeasurementFormData {
+    [VALUE]?: number | null;
+    [VALIDITY]?: boolean | null;
+}
+
+interface ToBeEstimatedFormData {
+    [RATIO_TAP_CHANGER_STATUS]?: boolean | null;
+    [PHASE_TAP_CHANGER_STATUS]?: boolean | null;
+}
+
+interface StateEstimationFormData {
+    [MEASUREMENT_P1]?: MeasurementFormData;
+    [MEASUREMENT_Q1]?: MeasurementFormData;
+    [MEASUREMENT_P2]?: MeasurementFormData;
+    [MEASUREMENT_Q2]?: MeasurementFormData;
+    [TO_BE_ESTIMATED]?: ToBeEstimatedFormData;
+}
+
+interface TwoWindingsTransformerModificationFormData {
+    [EQUIPMENT_NAME]?: string | null;
+    [CONNECTIVITY]?: {
+        [CONNECTIVITY_1]?: ConnectivityFormData;
+        [CONNECTIVITY_2]?: ConnectivityFormData;
+    };
+    [CHARACTERISTICS]?: CharacteristicsValues;
+    [LIMITS]?: LimitsFormData;
+    [STATE_ESTIMATION]?: StateEstimationFormData;
+    [RATIO_TAP_CHANGER]?: TapChangerData;
+    [PHASE_TAP_CHANGER]?: TapChangerData;
+    [ADDITIONAL_PROPERTIES]?: Record<string, unknown>[];
+}
+
+export interface TwoWindingsTransformerModificationDialogProps {
+    studyUuid: UUID;
+    defaultIdValue?: string | null;
+    currentNode: CurrentTreeNode;
+    currentRootNetworkUuid: UUID;
+    isUpdate?: boolean;
+    editData?: TwoWindingsTransformerEditData;
+    editDataFetchStatus?: (typeof FetchStatus)[keyof typeof FetchStatus];
+    onClose?: () => void;
+    onValidated?: () => void;
+}
 
 const emptyFormData = {
     [EQUIPMENT_NAME]: '',
@@ -193,31 +253,35 @@ const formSchema = yup
  */
 const TwoWindingsTransformerModificationDialog = ({
     studyUuid,
-    defaultIdValue, // Used to pre-select an equipmentId when calling this dialog from the SLD
+    defaultIdValue,
     currentNode,
     currentRootNetworkUuid,
     isUpdate,
-    editData, // contains data when we try to edit an existing hypothesis from the current node's list
+    editData,
     editDataFetchStatus,
     ...dialogProps
-}) => {
+}: TwoWindingsTransformerModificationDialogProps) => {
     const currentNodeUuid = currentNode?.id;
     const { snackError } = useSnackMessage();
-    const [selectedId, setSelectedId] = useState(defaultIdValue ?? null);
-    const [tabIndex, setTabIndex] = useState(TwoWindingsTransformerModificationDialogTab.CONNECTIVITY_TAB);
-    const [tabIndexesWithError, setTabIndexesWithError] = useState([]);
-    const [dataFetchStatus, setDataFetchStatus] = useState(FetchStatus.IDLE);
-    const [twtToModify, setTwtToModify] = useState(null);
+    const [selectedId, setSelectedId] = useState<string | null>(defaultIdValue ?? null);
+    const [tabIndex, setTabIndex] = useState<number>(TwoWindingsTransformerModificationDialogTab.CONNECTIVITY_TAB);
+    const [tabIndexesWithError, setTabIndexesWithError] = useState<number[]>([]);
+    const [dataFetchStatus, setDataFetchStatus] = useState<(typeof FetchStatus)[keyof typeof FetchStatus]>(
+        FetchStatus.IDLE
+    );
+    const [twtToModify, setTwtToModify] = useState<TwoWindingsTransformerData | null>(null);
     const intl = useIntl();
 
-    const formMethods = useFormWithDirtyTracking({
+    const formMethods = useFormWithDirtyTracking<TwoWindingsTransformerModificationFormData>({
         defaultValues: emptyFormData,
-        resolver: yupResolver(formSchema),
+        resolver: yupResolver(formSchema) as unknown as Resolver<TwoWindingsTransformerModificationFormData>,
     });
     const { reset, getValues } = formMethods;
     const voltageLevelOptions = useVoltageLevelsListInfos(studyUuid, currentNodeUuid, currentRootNetworkUuid);
 
-    const computeRatioTapChangerRegulationMode = (ratioTapChangerFormValues) => {
+    const computeRatioTapChangerRegulationMode = (
+        ratioTapChangerFormValues: TapChangerEditData | undefined
+    ): string | null => {
         if (ratioTapChangerFormValues?.[REGULATING]?.value == null) {
             return null;
         }
@@ -229,15 +293,21 @@ const TwoWindingsTransformerModificationDialog = ({
     };
 
     const fromEditDataToFormValues = useCallback(
-        (twtModification) => {
+        (twtModification: TwoWindingsTransformerEditData) => {
             if (twtModification?.equipmentId) {
                 setSelectedId(twtModification.equipmentId);
             }
             reset({
                 [EQUIPMENT_NAME]: twtModification.equipmentName?.value,
                 [CONNECTIVITY]: {
-                    ...getConnectivityFormData(createConnectivityData(twtModification, 1), CONNECTIVITY_1),
-                    ...getConnectivityFormData(createConnectivityData(twtModification, 2), CONNECTIVITY_2),
+                    [CONNECTIVITY_1]: getConnectivityFormData(
+                        createConnectivityData(twtModification, 1),
+                        CONNECTIVITY_1
+                    ),
+                    [CONNECTIVITY_2]: getConnectivityFormData(
+                        createConnectivityData(twtModification, 2),
+                        CONNECTIVITY_2
+                    ),
                 },
                 ...getCharacteristicsFormData({
                     r: twtModification.r?.value,
@@ -265,9 +335,9 @@ const TwoWindingsTransformerModificationDialog = ({
                     targetV: twtModification?.[RATIO_TAP_CHANGER]?.[TARGET_V]?.value,
                     targetDeadband: twtModification?.[RATIO_TAP_CHANGER]?.[TARGET_DEADBAND]?.value,
                     lowTapPosition: twtModification?.[RATIO_TAP_CHANGER]?.[LOW_TAP_POSITION]?.value,
-                    highTapPosition: computeHighTapPosition(twtModification?.[RATIO_TAP_CHANGER]?.[STEPS]),
+                    highTapPosition: computeHighTapPosition(twtModification?.[RATIO_TAP_CHANGER]?.[STEPS] ?? []),
                     tapPosition: twtModification?.[RATIO_TAP_CHANGER]?.[TAP_POSITION]?.value,
-                    steps: addSelectedFieldToRows(twtModification?.[RATIO_TAP_CHANGER]?.[STEPS]),
+                    steps: addSelectedFieldToRows(twtModification?.[RATIO_TAP_CHANGER]?.[STEPS] ?? []),
                     equipmentId: twtModification?.[RATIO_TAP_CHANGER]?.terminalRefConnectableId?.value,
                     equipmentType: twtModification?.[RATIO_TAP_CHANGER]?.terminalRefConnectableType?.value,
                     voltageLevelId: twtModification?.[RATIO_TAP_CHANGER]?.terminalRefConnectableVlId?.value,
@@ -291,9 +361,9 @@ const TwoWindingsTransformerModificationDialog = ({
                             : undefined,
                     targetDeadband: twtModification?.[PHASE_TAP_CHANGER]?.[TARGET_DEADBAND]?.value,
                     lowTapPosition: twtModification?.[PHASE_TAP_CHANGER]?.[LOW_TAP_POSITION]?.value,
-                    highTapPosition: computeHighTapPosition(twtModification?.[PHASE_TAP_CHANGER]?.[STEPS]),
+                    highTapPosition: computeHighTapPosition(twtModification?.[PHASE_TAP_CHANGER]?.[STEPS] ?? []),
                     tapPosition: twtModification?.[PHASE_TAP_CHANGER]?.[TAP_POSITION]?.value,
-                    steps: addSelectedFieldToRows(twtModification?.[PHASE_TAP_CHANGER]?.[STEPS]),
+                    steps: addSelectedFieldToRows(twtModification?.[PHASE_TAP_CHANGER]?.[STEPS] ?? []),
                     equipmentId: twtModification?.[PHASE_TAP_CHANGER]?.terminalRefConnectableId?.value,
                     equipmentType: twtModification?.[PHASE_TAP_CHANGER]?.terminalRefConnectableType?.value,
                     voltageLevelId: twtModification?.[PHASE_TAP_CHANGER]?.terminalRefConnectableVlId?.value,
@@ -310,84 +380,107 @@ const TwoWindingsTransformerModificationDialog = ({
         }
     }, [fromEditDataToFormValues, editData]);
 
-    const computeRatioTapChangerRegulating = (ratioTapChangerFormValues) => {
+    const computeRatioTapChangerRegulating = (ratioTapChangerFormValues: TapChangerData): boolean => {
         return ratioTapChangerFormValues?.[REGULATION_MODE] === RATIO_REGULATION_MODES.VOLTAGE_REGULATION.id;
     };
 
-    const computePhaseTapChangerRegulationValue = (phaseTapChangerFormValues, currentRegulationMode) => {
+    const computePhaseTapChangerRegulationValue = (
+        phaseTapChangerFormValues: TapChangerData,
+        currentRegulationMode?: string
+    ): number | undefined => {
         const regulationMode = phaseTapChangerFormValues?.[REGULATION_MODE] || currentRegulationMode;
 
         switch (regulationMode) {
             case PHASE_REGULATION_MODES.ACTIVE_POWER_CONTROL.id:
-                return phaseTapChangerFormValues?.[FLOW_SET_POINT_REGULATING_VALUE];
+                return phaseTapChangerFormValues?.[FLOW_SET_POINT_REGULATING_VALUE] ?? undefined;
             case PHASE_REGULATION_MODES.CURRENT_LIMITER.id:
-                return phaseTapChangerFormValues?.[CURRENT_LIMITER_REGULATING_VALUE];
+                return phaseTapChangerFormValues?.[CURRENT_LIMITER_REGULATING_VALUE] ?? undefined;
             default:
                 return undefined;
         }
     };
 
-    const fillPhaseTapChangerRegulationAttributes = useCallback((phaseTap, phaseTapChangerFormValues, twtToModify) => {
-        const regulationMode =
-            phaseTapChangerFormValues?.[REGULATION_MODE] ??
-            getComputedPhaseTapChangerRegulationMode(twtToModify?.[PHASE_TAP_CHANGER])?.id;
-        const regulationType =
-            phaseTapChangerFormValues?.[REGULATION_TYPE] ?? getComputedPreviousPhaseRegulationType(twtToModify);
-        if (regulationMode) {
-            phaseTap.regulationType = toModificationOperation(phaseTapChangerFormValues?.[REGULATION_TYPE]);
-            if (regulationType === REGULATION_TYPES.LOCAL.id) {
-                phaseTap.regulationSide = toModificationOperation(phaseTapChangerFormValues?.[REGULATION_SIDE]);
-            } else if (regulationType === REGULATION_TYPES.DISTANT.id) {
-                phaseTap.terminalRefConnectableId = toModificationOperation(phaseTapChangerFormValues?.[EQUIPMENT]?.id);
-                phaseTap.terminalRefConnectableType = toModificationOperation(
-                    phaseTapChangerFormValues?.[EQUIPMENT]?.type
-                );
-                phaseTap.terminalRefConnectableVlId = toModificationOperation(
-                    phaseTapChangerFormValues?.[VOLTAGE_LEVEL]?.[ID]
+    const fillPhaseTapChangerRegulationAttributes = useCallback(
+        (
+            phaseTap: Record<string, unknown>,
+            phaseTapChangerFormValues: TapChangerData,
+            twtToModify: TwoWindingsTransformerData | null
+        ) => {
+            const regulationMode =
+                phaseTapChangerFormValues?.[REGULATION_MODE] ??
+                getComputedPhaseTapChangerRegulationMode(twtToModify?.[PHASE_TAP_CHANGER])?.id;
+            const regulationType =
+                phaseTapChangerFormValues?.[REGULATION_TYPE] ??
+                (twtToModify ? getComputedPreviousPhaseRegulationType(twtToModify) : undefined);
+            if (regulationMode) {
+                phaseTap.regulationType = toModificationOperation(phaseTapChangerFormValues?.[REGULATION_TYPE]);
+                if (regulationType === REGULATION_TYPES.LOCAL.id) {
+                    phaseTap.regulationSide = toModificationOperation(phaseTapChangerFormValues?.[REGULATION_SIDE]);
+                } else if (regulationType === REGULATION_TYPES.DISTANT.id) {
+                    phaseTap.terminalRefConnectableId = toModificationOperation(
+                        phaseTapChangerFormValues?.[EQUIPMENT]?.id
+                    );
+                    phaseTap.terminalRefConnectableType = toModificationOperation(
+                        phaseTapChangerFormValues?.[EQUIPMENT]?.type
+                    );
+                    phaseTap.terminalRefConnectableVlId = toModificationOperation(
+                        phaseTapChangerFormValues?.[VOLTAGE_LEVEL]?.[ID]
+                    );
+                }
+                phaseTap.regulationValue = toModificationOperation(
+                    computePhaseTapChangerRegulationValue(
+                        phaseTapChangerFormValues,
+                        twtToModify?.[PHASE_TAP_CHANGER]?.[REGULATION_MODE]
+                    )
                 );
+                phaseTap.targetDeadband = toModificationOperation(phaseTapChangerFormValues[TARGET_DEADBAND]);
             }
-            phaseTap.regulationValue = toModificationOperation(
-                computePhaseTapChangerRegulationValue(
-                    phaseTapChangerFormValues,
-                    twtToModify?.[PHASE_TAP_CHANGER]?.[REGULATION_MODE]
-                )
-            );
-            phaseTap.targetDeadband = toModificationOperation(phaseTapChangerFormValues[TARGET_DEADBAND]);
-        }
-    }, []);
-
-    const fillRatioTapChangerRegulationAttributes = useCallback((ratioTap, ratioTapChangerFormValues, twtToModify) => {
-        const hasLoadTapChangingCapabilities =
-            ratioTapChangerFormValues?.[LOAD_TAP_CHANGING_CAPABILITIES] ??
-            twtToModify?.[RATIO_TAP_CHANGER]?.[LOAD_TAP_CHANGING_CAPABILITIES];
-        const regulationType =
-            ratioTapChangerFormValues?.[REGULATION_TYPE] ?? getComputedPreviousRatioRegulationType(twtToModify);
-        if (hasLoadTapChangingCapabilities) {
-            ratioTap.regulationType = toModificationOperation(ratioTapChangerFormValues?.[REGULATION_TYPE]);
-            ratioTap.isRegulating = toModificationOperation(
-                ratioTapChangerFormValues?.[REGULATION_MODE]
-                    ? computeRatioTapChangerRegulating(ratioTapChangerFormValues)
-                    : null
-            );
-            if (regulationType === REGULATION_TYPES.LOCAL.id) {
-                ratioTap.regulationSide = toModificationOperation(ratioTapChangerFormValues?.[REGULATION_SIDE]);
-            } else if (regulationType === REGULATION_TYPES.DISTANT.id) {
-                ratioTap.terminalRefConnectableId = toModificationOperation(ratioTapChangerFormValues?.[EQUIPMENT]?.id);
-                ratioTap.terminalRefConnectableType = toModificationOperation(
-                    ratioTapChangerFormValues?.[EQUIPMENT]?.type
-                );
-                ratioTap.terminalRefConnectableVlId = toModificationOperation(
-                    ratioTapChangerFormValues?.[VOLTAGE_LEVEL]?.[ID]
+        },
+        []
+    );
+
+    const fillRatioTapChangerRegulationAttributes = useCallback(
+        (
+            ratioTap: Record<string, unknown>,
+            ratioTapChangerFormValues: TapChangerData,
+            twtToModify: TwoWindingsTransformerData | null
+        ) => {
+            const hasLoadTapChangingCapabilities =
+                ratioTapChangerFormValues?.[LOAD_TAP_CHANGING_CAPABILITIES] ??
+                twtToModify?.[RATIO_TAP_CHANGER]?.[LOAD_TAP_CHANGING_CAPABILITIES];
+            const regulationType =
+                ratioTapChangerFormValues?.[REGULATION_TYPE] ??
+                (twtToModify ? getComputedPreviousRatioRegulationType(twtToModify) : undefined);
+            if (hasLoadTapChangingCapabilities) {
+                ratioTap.regulationType = toModificationOperation(ratioTapChangerFormValues?.[REGULATION_TYPE]);
+                ratioTap.isRegulating = toModificationOperation(
+                    ratioTapChangerFormValues?.[REGULATION_MODE]
+                        ? computeRatioTapChangerRegulating(ratioTapChangerFormValues)
+                        : null
                 );
+                if (regulationType === REGULATION_TYPES.LOCAL.id) {
+                    ratioTap.regulationSide = toModificationOperation(ratioTapChangerFormValues?.[REGULATION_SIDE]);
+                } else if (regulationType === REGULATION_TYPES.DISTANT.id) {
+                    ratioTap.terminalRefConnectableId = toModificationOperation(
+                        ratioTapChangerFormValues?.[EQUIPMENT]?.id
+                    );
+                    ratioTap.terminalRefConnectableType = toModificationOperation(
+                        ratioTapChangerFormValues?.[EQUIPMENT]?.type
+                    );
+                    ratioTap.terminalRefConnectableVlId = toModificationOperation(
+                        ratioTapChangerFormValues?.[VOLTAGE_LEVEL]?.[ID]
+                    );
+                }
+                ratioTap.targetV = toModificationOperation(ratioTapChangerFormValues?.[TARGET_V]);
+                ratioTap.targetDeadband = toModificationOperation(ratioTapChangerFormValues?.[TARGET_DEADBAND]);
             }
-            ratioTap.targetV = toModificationOperation(ratioTapChangerFormValues?.[TARGET_V]);
-            ratioTap.targetDeadband = toModificationOperation(ratioTapChangerFormValues?.[TARGET_DEADBAND]);
-        }
-    }, []);
+        },
+        []
+    );
 
     const computeRatioTapForSubmit = useCallback(
-        (twt) => {
-            let ratioTap;
+        (twt: TwoWindingsTransformerModificationFormData): Record<string, unknown> => {
+            let ratioTap: Record<string, unknown>;
             const ratioTapChangerFormValues = twt[RATIO_TAP_CHANGER];
             const enableRatioTapChanger =
                 ratioTapChangerFormValues?.[ENABLED] !== !!twtToModify?.ratioTapChanger
@@ -397,10 +490,10 @@ const TwoWindingsTransformerModificationDialog = ({
                 isNodeBuilt(currentNode) && editData?.[RATIO_TAP_CHANGER]?.[STEPS]
                     ? true
                     : !compareStepsWithPreviousValues(
-                          ratioTapChangerFormValues[STEPS],
+                          ratioTapChangerFormValues?.[STEPS] ?? [],
                           twtToModify?.[RATIO_TAP_CHANGER]?.[STEPS]
                       );
-            let ratioTapChangerSteps = !areRatioStepsModified ? null : ratioTapChangerFormValues[STEPS];
+            const ratioTapChangerSteps = !areRatioStepsModified ? null : ratioTapChangerFormValues?.[STEPS];
             if (ratioTapChangerFormValues?.[ENABLED]) {
                 ratioTap = {
                     [ENABLED]: toModificationOperation(enableRatioTapChanger),
@@ -423,8 +516,8 @@ const TwoWindingsTransformerModificationDialog = ({
     );
 
     const computePhaseTapForSubmit = useCallback(
-        (twt) => {
-            let phaseTap;
+        (twt: TwoWindingsTransformerModificationFormData): Record<string, unknown> => {
+            let phaseTap: Record<string, unknown>;
             const phaseTapChangerFormValues = twt[PHASE_TAP_CHANGER];
             const enablePhaseTapChanger =
                 phaseTapChangerFormValues?.[ENABLED] !== !!twtToModify?.phaseTapChanger
@@ -434,10 +527,10 @@ const TwoWindingsTransformerModificationDialog = ({
                 isNodeBuilt(currentNode) && editData?.[PHASE_TAP_CHANGER]?.[STEPS]
                     ? true
                     : !compareStepsWithPreviousValues(
-                          phaseTapChangerFormValues[STEPS],
+                          phaseTapChangerFormValues?.[STEPS] ?? [],
                           twtToModify?.[PHASE_TAP_CHANGER]?.[STEPS]
                       );
-            let phaseTapChangerSteps = !arePhaseStepsModified ? null : phaseTapChangerFormValues[STEPS];
+            const phaseTapChangerSteps = !arePhaseStepsModified ? null : phaseTapChangerFormValues?.[STEPS];
             if (phaseTapChangerFormValues?.[ENABLED]) {
                 phaseTap = {
                     [ENABLED]: toModificationOperation(enablePhaseTapChanger),
@@ -467,7 +560,7 @@ const TwoWindingsTransformerModificationDialog = ({
     );
 
     const onSubmit = useCallback(
-        (twt) => {
+        (twt: TwoWindingsTransformerModificationFormData) => {
             const connectivity1 = twt[CONNECTIVITY]?.[CONNECTIVITY_1];
             const connectivity2 = twt[CONNECTIVITY]?.[CONNECTIVITY_2];
             const characteristics = twt[CHARACTERISTICS];
@@ -478,56 +571,56 @@ const TwoWindingsTransformerModificationDialog = ({
                 studyUuid: studyUuid,
                 nodeUuid: currentNodeUuid,
                 modificationUuid: editData?.uuid,
-                twoWindingsTransformerId: selectedId,
+                twoWindingsTransformerId: selectedId ?? '',
                 twoWindingsTransformerName: toModificationOperation(sanitizeString(twt[EQUIPMENT_NAME])),
-                r: toModificationOperation(characteristics[R]),
-                x: toModificationOperation(characteristics[X]),
-                g: toModificationOperation(convertOutputValue(FieldType.G, characteristics[G])),
-                b: toModificationOperation(convertOutputValue(FieldType.B, characteristics[B])),
-                ratedS: toModificationOperation(characteristics[RATED_S]),
-                ratedU1: toModificationOperation(characteristics[RATED_U1]),
-                ratedU2: toModificationOperation(characteristics[RATED_U2]),
-                operationalLimitsGroups: limits[ENABLE_OLG_MODIFICATION]
-                    ? addModificationTypeToOpLimitsGroups(limits[OPERATIONAL_LIMITS_GROUPS])
+                r: toModificationOperation(characteristics?.[R]),
+                x: toModificationOperation(characteristics?.[X]),
+                g: toModificationOperation(convertOutputValue(FieldType.G, characteristics?.[G])),
+                b: toModificationOperation(convertOutputValue(FieldType.B, characteristics?.[B])),
+                ratedS: toModificationOperation(characteristics?.[RATED_S]),
+                ratedU1: toModificationOperation(characteristics?.[RATED_U1]),
+                ratedU2: toModificationOperation(characteristics?.[RATED_U2]),
+                operationalLimitsGroups: limits?.[ENABLE_OLG_MODIFICATION]
+                    ? addModificationTypeToOpLimitsGroups(limits[OPERATIONAL_LIMITS_GROUPS] ?? [])
                     : [],
                 selectedLimitsGroup1: addOperationTypeToSelectedOpLG(
-                    limits[SELECTED_OPERATIONAL_LIMITS_GROUP_ID1],
+                    limits?.[SELECTED_OPERATIONAL_LIMITS_GROUP_ID1],
                     intl.formatMessage({
                         id: 'None',
                     })
                 ),
                 selectedLimitsGroup2: addOperationTypeToSelectedOpLG(
-                    limits[SELECTED_OPERATIONAL_LIMITS_GROUP_ID2],
+                    limits?.[SELECTED_OPERATIONAL_LIMITS_GROUP_ID2],
                     intl.formatMessage({
                         id: 'None',
                     })
                 ),
-                [ENABLE_OLG_MODIFICATION]: limits[ENABLE_OLG_MODIFICATION],
+                [ENABLE_OLG_MODIFICATION]: Boolean(limits?.[ENABLE_OLG_MODIFICATION]),
                 ratioTapChanger: computeRatioTapForSubmit(twt),
                 phaseTapChanger: computePhaseTapForSubmit(twt),
-                voltageLevelId1: connectivity1[VOLTAGE_LEVEL]?.id,
-                busOrBusbarSectionId1: connectivity1[BUS_OR_BUSBAR_SECTION]?.id,
-                voltageLevelId2: connectivity2[VOLTAGE_LEVEL]?.id,
-                busOrBusbarSectionId2: connectivity2[BUS_OR_BUSBAR_SECTION]?.id,
-                connectionName1: sanitizeString(connectivity1[CONNECTION_NAME]),
-                connectionName2: sanitizeString(connectivity2[CONNECTION_NAME]),
-                connectionDirection1: connectivity1[CONNECTION_DIRECTION],
-                connectionDirection2: connectivity2[CONNECTION_DIRECTION],
-                connectionPosition1: connectivity1[CONNECTION_POSITION],
-                connectionPosition2: connectivity2[CONNECTION_POSITION],
-                connected1: connectivity1[CONNECTED],
-                connected2: connectivity2[CONNECTED],
-                properties: toModificationProperties(twt),
-                p1MeasurementValue: stateEstimationData[MEASUREMENT_P1][VALUE],
-                p1MeasurementValidity: stateEstimationData[MEASUREMENT_P1][VALIDITY],
-                q1MeasurementValue: stateEstimationData[MEASUREMENT_Q1][VALUE],
-                q1MeasurementValidity: stateEstimationData[MEASUREMENT_Q1][VALIDITY],
-                p2MeasurementValue: stateEstimationData[MEASUREMENT_P2][VALUE],
-                p2MeasurementValidity: stateEstimationData[MEASUREMENT_P2][VALIDITY],
-                q2MeasurementValue: stateEstimationData[MEASUREMENT_Q2][VALUE],
-                q2MeasurementValidity: stateEstimationData[MEASUREMENT_Q2][VALIDITY],
-                ratioTapChangerToBeEstimated: stateEstimationData[TO_BE_ESTIMATED][RATIO_TAP_CHANGER_STATUS],
-                phaseTapChangerToBeEstimated: stateEstimationData[TO_BE_ESTIMATED][PHASE_TAP_CHANGER_STATUS],
+                voltageLevelId1: connectivity1?.[VOLTAGE_LEVEL]?.id,
+                busOrBusbarSectionId1: connectivity1?.[BUS_OR_BUSBAR_SECTION]?.id,
+                voltageLevelId2: connectivity2?.[VOLTAGE_LEVEL]?.id,
+                busOrBusbarSectionId2: connectivity2?.[BUS_OR_BUSBAR_SECTION]?.id,
+                connectionName1: sanitizeString(connectivity1?.[CONNECTION_NAME]),
+                connectionName2: sanitizeString(connectivity2?.[CONNECTION_NAME]),
+                connectionDirection1: connectivity1?.[CONNECTION_DIRECTION],
+                connectionDirection2: connectivity2?.[CONNECTION_DIRECTION],
+                connectionPosition1: String(connectivity1?.[CONNECTION_POSITION]),
+                connectionPosition2: String(connectivity2?.[CONNECTION_POSITION]),
+                connected1: Boolean(connectivity1?.[CONNECTED]),
+                connected2: Boolean(connectivity2?.[CONNECTED]),
+                properties: toModificationProperties(twt as unknown as Record<string, unknown>),
+                p1MeasurementValue: stateEstimationData?.[MEASUREMENT_P1]?.[VALUE],
+                p1MeasurementValidity: stateEstimationData?.[MEASUREMENT_P1]?.[VALIDITY],
+                q1MeasurementValue: stateEstimationData?.[MEASUREMENT_Q1]?.[VALUE],
+                q1MeasurementValidity: stateEstimationData?.[MEASUREMENT_Q1]?.[VALIDITY],
+                p2MeasurementValue: stateEstimationData?.[MEASUREMENT_P2]?.[VALUE],
+                p2MeasurementValidity: stateEstimationData?.[MEASUREMENT_P2]?.[VALIDITY],
+                q2MeasurementValue: stateEstimationData?.[MEASUREMENT_Q2]?.[VALUE],
+                q2MeasurementValidity: stateEstimationData?.[MEASUREMENT_Q2]?.[VALIDITY],
+                ratioTapChangerToBeEstimated: stateEstimationData?.[TO_BE_ESTIMATED]?.[RATIO_TAP_CHANGER_STATUS],
+                phaseTapChangerToBeEstimated: stateEstimationData?.[TO_BE_ESTIMATED]?.[PHASE_TAP_CHANGER_STATUS],
             }).catch((error) => {
                 snackWithFallback(snackError, error, { headerId: 'TwoWindingsTransformerModificationError' });
             });
@@ -544,8 +637,8 @@ const TwoWindingsTransformerModificationDialog = ({
         ]
     );
 
-    const onValidationError = (errors) => {
-        let tabsInError = [];
+    const onValidationError = (errors: FieldErrors<TwoWindingsTransformerModificationFormData>) => {
+        const tabsInError: number[] = [];
         if (errors?.[CONNECTIVITY] !== undefined) {
             tabsInError.push(TwoWindingsTransformerModificationDialogTab.CONNECTIVITY_TAB);
         }
@@ -586,27 +679,27 @@ const TwoWindingsTransformerModificationDialog = ({
     });
 
     const isRatioTapChangerEnabled = useCallback(
-        (twt) => {
+        (twt: TwoWindingsTransformerData): boolean => {
             if (editData?.ratioTapChanger?.enabled === undefined) {
                 return !!twt.ratioTapChanger;
             }
-            return editData?.ratioTapChanger?.enabled?.value;
+            return editData?.ratioTapChanger?.enabled?.value ?? false;
         },
         [editData]
     );
 
     const isPhaseTapChangerEnabled = useCallback(
-        (twt) => {
+        (twt: TwoWindingsTransformerData): boolean => {
             if (editData?.phaseTapChanger?.enabled === undefined) {
                 return !!twt.phaseTapChanger;
             }
-            return editData?.phaseTapChanger?.enabled?.value;
+            return editData?.phaseTapChanger?.enabled?.value ?? false;
         },
         [editData?.phaseTapChanger?.enabled]
     );
 
     const getPhaseTapChangerSteps = useCallback(
-        (twt) => {
+        (twt: TwoWindingsTransformerData): TapChangerStep[] | undefined => {
             if (editData === undefined) {
                 return twt?.[PHASE_TAP_CHANGER]?.[STEPS];
             }
@@ -617,13 +710,13 @@ const TwoWindingsTransformerModificationDialog = ({
             ) {
                 return twt?.[PHASE_TAP_CHANGER]?.[STEPS];
             }
-            return editData?.phaseTapChanger?.steps;
+            return editData?.phaseTapChanger?.steps ?? undefined;
         },
         [editData]
     );
 
     const getRatioTapChangerSteps = useCallback(
-        (twt) => {
+        (twt: TwoWindingsTransformerData): TapChangerStep[] | undefined => {
             if (editData === undefined) {
                 return twt?.[RATIO_TAP_CHANGER]?.[STEPS];
             }
@@ -634,13 +727,13 @@ const TwoWindingsTransformerModificationDialog = ({
             ) {
                 return twt?.[RATIO_TAP_CHANGER]?.[STEPS];
             }
-            return editData?.ratioTapChanger?.steps;
+            return editData?.ratioTapChanger?.steps ?? undefined;
         },
         [editData]
     );
 
     const onEquipmentIdChange = useCallback(
-        (equipmentId) => {
+        (equipmentId: string | null) => {
             if (equipmentId) {
                 setDataFetchStatus(FetchStatus.RUNNING);
                 fetchNetworkElementInfos(
@@ -652,18 +745,20 @@ const TwoWindingsTransformerModificationDialog = ({
                     equipmentId,
                     true
                 )
-                    .then((twt) => {
+                    .then((twt: TwoWindingsTransformerData) => {
                         if (twt) {
                             setTwtToModify(twt);
                             reset(
                                 (formValues) => ({
                                     ...formValues,
                                     ...{
-                                        [LIMITS]: formValues?.limits[ENABLE_OLG_MODIFICATION]
+                                        [LIMITS]: (formValues?.limits?.[ENABLE_OLG_MODIFICATION]
                                             ? {
                                                   [ENABLE_OLG_MODIFICATION]: formValues.limits[ENABLE_OLG_MODIFICATION],
                                                   [OPERATIONAL_LIMITS_GROUPS]:
-                                                      getOpLimitsGroupInfosFromBranchModification(formValues),
+                                                      getOpLimitsGroupInfosFromBranchModification(
+                                                          formValues as unknown as LineModificationFormInfos
+                                                      ),
                                               }
                                             : {
                                                   [ENABLE_OLG_MODIFICATION]: false,
@@ -671,50 +766,52 @@ const TwoWindingsTransformerModificationDialog = ({
                                                       convertToOperationalLimitsGroupFormSchema(
                                                           twt?.currentLimits ?? []
                                                       ),
-                                              },
+                                              }) as any,
                                     },
                                     ...getRatioTapChangerFormData({
                                         enabled: isRatioTapChangerEnabled(twt),
-                                        hasLoadTapChangingCapabilities: getValues(
-                                            `${RATIO_TAP_CHANGER}.${LOAD_TAP_CHANGING_CAPABILITIES}`
+                                        hasLoadTapChangingCapabilities: Boolean(
+                                            getValues(`${RATIO_TAP_CHANGER}.${LOAD_TAP_CHANGING_CAPABILITIES}`)
                                         ),
                                         regulationMode:
-                                            getValues(`${RATIO_TAP_CHANGER}.${REGULATING}`) === false
+                                            Boolean(getValues(`${RATIO_TAP_CHANGER}.${REGULATING}`)) === false
                                                 ? PHASE_REGULATION_MODES.OFF.id
-                                                : getValues(`${RATIO_TAP_CHANGER}.${REGULATION_MODE}`),
-                                        regulationType: getValues(`${RATIO_TAP_CHANGER}.${REGULATION_TYPE}`),
-                                        regulationSide: getValues(`${RATIO_TAP_CHANGER}.${REGULATION_SIDE}`),
-                                        targetV: getValues(`${RATIO_TAP_CHANGER}.${TARGET_V}`),
-                                        targetDeadband: getValues(`${RATIO_TAP_CHANGER}.${TARGET_DEADBAND}`),
-                                        lowTapPosition: getValues(`${RATIO_TAP_CHANGER}.${LOW_TAP_POSITION}`),
-                                        highTapPosition: getValues(`${RATIO_TAP_CHANGER}.${HIGH_TAP_POSITION}`),
-                                        tapPosition: getValues(`${RATIO_TAP_CHANGER}.${TAP_POSITION}`),
+                                                : String(getValues(`${RATIO_TAP_CHANGER}.${REGULATION_MODE}`)),
+                                        regulationType: String(getValues(`${RATIO_TAP_CHANGER}.${REGULATION_TYPE}`)),
+                                        regulationSide: String(getValues(`${RATIO_TAP_CHANGER}.${REGULATION_SIDE}`)),
+                                        targetV: Number(getValues(`${RATIO_TAP_CHANGER}.${TARGET_V}`)),
+                                        targetDeadband: Number(getValues(`${RATIO_TAP_CHANGER}.${TARGET_DEADBAND}`)),
+                                        lowTapPosition: Number(getValues(`${RATIO_TAP_CHANGER}.${LOW_TAP_POSITION}`)),
+                                        highTapPosition: Number(getValues(`${RATIO_TAP_CHANGER}.${HIGH_TAP_POSITION}`)),
+                                        tapPosition: Number(getValues(`${RATIO_TAP_CHANGER}.${TAP_POSITION}`)),
                                         steps: addSelectedFieldToRows(getRatioTapChangerSteps(twt)),
-                                        equipmentId: getValues(`${RATIO_TAP_CHANGER}.${EQUIPMENT}.${ID}`),
-                                        equipmentType: getValues(`${RATIO_TAP_CHANGER}.${EQUIPMENT}.${TYPE}`),
+                                        equipmentId: String(getValues(`${RATIO_TAP_CHANGER}.${EQUIPMENT}.${ID}`)),
+                                        equipmentType: String(getValues(`${RATIO_TAP_CHANGER}.${EQUIPMENT}.${TYPE}`)),
                                         voltageLevelId: getValues(`${RATIO_TAP_CHANGER}.${VOLTAGE_LEVEL}.${ID}`),
                                     }),
                                     ...getPhaseTapChangerFormData({
                                         enabled: isPhaseTapChangerEnabled(twt),
-                                        regulationMode: getValues(`${PHASE_TAP_CHANGER}.${REGULATION_MODE}`),
-                                        regulationType: getValues(`${PHASE_TAP_CHANGER}.${REGULATION_TYPE}`),
-                                        regulationSide: getValues(`${PHASE_TAP_CHANGER}.${REGULATION_SIDE}`),
-                                        currentLimiterRegulatingValue: getValues(
-                                            `${PHASE_TAP_CHANGER}.${CURRENT_LIMITER_REGULATING_VALUE}`
+                                        regulationMode: String(getValues(`${PHASE_TAP_CHANGER}.${REGULATION_MODE}`)),
+                                        regulationType: String(getValues(`${PHASE_TAP_CHANGER}.${REGULATION_TYPE}`)),
+                                        regulationSide: String(getValues(`${PHASE_TAP_CHANGER}.${REGULATION_SIDE}`)),
+                                        currentLimiterRegulatingValue: Number(
+                                            getValues(`${PHASE_TAP_CHANGER}.${CURRENT_LIMITER_REGULATING_VALUE}`)
                                         ),
-                                        flowSetpointRegulatingValue: getValues(
-                                            `${PHASE_TAP_CHANGER}.${FLOW_SET_POINT_REGULATING_VALUE}`
+                                        flowSetpointRegulatingValue: Number(
+                                            getValues(`${PHASE_TAP_CHANGER}.${FLOW_SET_POINT_REGULATING_VALUE}`)
                                         ),
-                                        targetDeadband: getValues(`${PHASE_TAP_CHANGER}.${TARGET_DEADBAND}`),
-                                        lowTapPosition: getValues(`${PHASE_TAP_CHANGER}.${LOW_TAP_POSITION}`),
-                                        highTapPosition: getValues(`${PHASE_TAP_CHANGER}.${HIGH_TAP_POSITION}`),
-                                        tapPosition: getValues(`${PHASE_TAP_CHANGER}.${TAP_POSITION}`),
+                                        targetDeadband: Number(getValues(`${PHASE_TAP_CHANGER}.${TARGET_DEADBAND}`)),
+                                        lowTapPosition: Number(getValues(`${PHASE_TAP_CHANGER}.${LOW_TAP_POSITION}`)),
+                                        highTapPosition: Number(getValues(`${PHASE_TAP_CHANGER}.${HIGH_TAP_POSITION}`)),
+                                        tapPosition: Number(getValues(`${PHASE_TAP_CHANGER}.${TAP_POSITION}`)),
                                         steps: addSelectedFieldToRows(getPhaseTapChangerSteps(twt)),
-                                        equipmentId: getValues(`${PHASE_TAP_CHANGER}.${EQUIPMENT}.${ID}`),
-                                        equipmentType: getValues(`${PHASE_TAP_CHANGER}.${EQUIPMENT}.${TYPE}`),
-                                        voltageLevelId: getValues(`${PHASE_TAP_CHANGER}.${VOLTAGE_LEVEL}.${ID}`),
+                                        equipmentId: String(getValues(`${PHASE_TAP_CHANGER}.${EQUIPMENT}.${ID}`)),
+                                        equipmentType: String(getValues(`${PHASE_TAP_CHANGER}.${EQUIPMENT}.${TYPE}`)),
+                                        voltageLevelId: String(
+                                            getValues(`${PHASE_TAP_CHANGER}.${VOLTAGE_LEVEL}.${ID}`)
+                                        ),
                                     }),
-                                    [ADDITIONAL_PROPERTIES]: getConcatenatedProperties(twt, getValues),
+                                    [ADDITIONAL_PROPERTIES]: getConcatenatedProperties(twt as Equipment, getValues),
                                 }),
                                 { keepDirty: true }
                             );
@@ -754,7 +851,10 @@ const TwoWindingsTransformerModificationDialog = ({
 
     const headerAndTabs = (
         <Grid container spacing={2}>
-            <TwoWindingsTransformerModificationDialogHeader equipmentToModify={twtToModify} equipmentId={selectedId} />
+            <TwoWindingsTransformerModificationDialogHeader
+                equipmentToModify={twtToModify?.name}
+                equipmentId={selectedId}
+            />
             <TwoWindingsTransformerModificationDialogTabs
                 tabIndex={tabIndex}
                 tabIndexesWithError={tabIndexesWithError}
@@ -766,7 +866,7 @@ const TwoWindingsTransformerModificationDialog = ({
     return (
         <CustomFormProvider
             removeOptional={true}
-            validationSchema={formSchema}
+            validationSchema={formSchema as any}
             {...formMethods}
             isNodeBuilt={isNodeBuilt(currentNode)}
             isUpdate={isUpdate}
@@ -804,7 +904,6 @@ const TwoWindingsTransformerModificationDialog = ({
                                 studyUuid={studyUuid}
                                 currentNode={currentNode}
                                 currentRootNetworkUuid={currentRootNetworkUuid}
-                                withPosition={true}
                                 isModification={true}
                                 previousValues={twtToModify}
                             />
@@ -821,7 +920,11 @@ const TwoWindingsTransformerModificationDialog = ({
                             <TwoWindingsTransformerCharacteristicsPane twtToModify={twtToModify} isModification />
                         </Box>
                         <Box hidden={tabIndex !== TwoWindingsTransformerModificationDialogTab.LIMITS_TAB} p={1}>
-                            <LimitsPane currentNode={currentNode} equipmentToModify={twtToModify} clearableFields />
+                            <LimitsPane
+                                currentNode={currentNode}
+                                equipmentToModify={twtToModify as BranchInfos}
+                                clearableFields
+                            />
                         </Box>
                         <Box
                             hidden={tabIndex !== TwoWindingsTransformerModificationDialogTab.STATE_ESTIMATION_TAB}
@@ -829,7 +932,7 @@ const TwoWindingsTransformerModificationDialog = ({
                         >
                             <Grid container spacing={2}>
                                 <BranchActiveReactivePowerMeasurementsForm equipmentToModify={twtToModify} />
-                                <ToBeEstimatedForm toBeEstimated={twtToModify?.toBeEstimated} />
+                                <ToBeEstimatedForm toBeEstimated={twtToModify?.toBeEstimated as ToBeEstimatedInfo} />
                             </Grid>
                         </Box>
                         <Box hidden={tabIndex !== TwoWindingsTransformerModificationDialogTab.RATIO_TAP_TAB} p={1}>
@@ -838,7 +941,7 @@ const TwoWindingsTransformerModificationDialog = ({
                                 currentNode={currentNode}
                                 currentRootNetworkUuid={currentRootNetworkUuid}
                                 voltageLevelOptions={voltageLevelOptions}
-                                previousValues={twtToModify}
+                                previousValues={twtToModify ?? undefined}
                                 editData={editData}
                                 isModification={true}
                             />
@@ -849,7 +952,7 @@ const TwoWindingsTransformerModificationDialog = ({
                                 currentNode={currentNode}
                                 currentRootNetworkUuid={currentRootNetworkUuid}
                                 voltageLevelOptions={voltageLevelOptions}
-                                previousValues={twtToModify}
+                                previousValues={twtToModify ?? undefined}
                                 editData={editData}
                                 isModification={true}
                             />
@@ -861,14 +964,4 @@ const TwoWindingsTransformerModificationDialog = ({
     );
 };
 
-TwoWindingsTransformerModificationDialog.propTypes = {
-    studyUuid: PropTypes.string,
-    defaultIdValue: PropTypes.string,
-    currentNode: PropTypes.object,
-    currentRootNetworkUuid: PropTypes.string,
-    isUpdate: PropTypes.bool,
-    editData: PropTypes.object,
-    editDataFetchStatus: PropTypes.string,
-};
-
 export default TwoWindingsTransformerModificationDialog;
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-steps.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-steps.tsx
index 14f3986940..bd1b7a8537 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-steps.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-steps.tsx
@@ -21,12 +21,12 @@ import TapChangerSteps from '../tap-changer-steps';
 import { parseIntData } from '../../../../dialog-utils';
 import { DndColumn, DndColumnType } from '@gridsuite/commons-ui';
 import { CurrentTreeNode } from 'components/graph/tree-node.type';
-import { PHASE_TAP, PhaseTapChangerData } from '../../two-windings-transformer.types';
+import { PHASE_TAP, PhaseTapChangerData, TwoWindingsTransformerEditData } from '../../two-windings-transformer.types';
 
 export interface PhaseTapChangerPaneStepsProps {
     disabled?: boolean;
     previousValues?: PhaseTapChangerData;
-    editData?: Record<string, unknown>;
+    editData?: TwoWindingsTransformerEditData;
     currentNode: CurrentTreeNode;
     isModification?: boolean;
 }
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts b/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
index 129c8b64bc..ee997ccdac 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
@@ -8,13 +8,23 @@ import { CommonBranchEquipmentInfos } from 'components/tooltips/equipment-popove
 import { Identifiable } from '@gridsuite/commons-ui';
 import { CurrentTreeNode } from 'components/graph/tree-node.type';
 import {
+    BUS_OR_BUSBAR_SECTION,
+    CONNECTED,
+    CONNECTION_DIRECTION,
+    CONNECTION_NAME,
+    CONNECTION_POSITION,
+    CONNECTIVITY_1,
+    CONNECTIVITY_2,
     CURRENT_LIMITER_REGULATING_VALUE,
+    ENABLE_OLG_MODIFICATION,
     ENABLED,
     EQUIPMENT,
     FLOW_SET_POINT_REGULATING_VALUE,
     HIGH_TAP_POSITION,
+    ID,
     LOAD_TAP_CHANGING_CAPABILITIES,
     LOW_TAP_POSITION,
+    OPERATIONAL_LIMITS_GROUPS,
     PHASE_TAP_CHANGER,
     RATIO_TAP_CHANGER,
     REGULATING,
@@ -26,6 +36,8 @@ import {
     REGULATION_TYPE,
     REGULATION_VALUE,
     SELECTED,
+    SELECTED_OPERATIONAL_LIMITS_GROUP_ID1,
+    SELECTED_OPERATIONAL_LIMITS_GROUP_ID2,
     STEPS,
     STEPS_ALPHA,
     STEPS_CONDUCTANCE,
@@ -44,6 +56,8 @@ import { ConnectablePositionFormInfos } from 'components/dialogs/connectivity/co
 import { CurrentLimitsData } from 'services/study/network-map.type';
 import { OperationalLimitsGroupFormSchema } from 'components/dialogs/limits/operational-limits-groups-types';
 import { Property } from '../common/properties/property-utils';
+import { AttributeModification, OperationalLimitsGroup } from 'services/network-modification-types';
+import { CharacteristicsValues } from './characteristics-pane/two-windings-transformer-characteristics-pane-utils';
 
 export const PHASE_TAP = 'dephasing';
 export const RATIO_TAP = 'ratio';
@@ -84,6 +98,8 @@ export interface TapChangerData {
     [TARGET_V]?: number | null;
     [EQUIPMENT]?: Record<string, unknown>;
     [VOLTAGE_LEVEL]?: Identifiable | null;
+    [CURRENT_LIMITER_REGULATING_VALUE]?: number;
+    [FLOW_SET_POINT_REGULATING_VALUE]?: number;
 }
 
 export interface RatioTapChangerData extends TapChangerData {}
@@ -100,7 +116,7 @@ export interface TapChangerPaneProps {
     currentRootNetworkUuid: UUID;
     voltageLevelOptions?: Identifiable[];
     previousValues?: TwoWindingsTransformerData;
-    editData?: Record<string, unknown>;
+    editData?: TwoWindingsTransformerEditData;
     isModification?: boolean;
 }
 
@@ -139,3 +155,76 @@ export interface TwoWindingsTransformerData extends CommonBranchEquipmentInfos {
     properties?: Property[] | null;
     [key: string]: unknown;
 }
+
+export interface ConnectivityFormData {
+    [VOLTAGE_LEVEL]?: { [ID]?: string };
+    [BUS_OR_BUSBAR_SECTION]?: { [ID]?: string };
+    [CONNECTION_NAME]?: string;
+    [CONNECTION_DIRECTION]?: string;
+    [CONNECTION_POSITION]?: number | null;
+    [CONNECTED]?: boolean | null;
+}
+
+export interface CharacteristicsFormData extends CharacteristicsValues {
+    [CONNECTIVITY_1]?: ConnectivityFormData;
+    [CONNECTIVITY_2]?: ConnectivityFormData;
+}
+
+export interface LimitsFormData {
+    [ENABLE_OLG_MODIFICATION]?: boolean;
+    [OPERATIONAL_LIMITS_GROUPS]?: OperationalLimitsGroupFormSchema[];
+    [SELECTED_OPERATIONAL_LIMITS_GROUP_ID1]?: string | null;
+    [SELECTED_OPERATIONAL_LIMITS_GROUP_ID2]?: string | null;
+}
+
+export interface TapChangerEditData {
+    [ENABLED]?: AttributeModification<boolean>;
+    [LOAD_TAP_CHANGING_CAPABILITIES]?: AttributeModification<boolean>;
+    [REGULATING]?: AttributeModification<boolean>;
+    [REGULATION_MODE]?: AttributeModification<string>;
+    [REGULATION_TYPE]?: AttributeModification<string>;
+    [REGULATION_SIDE]?: AttributeModification<string>;
+    [TARGET_V]?: AttributeModification<number>;
+    [TARGET_DEADBAND]?: AttributeModification<number>;
+    [LOW_TAP_POSITION]?: AttributeModification<number>;
+    [TAP_POSITION]?: AttributeModification<number>;
+    [STEPS]?: TapChangerStep[] | null;
+    regulationValue?: AttributeModification<number>;
+    terminalRefConnectableId?: AttributeModification<string>;
+    terminalRefConnectableType?: AttributeModification<string>;
+    terminalRefConnectableVlId?: AttributeModification<string>;
+}
+
+export interface TwoWindingsTransformerEditData {
+    uuid?: UUID;
+    equipmentId?: string;
+    equipmentName?: AttributeModification<string>;
+    r?: AttributeModification<number>;
+    x?: AttributeModification<number>;
+    g?: AttributeModification<number>;
+    b?: AttributeModification<number>;
+    ratedS?: AttributeModification<number>;
+    ratedU1?: AttributeModification<number>;
+    ratedU2?: AttributeModification<number>;
+    voltageLevelId1?: AttributeModification<string>;
+    voltageLevelId2?: AttributeModification<string>;
+    busOrBusbarSectionId1?: AttributeModification<string>;
+    busOrBusbarSectionId2?: AttributeModification<string>;
+    connectionName1?: AttributeModification<string>;
+    connectionName2?: AttributeModification<string>;
+    connectionDirection1?: AttributeModification<string>;
+    connectionDirection2?: AttributeModification<string>;
+    connectionPosition1?: AttributeModification<number>;
+    connectionPosition2?: AttributeModification<number>;
+    connected1?: AttributeModification<boolean>;
+    connected2?: AttributeModification<boolean>;
+    operationalLimitsGroups?: OperationalLimitsGroup[];
+    selectedOperationalLimitsGroupId1?: AttributeModification<string>;
+    selectedOperationalLimitsGroupId2?: AttributeModification<string>;
+    [ENABLE_OLG_MODIFICATION]?: boolean;
+    [RATIO_TAP_CHANGER]?: TapChangerEditData;
+    [PHASE_TAP_CHANGER]?: TapChangerEditData;
+    ratioTapChangerToBeEstimated?: AttributeModification<boolean>;
+    phaseTapChangerToBeEstimated?: AttributeModification<boolean>;
+    properties?: Property[] | null;
+}
diff --git a/src/components/utils/utils.ts b/src/components/utils/utils.ts
index 4ad76de94a..ac7da733bb 100644
--- a/src/components/utils/utils.ts
+++ b/src/components/utils/utils.ts
@@ -294,10 +294,12 @@ export function arrayFrom(start = 0.0, stop = 0.0, step = 1.0) {
     return Array.from({ length }, (_, index) => start + index * step);
 }
 
-export const addSelectedFieldToRows = <T>(rows: T[]): (T & { selected: boolean })[] => {
-    return rows?.map((row) => {
-        return { ...row, [SELECTED]: false };
-    });
+export const addSelectedFieldToRows = <T>(rows?: T[]): (T & { selected: boolean })[] => {
+    return (
+        rows?.map((row) => {
+            return { ...row, [SELECTED]: false };
+        }) ?? []
+    );
 };
 
 //Escapes regex special characters to avoid misinterpreting user prompts
diff --git a/src/services/network-modification-types.ts b/src/services/network-modification-types.ts
index 80924677f1..c05922a291 100644
--- a/src/services/network-modification-types.ts
+++ b/src/services/network-modification-types.ts
@@ -238,8 +238,8 @@ export interface TwoWindingsTransformerModificationInfo {
     ratedU1: AttributeModification<number> | null;
     ratedU2: AttributeModification<number> | null;
     operationalLimitsGroups: OperationalLimitsGroup[];
-    selectedLimitsGroup1: string;
-    selectedLimitsGroup2: string;
+    selectedLimitsGroup1: AttributeModification<string> | null;
+    selectedLimitsGroup2: AttributeModification<string> | null;
     [ENABLE_OLG_MODIFICATION]: boolean;
     voltageLevelId1?: string;
     busOrBusbarSectionId1?: string;
@@ -255,17 +255,17 @@ export interface TwoWindingsTransformerModificationInfo {
     connectionPosition2?: string | null;
     connected1?: boolean;
     connected2?: boolean;
-    properties: Property[];
-    p1MeasurementValue: number | null;
-    p1MeasurementValidity: boolean | null;
-    q1MeasurementValue: number | null;
-    q1MeasurementValidity: boolean | null;
-    p2MeasurementValue: number | null;
-    p2MeasurementValidity: boolean | null;
-    q2MeasurementValue: number | null;
-    q2MeasurementValidity: boolean | null;
-    ratioTapChangerToBeEstimated: boolean | null;
-    phaseTapChangerToBeEstimated: boolean | null;
+    properties: Property[] | null;
+    p1MeasurementValue?: number | null;
+    p1MeasurementValidity?: boolean | null;
+    q1MeasurementValue?: number | null;
+    q1MeasurementValidity?: boolean | null;
+    p2MeasurementValue?: number | null;
+    p2MeasurementValidity?: boolean | null;
+    q2MeasurementValue?: number | null;
+    q2MeasurementValidity?: boolean | null;
+    ratioTapChangerToBeEstimated?: boolean | null;
+    phaseTapChangerToBeEstimated?: boolean | null;
 }
 
 export interface OperationalLimitsGroup {

From 38bee8f672a24f137e7429671c03ba3fb0d3ec56 Mon Sep 17 00:00:00 2001
From: achour94 <berrahmaachour@gmail.com>
Date: Mon, 26 Jan 2026 15:45:16 +0100
Subject: [PATCH 5/9] Refactor to separate type from map and modification
 server

Signed-off-by: achour94 <berrahmaachour@gmail.com>
---
 .../dialogs/limits/limits-pane-utils.ts       |  15 +-
 ...dings-transformer-characteristics-pane.tsx |   4 +-
 ...o-windings-transformer-creation-dialog.tsx | 200 +++++++-----
 ...ndings-transformer-modification-dialog.tsx | 216 ++++++-------
 .../phase-tap-changer-pane-steps.tsx          |   7 +-
 .../phase-tap-changer-pane-utils.ts           |  22 +-
 .../phase-tap-changer-pane.tsx                |   8 +-
 .../ratio-tap-changer-pane-steps.tsx          |   4 +-
 .../ratio-tap-changer-pane-utils.ts           |  22 +-
 .../ratio-tap-changer-pane.tsx                |  14 +-
 .../tap-changer-pane/tap-changer-steps.tsx    |   4 +-
 .../two-windings-transformer.types.ts         | 306 +++++++++---------
 src/services/network-modification-types.ts    | 152 +++++++--
 src/services/study/network-modifications.ts   |  51 ++-
 14 files changed, 578 insertions(+), 447 deletions(-)

diff --git a/src/components/dialogs/limits/limits-pane-utils.ts b/src/components/dialogs/limits/limits-pane-utils.ts
index 883fa449be..a541503ec0 100644
--- a/src/components/dialogs/limits/limits-pane-utils.ts
+++ b/src/components/dialogs/limits/limits-pane-utils.ts
@@ -38,6 +38,7 @@ import {
     AttributeModification,
     CurrentLimits,
     OperationalLimitsGroup,
+    OperationalLimitsGroupModificationInfos,
     OperationType,
     TemporaryLimit,
 } from '../../../services/network-modification-types';
@@ -143,6 +144,8 @@ const limitsValidationSchemaCreation = (id: string) => {
     return { [id]: yup.object().shape(completeLimitsGroupSchema) };
 };
 
+export type LimitsFormSchema = yup.InferType<ReturnType<typeof limitsValidationSchemaCreation>[typeof LIMITS]>;
+
 export const getLimitsValidationSchema = (id: string = LIMITS) => {
     return limitsValidationSchemaCreation(id);
 };
@@ -163,7 +166,7 @@ export const getLimitsEmptyFormData = (isModification = true, id = LIMITS) => {
 };
 
 export const formatOpLimitGroupsToFormInfos = (
-    limitGroups?: OperationalLimitsGroup[]
+    limitGroups?: OperationalLimitsGroup[] | OperationalLimitsGroupModificationInfos[] | null
 ): OperationalLimitsGroupFormSchema[] => {
     if (!limitGroups) {
         return [];
@@ -171,23 +174,23 @@ export const formatOpLimitGroupsToFormInfos = (
 
     return limitGroups
         .filter(
-            (opLimitGroup: OperationalLimitsGroup) =>
+            (opLimitGroup: OperationalLimitsGroup | OperationalLimitsGroupModificationInfos) =>
                 opLimitGroup.modificationType !== LIMIT_SETS_MODIFICATION_TYPE.DELETE
         )
-        .map((opLimitGroup: OperationalLimitsGroup) => {
+        .map((opLimitGroup: OperationalLimitsGroup | OperationalLimitsGroupModificationInfos) => {
             return {
                 id: opLimitGroup.id + opLimitGroup.applicability,
                 name: opLimitGroup.id,
                 applicability: opLimitGroup.applicability,
                 limitsProperties: opLimitGroup.limitsProperties,
                 currentLimits: {
-                    permanentLimit: opLimitGroup.currentLimits.permanentLimit,
+                    permanentLimit: opLimitGroup?.currentLimits?.permanentLimit,
                     temporaryLimits: formatTemporaryLimitsModificationToFormSchema(
-                        opLimitGroup.currentLimits.temporaryLimits
+                        opLimitGroup?.currentLimits?.temporaryLimits as TemporaryLimit[]
                     ),
                 },
             };
-        });
+        }) as OperationalLimitsGroupFormSchema[];
 };
 
 export const getAllLimitsFormData = (
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.tsx
index 9a0364d930..7e69022540 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.tsx
@@ -13,11 +13,11 @@ import { B, CHARACTERISTICS, G, R, RATED_S, RATED_U1, RATED_U2, X } from 'compon
 import PropertiesForm from '../../common/properties/properties-form';
 import GridSection from '../../../commons/grid-section';
 import GridItem from '../../../commons/grid-item';
-import { TwoWindingsTransformerData } from '../two-windings-transformer.types';
+import { TwoWindingsTransformerMapInfos } from '../two-windings-transformer.types';
 
 export interface TwoWindingsTransformerCharacteristicsPaneProps {
     id?: string;
-    twtToModify?: TwoWindingsTransformerData | null;
+    twtToModify?: TwoWindingsTransformerMapInfos | null;
     isModification?: boolean;
 }
 
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
index 0413f8f892..381076c01a 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
@@ -78,11 +78,13 @@ import {
     getPhaseTapChangerEmptyFormData,
     getPhaseTapChangerFormData,
     getPhaseTapChangerValidationSchema,
+    PhaseTapChangerFormSchema,
 } from '../tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-utils';
 import {
     getRatioTapChangerEmptyFormData,
     getRatioTapChangerFormData,
     getRatioTapChangerValidationSchema,
+    RatioTapChangerFormSchema,
 } from '../tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane-utils';
 import TwoWindingsTransformerCreationDialogTabs from './two-windings-transformer-creation-dialog-tabs';
 import TwoWindingsTransformerCreationCharacteristicsPane from './characteristics-pane/two-windings-transformer-creation-characteristics-pane';
@@ -95,6 +97,7 @@ import {
     getAllLimitsFormData,
     getLimitsEmptyFormData,
     getLimitsValidationSchema,
+    LimitsFormSchema,
     sanitizeLimitsGroups,
 } from '../../../limits/limits-pane-utils';
 import { useOpenShortWaitFetching } from 'components/dialogs/commons/handle-modification-form';
@@ -114,14 +117,21 @@ import { UUID } from 'node:crypto';
 import { CurrentTreeNode } from 'components/graph/tree-node.type';
 import { FetchStatus } from 'services/utils.type';
 import {
-    CharacteristicsFormData,
-    ConnectivityFormData,
-    LimitsFormData,
-    RatioTapChangerData,
-    TapChangerData,
-    TwoWindingsTransformerData,
+    CharacteristicsCreationFormSchema,
+    ConnectivityFormSchema,
+    TapChangerMapInfos,
+    TwoWindingsTransformerMapInfos,
 } from '../two-windings-transformer.types';
-import { TwoWindingsTransformerCreationInfo } from 'services/network-modification-types';
+import {
+    OperationalLimitsGroupInfos,
+    PhaseTapChangerCreationInfos,
+    RatioTapChangerCreationInfos,
+    TapChangerCreationInfos,
+    TwoWindingsTransformerCreationInfo,
+} from 'services/network-modification-types';
+import { DeepNullable } from 'components/utils/ts-utils';
+import { CurrentLimitsData } from 'services/study/network-map.type';
+import { OperationalLimitsGroupFormSchema } from 'components/dialogs/limits/operational-limits-groups-types';
 /**
  * Dialog to create a two windings transformer in the network
  * @param studyUuid the study we are currently working on
@@ -156,20 +166,17 @@ const formSchema = yup
     .concat(creationPropertiesSchema)
     .required();
 
-export const PHASE_TAP = 'dephasing';
-export const RATIO_TAP = 'ratio';
+type BaseFormValues = yup.InferType<typeof formSchema>;
 
-export interface TwoWindingsTransformerCreationFormValues {
-    [EQUIPMENT_ID]: string;
-    [EQUIPMENT_NAME]?: string | null;
-    [CHARACTERISTICS]: CharacteristicsFormData;
-    [LIMITS]: LimitsFormData;
-    [RATIO_TAP_CHANGER]: TapChangerData;
-    [PHASE_TAP_CHANGER]: TapChangerData;
-}
+export type TwoWindingsTransformerCreationFormValues = BaseFormValues & {
+    [CHARACTERISTICS]: CharacteristicsCreationFormSchema;
+    [LIMITS]: LimitsFormSchema;
+    [RATIO_TAP_CHANGER]: RatioTapChangerFormSchema;
+    [PHASE_TAP_CHANGER]: PhaseTapChangerFormSchema;
+};
 
 export interface TwoWindingsTransformerCreationDialogProps {
-    editData?: TwoWindingsTransformerData;
+    editData?: TwoWindingsTransformerCreationInfo;
     studyUuid: UUID;
     currentNode: CurrentTreeNode;
     currentRootNetworkUuid: UUID;
@@ -190,9 +197,11 @@ const TwoWindingsTransformerCreationDialog = ({
     const currentNodeUuid = currentNode?.id;
     const { snackError } = useSnackMessage();
 
-    const formMethods = useForm<TwoWindingsTransformerCreationFormValues>({
+    const formMethods = useForm<DeepNullable<TwoWindingsTransformerCreationFormValues>>({
         defaultValues: emptyFormData,
-        resolver: yupResolver(formSchema) as unknown as Resolver<TwoWindingsTransformerCreationFormValues>,
+        resolver: yupResolver(formSchema) as unknown as Resolver<
+            DeepNullable<TwoWindingsTransformerCreationFormValues>
+        >,
     });
 
     const { reset } = formMethods;
@@ -202,7 +211,7 @@ const TwoWindingsTransformerCreationDialog = ({
     const [dialogWidth, setDialogWidth] = useState<Breakpoint>('xl');
 
     const computeRatioTapChangerRegulationMode = (
-        ratioTapChangerFormValues: RatioTapChangerData | null | undefined
+        ratioTapChangerFormValues?: RatioTapChangerCreationInfos | TapChangerMapInfos | null
     ) => {
         if (ratioTapChangerFormValues?.[REGULATING]) {
             return RATIO_REGULATION_MODES.VOLTAGE_REGULATION.id;
@@ -211,21 +220,24 @@ const TwoWindingsTransformerCreationDialog = ({
         }
     };
 
-    const getTapSideForEdit = (twt: TwoWindingsTransformerData, tap: TapChangerData | null | undefined) => {
+    const getTapSideForEdit = (
+        twt: TwoWindingsTransformerCreationInfo,
+        tap: TapChangerCreationInfos | null | undefined
+    ) => {
         if (tap?.terminalRefConnectableId !== twt.equipmentId) {
             return null;
         }
         return tap?.terminalRefConnectableVlId === twt?.voltageLevelId1 ? SIDE.SIDE1.id : SIDE.SIDE2.id;
     };
 
-    const getTapSideForCopy = (twt: TwoWindingsTransformerData, tap: TapChangerData | null | undefined) => {
+    const getTapSideForCopy = (twt: TwoWindingsTransformerMapInfos, tap: TapChangerMapInfos | null | undefined) => {
         if (tap?.regulatingTerminalConnectableId !== twt.id) {
             return null;
         }
-        return tap?.terminalRefConnectableVlId === twt?.voltageLevelId1 ? SIDE.SIDE1.id : SIDE.SIDE2.id;
+        return tap?.regulatingTerminalVlId === twt?.voltageLevelId1 ? SIDE.SIDE1.id : SIDE.SIDE2.id;
     };
 
-    const getRegulationTypeForEdit = (twt: TwoWindingsTransformerData, tap: TapChangerData | null | undefined) => {
+    const getRegulationTypeForEdit = (twt: TwoWindingsTransformerCreationInfo, tap: TapChangerCreationInfos | null) => {
         if (tap?.terminalRefConnectableId == null) {
             return null;
         }
@@ -234,7 +246,10 @@ const TwoWindingsTransformerCreationDialog = ({
             : REGULATION_TYPES.DISTANT.id;
     };
 
-    const getRegulationTypeForCopy = (twt: TwoWindingsTransformerData, tap: TapChangerData | null | undefined) => {
+    const getRegulationTypeForCopy = (
+        twt: TwoWindingsTransformerMapInfos,
+        tap: TapChangerMapInfos | null | undefined
+    ) => {
         if (tap?.regulatingTerminalConnectableId == null) {
             return null;
         }
@@ -242,7 +257,7 @@ const TwoWindingsTransformerCreationDialog = ({
     };
 
     const fromEditDataToFormValues = useCallback(
-        (twt: TwoWindingsTransformerData) => {
+        (twt: TwoWindingsTransformerCreationInfo) => {
             reset({
                 [EQUIPMENT_ID]: twt.equipmentId,
                 [EQUIPMENT_NAME]: twt.equipmentName,
@@ -259,7 +274,10 @@ const TwoWindingsTransformerCreationDialog = ({
                             busbarSectionId: twt.busOrBusbarSectionId1,
                             connectionDirection: twt.connectionDirection1 ?? null,
                             connectionName: twt.connectionName1,
-                            connectionPosition: twt.connectionPosition1,
+                            connectionPosition:
+                                twt.connectionPosition1 !== null && twt.connectionPosition1 !== undefined
+                                    ? Number(twt.connectionPosition1)
+                                    : null,
                             voltageLevelId: twt.voltageLevelId1,
                             terminalConnected: twt.connected1,
                         },
@@ -270,7 +288,10 @@ const TwoWindingsTransformerCreationDialog = ({
                             busbarSectionId: twt.busOrBusbarSectionId2,
                             connectionDirection: twt.connectionDirection2 ?? null,
                             connectionName: twt.connectionName2,
-                            connectionPosition: twt.connectionPosition2,
+                            connectionPosition:
+                                twt.connectionPosition2 !== null && twt.connectionPosition2 !== undefined
+                                    ? Number(twt.connectionPosition2)
+                                    : null,
                             voltageLevelId: twt.voltageLevelId2,
                             terminalConnected: twt.connected2,
                         },
@@ -278,11 +299,26 @@ const TwoWindingsTransformerCreationDialog = ({
                     ),
                 }),
                 ...getAllLimitsFormData(
-                    twt?.operationalLimitsGroups?.map(({ id, ...baseData }) => ({
-                        ...baseData,
-                        name: id,
-                        id: id + baseData.applicability,
-                    })),
+                    twt?.operationalLimitsGroups
+                        ?.filter(
+                            (group): group is OperationalLimitsGroupInfos & { id: string; applicability: string } =>
+                                group.id != null && group.applicability != null
+                        )
+                        .map(({ id, currentLimits, applicability, limitsProperties }) => ({
+                            id: id + applicability,
+                            name: id,
+                            applicability,
+                            limitsProperties: limitsProperties ?? undefined,
+                            currentLimits: {
+                                permanentLimit: currentLimits?.permanentLimit ?? null,
+                                temporaryLimits:
+                                    currentLimits?.temporaryLimits?.map((tl) => ({
+                                        name: tl.name ?? undefined,
+                                        value: tl.value ?? undefined,
+                                        acceptableDuration: tl.acceptableDuration ?? undefined,
+                                    })) ?? [],
+                            },
+                        })),
                     twt?.selectedOperationalLimitsGroupId1 ?? null,
                     twt?.selectedOperationalLimitsGroupId2 ?? null
                 ),
@@ -306,9 +342,9 @@ const TwoWindingsTransformerCreationDialog = ({
                     highTapPosition: computeHighTapPosition(twt?.[PHASE_TAP_CHANGER]?.[STEPS] ?? []),
                     tapPosition: twt?.[PHASE_TAP_CHANGER]?.[TAP_POSITION],
                     steps: addSelectedFieldToRows(twt?.[PHASE_TAP_CHANGER]?.[STEPS] ?? []),
-                    equipmentId: twt?.[PHASE_TAP_CHANGER]?.terminalRefConnectableId,
-                    equipmentType: twt?.[PHASE_TAP_CHANGER]?.terminalRefConnectableType,
-                    voltageLevelId: twt?.[PHASE_TAP_CHANGER]?.terminalRefConnectableVlId,
+                    equipmentId: twt?.[PHASE_TAP_CHANGER]?.terminalRefConnectableId ?? undefined,
+                    equipmentType: twt?.[PHASE_TAP_CHANGER]?.terminalRefConnectableType ?? undefined,
+                    voltageLevelId: twt?.[PHASE_TAP_CHANGER]?.terminalRefConnectableVlId ?? undefined,
                 }),
                 ...getRatioTapChangerFormData({
                     enabled: twt?.[RATIO_TAP_CHANGER]?.[TAP_POSITION] !== undefined,
@@ -322,18 +358,18 @@ const TwoWindingsTransformerCreationDialog = ({
                     highTapPosition: computeHighTapPosition(twt?.[RATIO_TAP_CHANGER]?.[STEPS] ?? []),
                     tapPosition: twt?.[RATIO_TAP_CHANGER]?.[TAP_POSITION],
                     steps: addSelectedFieldToRows(twt?.[RATIO_TAP_CHANGER]?.[STEPS] ?? []),
-                    equipmentId: twt?.[RATIO_TAP_CHANGER]?.terminalRefConnectableId,
-                    equipmentType: twt?.[RATIO_TAP_CHANGER]?.terminalRefConnectableType,
-                    voltageLevelId: twt?.[RATIO_TAP_CHANGER]?.terminalRefConnectableVlId,
+                    equipmentId: twt?.[RATIO_TAP_CHANGER]?.terminalRefConnectableId ?? undefined,
+                    equipmentType: twt?.[RATIO_TAP_CHANGER]?.terminalRefConnectableType ?? undefined,
+                    voltageLevelId: twt?.[RATIO_TAP_CHANGER]?.terminalRefConnectableVlId ?? undefined,
                 }),
                 ...getPropertiesFromModification(twt.properties),
-            });
+            } as DeepNullable<TwoWindingsTransformerCreationFormValues>);
         },
         [reset]
     );
 
     const fromSearchCopyToFormValues = useCallback(
-        (twt: TwoWindingsTransformerData) => {
+        (twt: TwoWindingsTransformerMapInfos) => {
             reset(
                 {
                     [EQUIPMENT_ID]: twt.id + '(1)',
@@ -366,7 +402,7 @@ const TwoWindingsTransformerCreationDialog = ({
                         ),
                     }),
                     ...getAllLimitsFormData(
-                        formatCompleteCurrentLimit(twt.currentLimits ?? []),
+                        formatCompleteCurrentLimit(twt.currentLimits as CurrentLimitsData[]),
                         twt.selectedOperationalLimitsGroupId1 ?? null,
                         twt.selectedOperationalLimitsGroupId2 ?? null
                     ),
@@ -386,7 +422,7 @@ const TwoWindingsTransformerCreationDialog = ({
                         steps: addSelectedFieldToRows(twt?.[RATIO_TAP_CHANGER]?.[STEPS] ?? []),
                         equipmentId: twt?.[RATIO_TAP_CHANGER]?.regulatingTerminalConnectableId,
                         equipmentType: twt?.[RATIO_TAP_CHANGER]?.regulatingTerminalConnectableType,
-                        voltageLevelId: twt?.[RATIO_TAP_CHANGER]?.terminalRefConnectableVlId,
+                        voltageLevelId: twt?.[RATIO_TAP_CHANGER]?.regulatingTerminalVlId,
                     }),
                     ...getPhaseTapChangerFormData({
                         enabled: twt?.[PHASE_TAP_CHANGER]?.[TAP_POSITION] !== undefined,
@@ -411,12 +447,12 @@ const TwoWindingsTransformerCreationDialog = ({
                         highTapPosition: computeHighTapPosition(twt?.[PHASE_TAP_CHANGER]?.[STEPS] ?? []),
                         tapPosition: twt?.[PHASE_TAP_CHANGER]?.[TAP_POSITION],
                         steps: addSelectedFieldToRows(twt?.[PHASE_TAP_CHANGER]?.[STEPS] ?? []),
-                        voltageLevelId: twt?.[PHASE_TAP_CHANGER]?.terminalRefConnectableVlId,
+                        voltageLevelId: twt?.[PHASE_TAP_CHANGER]?.regulatingTerminalVlId,
                         equipmentId: twt?.[PHASE_TAP_CHANGER]?.regulatingTerminalConnectableId,
                         equipmentType: twt?.[PHASE_TAP_CHANGER]?.regulatingTerminalConnectableType,
                     }),
                     ...copyEquipmentPropertiesForCreation(twt as Equipment),
-                },
+                } as DeepNullable<TwoWindingsTransformerCreationFormValues>,
                 { keepDefaultValues: true }
             );
         },
@@ -443,18 +479,18 @@ const TwoWindingsTransformerCreationDialog = ({
         </Grid>
     );
 
-    const computeRatioTapChangerRegulating = (ratioTapChangerFormValues: TapChangerData) => {
+    const computeRatioTapChangerRegulating = (ratioTapChangerFormValues: RatioTapChangerFormSchema) => {
         return ratioTapChangerFormValues?.[REGULATION_MODE] === RATIO_REGULATION_MODES.VOLTAGE_REGULATION.id;
     };
 
-    const computePhaseTapChangerRegulating = (phaseTapChangerFormValues: TapChangerData) => {
+    const computePhaseTapChangerRegulating = (phaseTapChangerFormValues: PhaseTapChangerFormSchema) => {
         return (
             phaseTapChangerFormValues?.[REGULATION_MODE] === PHASE_REGULATION_MODES.CURRENT_LIMITER.id ||
             phaseTapChangerFormValues?.[REGULATION_MODE] === PHASE_REGULATION_MODES.ACTIVE_POWER_CONTROL.id
         );
     };
 
-    const computeRegulationModeValue = (phaseTapChangerFormValues: TapChangerData) => {
+    const computeRegulationModeValue = (phaseTapChangerFormValues: PhaseTapChangerFormSchema) => {
         if (phaseTapChangerFormValues?.[REGULATION_MODE] === PHASE_REGULATION_MODES.OFF.id) {
             return null;
         }
@@ -462,7 +498,7 @@ const TwoWindingsTransformerCreationDialog = ({
         return phaseTapChangerFormValues?.[REGULATION_MODE];
     };
 
-    const computePhaseTapChangerRegulationValue = (phaseTapChangerFormValues: TapChangerData) => {
+    const computePhaseTapChangerRegulationValue = (phaseTapChangerFormValues: PhaseTapChangerFormSchema) => {
         switch (phaseTapChangerFormValues?.[REGULATION_MODE]) {
             case PHASE_REGULATION_MODES.ACTIVE_POWER_CONTROL.id:
                 return phaseTapChangerFormValues?.[FLOW_SET_POINT_REGULATING_VALUE] ?? undefined;
@@ -473,7 +509,7 @@ const TwoWindingsTransformerCreationDialog = ({
         }
     };
 
-    const computeRegulatingTerminalType = (tapChangerValue: TapChangerData) => {
+    const computeRegulatingTerminalType = (tapChangerValue: RatioTapChangerFormSchema | PhaseTapChangerFormSchema) => {
         if (tapChangerValue?.[EQUIPMENT]?.type) {
             return tapChangerValue?.[EQUIPMENT]?.type;
         }
@@ -486,9 +522,9 @@ const TwoWindingsTransformerCreationDialog = ({
     };
 
     const computeTapTerminalVlId = (
-        tapChangerValue: TapChangerData,
-        connectivity1: ConnectivityFormData | undefined,
-        connectivity2: ConnectivityFormData | undefined
+        tapChangerValue: RatioTapChangerFormSchema | PhaseTapChangerFormSchema,
+        connectivity1: ConnectivityFormSchema,
+        connectivity2: ConnectivityFormSchema
     ) => {
         if (tapChangerValue?.[REGULATION_TYPE] === REGULATION_TYPES.LOCAL.id) {
             if (tapChangerValue?.[REGULATION_SIDE] === SIDE.SIDE1.id) {
@@ -501,7 +537,10 @@ const TwoWindingsTransformerCreationDialog = ({
         }
     };
 
-    const computeRegulatingTerminalId = (tapChangerValue: TapChangerData, currentTwtId: string) => {
+    const computeRegulatingTerminalId = (
+        tapChangerValue: RatioTapChangerFormSchema | PhaseTapChangerFormSchema,
+        currentTwtId: string
+    ) => {
         if (tapChangerValue?.[REGULATION_TYPE] === REGULATION_TYPES.LOCAL.id) {
             return currentTwtId;
         } else {
@@ -524,7 +563,7 @@ const TwoWindingsTransformerCreationDialog = ({
                 const ratioTapChangerFormValues = twt[RATIO_TAP_CHANGER];
                 const hasLoadTapCapabilities = ratioTapChangerFormValues[LOAD_TAP_CHANGING_CAPABILITIES];
 
-                const getValueOrDefault = <K extends keyof TapChangerData>(key: K): TapChangerData[K] | null => {
+                const getValueOrDefault = (key: keyof RatioTapChangerFormSchema) => {
                     return hasLoadTapCapabilities ? ratioTapChangerFormValues[key] : null;
                 };
 
@@ -546,7 +585,6 @@ const TwoWindingsTransformerCreationDialog = ({
                         : null,
                     targetV: getValueOrDefault(TARGET_V),
                     targetDeadband: getValueOrDefault(TARGET_DEADBAND),
-                    regulationType: getValueOrDefault(REGULATION_TYPE),
                 };
             }
             let phaseTap = undefined;
@@ -571,38 +609,40 @@ const TwoWindingsTransformerCreationDialog = ({
             createTwoWindingsTransformer({
                 studyUuid: studyUuid,
                 nodeUuid: currentNodeUuid,
-                twoWindingsTransformerId: twt[EQUIPMENT_ID],
-                twoWindingsTransformerName: sanitizeString(twt[EQUIPMENT_NAME]),
+                equipmentId: twt[EQUIPMENT_ID],
+                equipmentName: sanitizeString(twt[EQUIPMENT_NAME]),
                 r: characteristics[R],
-                x: characteristics[X],
-                g: characteristics[G],
-                b: characteristics[B],
-                ratedS: characteristics[RATED_S] ?? '',
-                ratedU1: characteristics[RATED_U1],
-                ratedU2: characteristics[RATED_U2],
-                limitsGroups: sanitizeLimitsGroups(limits[OPERATIONAL_LIMITS_GROUPS] ?? []),
-                selectedLimitsGroup1: limits[SELECTED_OPERATIONAL_LIMITS_GROUP_ID1],
-                selectedLimitsGroup2: limits[SELECTED_OPERATIONAL_LIMITS_GROUP_ID2],
-                voltageLevelId1: characteristics[CONNECTIVITY_1]?.[VOLTAGE_LEVEL]?.[ID],
-                busOrBusbarSectionId1: characteristics[CONNECTIVITY_1]?.[BUS_OR_BUSBAR_SECTION]?.[ID],
-                voltageLevelId2: characteristics[CONNECTIVITY_2]?.[VOLTAGE_LEVEL]?.[ID],
-                busOrBusbarSectionId2: characteristics[CONNECTIVITY_2]?.[BUS_OR_BUSBAR_SECTION]?.[ID],
-                ratioTapChanger: ratioTap,
-                phaseTapChanger: phaseTap,
+                x: Number(characteristics[X]),
+                g: Number(characteristics[G]),
+                b: Number(characteristics[B]),
+                ratedS: characteristics[RATED_S],
+                ratedU1: Number(characteristics[RATED_U1]),
+                ratedU2: Number(characteristics[RATED_U2]),
+                operationalLimitsGroups: sanitizeLimitsGroups(
+                    limits[OPERATIONAL_LIMITS_GROUPS] as OperationalLimitsGroupFormSchema[]
+                ) as OperationalLimitsGroupInfos[],
+                selectedOperationalLimitsGroupId1: String(limits[SELECTED_OPERATIONAL_LIMITS_GROUP_ID1]),
+                selectedOperationalLimitsGroupId2: String(limits[SELECTED_OPERATIONAL_LIMITS_GROUP_ID2]),
+                voltageLevelId1: String(characteristics[CONNECTIVITY_1]?.[VOLTAGE_LEVEL]?.[ID]),
+                busOrBusbarSectionId1: String(characteristics[CONNECTIVITY_1]?.[BUS_OR_BUSBAR_SECTION]?.[ID]),
+                voltageLevelId2: String(characteristics[CONNECTIVITY_2]?.[VOLTAGE_LEVEL]?.[ID]),
+                busOrBusbarSectionId2: String(characteristics[CONNECTIVITY_2]?.[BUS_OR_BUSBAR_SECTION]?.[ID]),
+                ratioTapChanger: (ratioTap as RatioTapChangerCreationInfos) ?? null,
+                phaseTapChanger: (phaseTap as PhaseTapChangerCreationInfos) ?? null,
                 isUpdate: !!editData,
-                modificationUuid: editData ? editData.uuid : undefined,
+                uuid: editData ? editData.uuid : '',
                 connectionName1: sanitizeString(characteristics[CONNECTIVITY_1]?.[CONNECTION_NAME]),
                 connectionDirection1:
                     characteristics[CONNECTIVITY_1]?.[CONNECTION_DIRECTION] ?? UNDEFINED_CONNECTION_DIRECTION,
                 connectionName2: sanitizeString(characteristics[CONNECTIVITY_2]?.[CONNECTION_NAME]),
                 connectionDirection2:
                     characteristics[CONNECTIVITY_2]?.[CONNECTION_DIRECTION] ?? UNDEFINED_CONNECTION_DIRECTION,
-                connectionPosition1: characteristics[CONNECTIVITY_1]?.[CONNECTION_POSITION] ?? null,
-                connectionPosition2: characteristics[CONNECTIVITY_2]?.[CONNECTION_POSITION] ?? null,
-                connected1: characteristics[CONNECTIVITY_1]?.[CONNECTED] ?? null,
-                connected2: characteristics[CONNECTIVITY_2]?.[CONNECTED] ?? null,
+                connectionPosition1: String(characteristics[CONNECTIVITY_1]?.[CONNECTION_POSITION]),
+                connectionPosition2: String(characteristics[CONNECTIVITY_2]?.[CONNECTION_POSITION]),
+                connected1: Boolean(characteristics[CONNECTIVITY_1]?.[CONNECTED]),
+                connected2: Boolean(characteristics[CONNECTIVITY_2]?.[CONNECTED]),
                 properties: toModificationProperties(twt as unknown as Record<string, unknown>),
-            } as TwoWindingsTransformerCreationInfo).catch((error) => {
+            }).catch((error) => {
                 snackWithFallback(snackError, error, { headerId: 'TwoWindingsTransformerCreationError' });
             });
         },
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
index 1957809e15..1921fc99ec 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
@@ -85,7 +85,6 @@ import { ModificationDialog } from '../../../commons/modificationDialog';
 import TwoWindingsTransformerModificationDialogTabs from './two-windings-transformer-modification-dialog-tabs';
 import TwoWindingsTransformerCharacteristicsPane from '../characteristics-pane/two-windings-transformer-characteristics-pane';
 import {
-    CharacteristicsValues,
     getCharacteristicsEmptyFormData,
     getCharacteristicsFormData,
     getCharacteristicsValidationSchema,
@@ -99,6 +98,7 @@ import {
     getLimitsEmptyFormData,
     getLimitsValidationSchema,
     getOpLimitsGroupInfosFromBranchModification,
+    LimitsFormSchema,
 } from '../../../limits/limits-pane-utils';
 import { useOpenShortWaitFetching } from 'components/dialogs/commons/handle-modification-form';
 import TwoWindingsTransformerModificationDialogHeader from './two-windings-transformer-modification-dialog-header';
@@ -116,6 +116,7 @@ import {
     getPhaseTapChangerEmptyFormData,
     getPhaseTapChangerFormData,
     getPhaseTapChangerValidationSchema,
+    PhaseTapChangerFormSchema,
 } from '../tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-utils';
 import { modifyTwoWindingsTransformer } from '../../../../../services/study/network-modifications';
 import {
@@ -123,6 +124,7 @@ import {
     getRatioTapChangerEmptyFormData,
     getRatioTapChangerFormData,
     getRatioTapChangerValidationSchema,
+    RatioTapChangerFormSchema,
 } from '../tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane-utils';
 import { isNodeBuilt } from 'components/graph/util/model-functions';
 import RatioTapChangerPane from '../tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane';
@@ -159,49 +161,22 @@ import { useFormWithDirtyTracking } from 'components/dialogs/commons/use-form-wi
 import { UUID } from 'node:crypto';
 import { CurrentTreeNode } from 'components/graph/tree-node.type';
 import {
-    TwoWindingsTransformerData,
     TapChangerStep,
-    ConnectivityFormData,
-    LimitsFormData,
-    TapChangerData,
-    TwoWindingsTransformerEditData,
-    TapChangerEditData,
+    ConnectivityFormSchema,
+    CharacteristicsFormSchema,
+    StateEstimationFormSchema,
+    TwoWindingsTransformerMapInfos,
 } from '../two-windings-transformer.types';
 import { LineModificationFormInfos } from '../../line/modification/line-modification-type';
-import { BranchInfos } from 'services/study/network-map.type';
+import { BranchInfos, CurrentLimitsData } from 'services/study/network-map.type';
 import { ToBeEstimatedInfo } from './2wt-to-be-estimated/to-be-estimated.type';
-
-interface MeasurementFormData {
-    [VALUE]?: number | null;
-    [VALIDITY]?: boolean | null;
-}
-
-interface ToBeEstimatedFormData {
-    [RATIO_TAP_CHANGER_STATUS]?: boolean | null;
-    [PHASE_TAP_CHANGER_STATUS]?: boolean | null;
-}
-
-interface StateEstimationFormData {
-    [MEASUREMENT_P1]?: MeasurementFormData;
-    [MEASUREMENT_Q1]?: MeasurementFormData;
-    [MEASUREMENT_P2]?: MeasurementFormData;
-    [MEASUREMENT_Q2]?: MeasurementFormData;
-    [TO_BE_ESTIMATED]?: ToBeEstimatedFormData;
-}
-
-interface TwoWindingsTransformerModificationFormData {
-    [EQUIPMENT_NAME]?: string | null;
-    [CONNECTIVITY]?: {
-        [CONNECTIVITY_1]?: ConnectivityFormData;
-        [CONNECTIVITY_2]?: ConnectivityFormData;
-    };
-    [CHARACTERISTICS]?: CharacteristicsValues;
-    [LIMITS]?: LimitsFormData;
-    [STATE_ESTIMATION]?: StateEstimationFormData;
-    [RATIO_TAP_CHANGER]?: TapChangerData;
-    [PHASE_TAP_CHANGER]?: TapChangerData;
-    [ADDITIONAL_PROPERTIES]?: Record<string, unknown>[];
-}
+import {
+    OperationalLimitsGroupModificationInfos,
+    PhaseTapChangerModificationInfos,
+    RatioTapChangerModificationInfos,
+    TwoWindingsTransformerModificationInfo,
+} from 'services/network-modification-types';
+import { OperationalLimitsGroupFormSchema } from 'components/dialogs/limits/operational-limits-groups-types';
 
 export interface TwoWindingsTransformerModificationDialogProps {
     studyUuid: UUID;
@@ -209,7 +184,7 @@ export interface TwoWindingsTransformerModificationDialogProps {
     currentNode: CurrentTreeNode;
     currentRootNetworkUuid: UUID;
     isUpdate?: boolean;
-    editData?: TwoWindingsTransformerEditData;
+    editData?: TwoWindingsTransformerModificationInfo;
     editDataFetchStatus?: (typeof FetchStatus)[keyof typeof FetchStatus];
     onClose?: () => void;
     onValidated?: () => void;
@@ -240,6 +215,19 @@ const formSchema = yup
     .concat(modificationPropertiesSchema)
     .required();
 
+type BaseFormValues = yup.InferType<typeof formSchema>;
+
+export type TwoWindingsTransformerModificationFormValues = BaseFormValues & {
+    [CONNECTIVITY]: {
+        [CONNECTIVITY_1]: ConnectivityFormSchema;
+        [CONNECTIVITY_2]: ConnectivityFormSchema;
+    };
+    [CHARACTERISTICS]: CharacteristicsFormSchema;
+    [LIMITS]: LimitsFormSchema;
+    [RATIO_TAP_CHANGER]: RatioTapChangerFormSchema;
+    [PHASE_TAP_CHANGER]: PhaseTapChangerFormSchema;
+    [STATE_ESTIMATION]: StateEstimationFormSchema;
+};
 /**
  * Dialog to modify a two windings transformer in the network
  * @param studyUuid the study we are currently working on
@@ -269,18 +257,18 @@ const TwoWindingsTransformerModificationDialog = ({
     const [dataFetchStatus, setDataFetchStatus] = useState<(typeof FetchStatus)[keyof typeof FetchStatus]>(
         FetchStatus.IDLE
     );
-    const [twtToModify, setTwtToModify] = useState<TwoWindingsTransformerData | null>(null);
+    const [twtToModify, setTwtToModify] = useState<TwoWindingsTransformerMapInfos | null>(null);
     const intl = useIntl();
 
-    const formMethods = useFormWithDirtyTracking<TwoWindingsTransformerModificationFormData>({
+    const formMethods = useFormWithDirtyTracking<TwoWindingsTransformerModificationFormValues>({
         defaultValues: emptyFormData,
-        resolver: yupResolver(formSchema) as unknown as Resolver<TwoWindingsTransformerModificationFormData>,
+        resolver: yupResolver(formSchema) as unknown as Resolver<TwoWindingsTransformerModificationFormValues>,
     });
     const { reset, getValues } = formMethods;
     const voltageLevelOptions = useVoltageLevelsListInfos(studyUuid, currentNodeUuid, currentRootNetworkUuid);
 
     const computeRatioTapChangerRegulationMode = (
-        ratioTapChangerFormValues: TapChangerEditData | undefined
+        ratioTapChangerFormValues: RatioTapChangerModificationInfos | null
     ): string | null => {
         if (ratioTapChangerFormValues?.[REGULATING]?.value == null) {
             return null;
@@ -293,21 +281,17 @@ const TwoWindingsTransformerModificationDialog = ({
     };
 
     const fromEditDataToFormValues = useCallback(
-        (twtModification: TwoWindingsTransformerEditData) => {
+        (twtModification: TwoWindingsTransformerModificationInfo) => {
             if (twtModification?.equipmentId) {
                 setSelectedId(twtModification.equipmentId);
             }
+            console.log('TWT Edit data:', twtModification);
+            console.log('TWT Connectivity 1:', createConnectivityData(twtModification, 1));
             reset({
                 [EQUIPMENT_NAME]: twtModification.equipmentName?.value,
                 [CONNECTIVITY]: {
-                    [CONNECTIVITY_1]: getConnectivityFormData(
-                        createConnectivityData(twtModification, 1),
-                        CONNECTIVITY_1
-                    ),
-                    [CONNECTIVITY_2]: getConnectivityFormData(
-                        createConnectivityData(twtModification, 2),
-                        CONNECTIVITY_2
-                    ),
+                    ...getConnectivityFormData(createConnectivityData(twtModification, 1), CONNECTIVITY_1),
+                    ...getConnectivityFormData(createConnectivityData(twtModification, 2), CONNECTIVITY_2),
                 },
                 ...getCharacteristicsFormData({
                     r: twtModification.r?.value,
@@ -380,12 +364,12 @@ const TwoWindingsTransformerModificationDialog = ({
         }
     }, [fromEditDataToFormValues, editData]);
 
-    const computeRatioTapChangerRegulating = (ratioTapChangerFormValues: TapChangerData): boolean => {
+    const computeRatioTapChangerRegulating = (ratioTapChangerFormValues: RatioTapChangerFormSchema): boolean => {
         return ratioTapChangerFormValues?.[REGULATION_MODE] === RATIO_REGULATION_MODES.VOLTAGE_REGULATION.id;
     };
 
     const computePhaseTapChangerRegulationValue = (
-        phaseTapChangerFormValues: TapChangerData,
+        phaseTapChangerFormValues: PhaseTapChangerFormSchema,
         currentRegulationMode?: string
     ): number | undefined => {
         const regulationMode = phaseTapChangerFormValues?.[REGULATION_MODE] || currentRegulationMode;
@@ -403,8 +387,8 @@ const TwoWindingsTransformerModificationDialog = ({
     const fillPhaseTapChangerRegulationAttributes = useCallback(
         (
             phaseTap: Record<string, unknown>,
-            phaseTapChangerFormValues: TapChangerData,
-            twtToModify: TwoWindingsTransformerData | null
+            phaseTapChangerFormValues: PhaseTapChangerFormSchema,
+            twtToModify: TwoWindingsTransformerMapInfos | null
         ) => {
             const regulationMode =
                 phaseTapChangerFormValues?.[REGULATION_MODE] ??
@@ -442,8 +426,8 @@ const TwoWindingsTransformerModificationDialog = ({
     const fillRatioTapChangerRegulationAttributes = useCallback(
         (
             ratioTap: Record<string, unknown>,
-            ratioTapChangerFormValues: TapChangerData,
-            twtToModify: TwoWindingsTransformerData | null
+            ratioTapChangerFormValues: RatioTapChangerFormSchema,
+            twtToModify: TwoWindingsTransformerMapInfos | null
         ) => {
             const hasLoadTapChangingCapabilities =
                 ratioTapChangerFormValues?.[LOAD_TAP_CHANGING_CAPABILITIES] ??
@@ -479,7 +463,7 @@ const TwoWindingsTransformerModificationDialog = ({
     );
 
     const computeRatioTapForSubmit = useCallback(
-        (twt: TwoWindingsTransformerModificationFormData): Record<string, unknown> => {
+        (twt: TwoWindingsTransformerModificationFormValues): Record<string, unknown> => {
             let ratioTap: Record<string, unknown>;
             const ratioTapChangerFormValues = twt[RATIO_TAP_CHANGER];
             const enableRatioTapChanger =
@@ -490,7 +474,7 @@ const TwoWindingsTransformerModificationDialog = ({
                 isNodeBuilt(currentNode) && editData?.[RATIO_TAP_CHANGER]?.[STEPS]
                     ? true
                     : !compareStepsWithPreviousValues(
-                          ratioTapChangerFormValues?.[STEPS] ?? [],
+                          ratioTapChangerFormValues?.[STEPS] as TapChangerStep[],
                           twtToModify?.[RATIO_TAP_CHANGER]?.[STEPS]
                       );
             const ratioTapChangerSteps = !areRatioStepsModified ? null : ratioTapChangerFormValues?.[STEPS];
@@ -516,7 +500,7 @@ const TwoWindingsTransformerModificationDialog = ({
     );
 
     const computePhaseTapForSubmit = useCallback(
-        (twt: TwoWindingsTransformerModificationFormData): Record<string, unknown> => {
+        (twt: TwoWindingsTransformerModificationFormValues): Record<string, unknown> => {
             let phaseTap: Record<string, unknown>;
             const phaseTapChangerFormValues = twt[PHASE_TAP_CHANGER];
             const enablePhaseTapChanger =
@@ -527,7 +511,7 @@ const TwoWindingsTransformerModificationDialog = ({
                 isNodeBuilt(currentNode) && editData?.[PHASE_TAP_CHANGER]?.[STEPS]
                     ? true
                     : !compareStepsWithPreviousValues(
-                          phaseTapChangerFormValues?.[STEPS] ?? [],
+                          phaseTapChangerFormValues?.[STEPS] as TapChangerStep[],
                           twtToModify?.[PHASE_TAP_CHANGER]?.[STEPS]
                       );
             const phaseTapChangerSteps = !arePhaseStepsModified ? null : phaseTapChangerFormValues?.[STEPS];
@@ -560,7 +544,7 @@ const TwoWindingsTransformerModificationDialog = ({
     );
 
     const onSubmit = useCallback(
-        (twt: TwoWindingsTransformerModificationFormData) => {
+        (twt: TwoWindingsTransformerModificationFormValues) => {
             const connectivity1 = twt[CONNECTIVITY]?.[CONNECTIVITY_1];
             const connectivity2 = twt[CONNECTIVITY]?.[CONNECTIVITY_2];
             const characteristics = twt[CHARACTERISTICS];
@@ -571,8 +555,8 @@ const TwoWindingsTransformerModificationDialog = ({
                 studyUuid: studyUuid,
                 nodeUuid: currentNodeUuid,
                 modificationUuid: editData?.uuid,
-                twoWindingsTransformerId: selectedId ?? '',
-                twoWindingsTransformerName: toModificationOperation(sanitizeString(twt[EQUIPMENT_NAME])),
+                equipmentId: selectedId ?? '',
+                equipmentName: toModificationOperation(sanitizeString(twt[EQUIPMENT_NAME])),
                 r: toModificationOperation(characteristics?.[R]),
                 x: toModificationOperation(characteristics?.[X]),
                 g: toModificationOperation(convertOutputValue(FieldType.G, characteristics?.[G])),
@@ -581,23 +565,25 @@ const TwoWindingsTransformerModificationDialog = ({
                 ratedU1: toModificationOperation(characteristics?.[RATED_U1]),
                 ratedU2: toModificationOperation(characteristics?.[RATED_U2]),
                 operationalLimitsGroups: limits?.[ENABLE_OLG_MODIFICATION]
-                    ? addModificationTypeToOpLimitsGroups(limits[OPERATIONAL_LIMITS_GROUPS] ?? [])
+                    ? (addModificationTypeToOpLimitsGroups(
+                          limits[OPERATIONAL_LIMITS_GROUPS] as OperationalLimitsGroupFormSchema[]
+                      ) as OperationalLimitsGroupModificationInfos[])
                     : [],
-                selectedLimitsGroup1: addOperationTypeToSelectedOpLG(
+                selectedOperationalLimitsGroupId1: addOperationTypeToSelectedOpLG(
                     limits?.[SELECTED_OPERATIONAL_LIMITS_GROUP_ID1],
                     intl.formatMessage({
                         id: 'None',
                     })
                 ),
-                selectedLimitsGroup2: addOperationTypeToSelectedOpLG(
+                selectedOperationalLimitsGroupId2: addOperationTypeToSelectedOpLG(
                     limits?.[SELECTED_OPERATIONAL_LIMITS_GROUP_ID2],
                     intl.formatMessage({
                         id: 'None',
                     })
                 ),
                 [ENABLE_OLG_MODIFICATION]: Boolean(limits?.[ENABLE_OLG_MODIFICATION]),
-                ratioTapChanger: computeRatioTapForSubmit(twt),
-                phaseTapChanger: computePhaseTapForSubmit(twt),
+                ratioTapChanger: computeRatioTapForSubmit(twt) as unknown as RatioTapChangerModificationInfos,
+                phaseTapChanger: computePhaseTapForSubmit(twt) as unknown as PhaseTapChangerModificationInfos,
                 voltageLevelId1: connectivity1?.[VOLTAGE_LEVEL]?.id,
                 busOrBusbarSectionId1: connectivity1?.[BUS_OR_BUSBAR_SECTION]?.id,
                 voltageLevelId2: connectivity2?.[VOLTAGE_LEVEL]?.id,
@@ -606,11 +592,11 @@ const TwoWindingsTransformerModificationDialog = ({
                 connectionName2: sanitizeString(connectivity2?.[CONNECTION_NAME]),
                 connectionDirection1: connectivity1?.[CONNECTION_DIRECTION],
                 connectionDirection2: connectivity2?.[CONNECTION_DIRECTION],
-                connectionPosition1: String(connectivity1?.[CONNECTION_POSITION]),
-                connectionPosition2: String(connectivity2?.[CONNECTION_POSITION]),
-                connected1: Boolean(connectivity1?.[CONNECTED]),
-                connected2: Boolean(connectivity2?.[CONNECTED]),
-                properties: toModificationProperties(twt as unknown as Record<string, unknown>),
+                connectionPosition1: connectivity1?.[CONNECTION_POSITION],
+                connectionPosition2: connectivity2?.[CONNECTION_POSITION],
+                terminal1Connected: connectivity1?.[CONNECTED],
+                terminal2Connected: connectivity2?.[CONNECTED],
+                properties: toModificationProperties(twt),
                 p1MeasurementValue: stateEstimationData?.[MEASUREMENT_P1]?.[VALUE],
                 p1MeasurementValidity: stateEstimationData?.[MEASUREMENT_P1]?.[VALIDITY],
                 q1MeasurementValue: stateEstimationData?.[MEASUREMENT_Q1]?.[VALUE],
@@ -637,7 +623,7 @@ const TwoWindingsTransformerModificationDialog = ({
         ]
     );
 
-    const onValidationError = (errors: FieldErrors<TwoWindingsTransformerModificationFormData>) => {
+    const onValidationError = (errors: FieldErrors<TwoWindingsTransformerModificationFormValues>) => {
         const tabsInError: number[] = [];
         if (errors?.[CONNECTIVITY] !== undefined) {
             tabsInError.push(TwoWindingsTransformerModificationDialogTab.CONNECTIVITY_TAB);
@@ -679,7 +665,7 @@ const TwoWindingsTransformerModificationDialog = ({
     });
 
     const isRatioTapChangerEnabled = useCallback(
-        (twt: TwoWindingsTransformerData): boolean => {
+        (twt: TwoWindingsTransformerMapInfos): boolean => {
             if (editData?.ratioTapChanger?.enabled === undefined) {
                 return !!twt.ratioTapChanger;
             }
@@ -689,7 +675,7 @@ const TwoWindingsTransformerModificationDialog = ({
     );
 
     const isPhaseTapChangerEnabled = useCallback(
-        (twt: TwoWindingsTransformerData): boolean => {
+        (twt: TwoWindingsTransformerMapInfos): boolean => {
             if (editData?.phaseTapChanger?.enabled === undefined) {
                 return !!twt.phaseTapChanger;
             }
@@ -699,7 +685,7 @@ const TwoWindingsTransformerModificationDialog = ({
     );
 
     const getPhaseTapChangerSteps = useCallback(
-        (twt: TwoWindingsTransformerData): TapChangerStep[] | undefined => {
+        (twt: TwoWindingsTransformerMapInfos): TapChangerStep[] | undefined => {
             if (editData === undefined) {
                 return twt?.[PHASE_TAP_CHANGER]?.[STEPS];
             }
@@ -716,7 +702,7 @@ const TwoWindingsTransformerModificationDialog = ({
     );
 
     const getRatioTapChangerSteps = useCallback(
-        (twt: TwoWindingsTransformerData): TapChangerStep[] | undefined => {
+        (twt: TwoWindingsTransformerMapInfos): TapChangerStep[] | undefined => {
             if (editData === undefined) {
                 return twt?.[RATIO_TAP_CHANGER]?.[STEPS];
             }
@@ -745,9 +731,10 @@ const TwoWindingsTransformerModificationDialog = ({
                     equipmentId,
                     true
                 )
-                    .then((twt: TwoWindingsTransformerData) => {
+                    .then((twt: TwoWindingsTransformerMapInfos) => {
                         if (twt) {
                             setTwtToModify(twt);
+                            console.log('TWT form values', getValues());
                             reset(
                                 (formValues) => ({
                                     ...formValues,
@@ -764,52 +751,47 @@ const TwoWindingsTransformerModificationDialog = ({
                                                   [ENABLE_OLG_MODIFICATION]: false,
                                                   [OPERATIONAL_LIMITS_GROUPS]:
                                                       convertToOperationalLimitsGroupFormSchema(
-                                                          twt?.currentLimits ?? []
+                                                          (twt?.currentLimits ?? []) as CurrentLimitsData[]
                                                       ),
-                                              }) as any,
+                                              }) as LimitsFormSchema,
                                     },
                                     ...getRatioTapChangerFormData({
                                         enabled: isRatioTapChangerEnabled(twt),
-                                        hasLoadTapChangingCapabilities: Boolean(
-                                            getValues(`${RATIO_TAP_CHANGER}.${LOAD_TAP_CHANGING_CAPABILITIES}`)
+                                        hasLoadTapChangingCapabilities: getValues(
+                                            `${RATIO_TAP_CHANGER}.${LOAD_TAP_CHANGING_CAPABILITIES}`
                                         ),
-                                        regulationMode:
-                                            Boolean(getValues(`${RATIO_TAP_CHANGER}.${REGULATING}`)) === false
-                                                ? PHASE_REGULATION_MODES.OFF.id
-                                                : String(getValues(`${RATIO_TAP_CHANGER}.${REGULATION_MODE}`)),
-                                        regulationType: String(getValues(`${RATIO_TAP_CHANGER}.${REGULATION_TYPE}`)),
-                                        regulationSide: String(getValues(`${RATIO_TAP_CHANGER}.${REGULATION_SIDE}`)),
-                                        targetV: Number(getValues(`${RATIO_TAP_CHANGER}.${TARGET_V}`)),
-                                        targetDeadband: Number(getValues(`${RATIO_TAP_CHANGER}.${TARGET_DEADBAND}`)),
-                                        lowTapPosition: Number(getValues(`${RATIO_TAP_CHANGER}.${LOW_TAP_POSITION}`)),
-                                        highTapPosition: Number(getValues(`${RATIO_TAP_CHANGER}.${HIGH_TAP_POSITION}`)),
-                                        tapPosition: Number(getValues(`${RATIO_TAP_CHANGER}.${TAP_POSITION}`)),
+                                        regulationMode: getValues(`${RATIO_TAP_CHANGER}.${REGULATION_MODE}`),
+                                        regulationType: getValues(`${RATIO_TAP_CHANGER}.${REGULATION_TYPE}`),
+                                        regulationSide: getValues(`${RATIO_TAP_CHANGER}.${REGULATION_SIDE}`),
+                                        targetV: getValues(`${RATIO_TAP_CHANGER}.${TARGET_V}`) as number,
+                                        targetDeadband: getValues(`${RATIO_TAP_CHANGER}.${TARGET_DEADBAND}`) as number,
+                                        lowTapPosition: getValues(`${RATIO_TAP_CHANGER}.${LOW_TAP_POSITION}`),
+                                        highTapPosition: getValues(`${RATIO_TAP_CHANGER}.${HIGH_TAP_POSITION}`),
+                                        tapPosition: getValues(`${RATIO_TAP_CHANGER}.${TAP_POSITION}`),
                                         steps: addSelectedFieldToRows(getRatioTapChangerSteps(twt)),
-                                        equipmentId: String(getValues(`${RATIO_TAP_CHANGER}.${EQUIPMENT}.${ID}`)),
-                                        equipmentType: String(getValues(`${RATIO_TAP_CHANGER}.${EQUIPMENT}.${TYPE}`)),
+                                        equipmentId: getValues(`${RATIO_TAP_CHANGER}.${EQUIPMENT}.${ID}`),
+                                        equipmentType: getValues(`${RATIO_TAP_CHANGER}.${EQUIPMENT}.${TYPE}`),
                                         voltageLevelId: getValues(`${RATIO_TAP_CHANGER}.${VOLTAGE_LEVEL}.${ID}`),
                                     }),
                                     ...getPhaseTapChangerFormData({
                                         enabled: isPhaseTapChangerEnabled(twt),
-                                        regulationMode: String(getValues(`${PHASE_TAP_CHANGER}.${REGULATION_MODE}`)),
-                                        regulationType: String(getValues(`${PHASE_TAP_CHANGER}.${REGULATION_TYPE}`)),
-                                        regulationSide: String(getValues(`${PHASE_TAP_CHANGER}.${REGULATION_SIDE}`)),
-                                        currentLimiterRegulatingValue: Number(
-                                            getValues(`${PHASE_TAP_CHANGER}.${CURRENT_LIMITER_REGULATING_VALUE}`)
+                                        regulationMode: getValues(`${PHASE_TAP_CHANGER}.${REGULATION_MODE}`),
+                                        regulationType: getValues(`${PHASE_TAP_CHANGER}.${REGULATION_TYPE}`),
+                                        regulationSide: getValues(`${PHASE_TAP_CHANGER}.${REGULATION_SIDE}`),
+                                        currentLimiterRegulatingValue: getValues(
+                                            `${PHASE_TAP_CHANGER}.${CURRENT_LIMITER_REGULATING_VALUE}`
                                         ),
-                                        flowSetpointRegulatingValue: Number(
-                                            getValues(`${PHASE_TAP_CHANGER}.${FLOW_SET_POINT_REGULATING_VALUE}`)
+                                        flowSetpointRegulatingValue: getValues(
+                                            `${PHASE_TAP_CHANGER}.${FLOW_SET_POINT_REGULATING_VALUE}`
                                         ),
-                                        targetDeadband: Number(getValues(`${PHASE_TAP_CHANGER}.${TARGET_DEADBAND}`)),
-                                        lowTapPosition: Number(getValues(`${PHASE_TAP_CHANGER}.${LOW_TAP_POSITION}`)),
-                                        highTapPosition: Number(getValues(`${PHASE_TAP_CHANGER}.${HIGH_TAP_POSITION}`)),
-                                        tapPosition: Number(getValues(`${PHASE_TAP_CHANGER}.${TAP_POSITION}`)),
+                                        targetDeadband: getValues(`${PHASE_TAP_CHANGER}.${TARGET_DEADBAND}`),
+                                        lowTapPosition: getValues(`${PHASE_TAP_CHANGER}.${LOW_TAP_POSITION}`),
+                                        highTapPosition: getValues(`${PHASE_TAP_CHANGER}.${HIGH_TAP_POSITION}`),
+                                        tapPosition: getValues(`${PHASE_TAP_CHANGER}.${TAP_POSITION}`),
                                         steps: addSelectedFieldToRows(getPhaseTapChangerSteps(twt)),
-                                        equipmentId: String(getValues(`${PHASE_TAP_CHANGER}.${EQUIPMENT}.${ID}`)),
-                                        equipmentType: String(getValues(`${PHASE_TAP_CHANGER}.${EQUIPMENT}.${TYPE}`)),
-                                        voltageLevelId: String(
-                                            getValues(`${PHASE_TAP_CHANGER}.${VOLTAGE_LEVEL}.${ID}`)
-                                        ),
+                                        equipmentId: getValues(`${PHASE_TAP_CHANGER}.${EQUIPMENT}.${ID}`),
+                                        equipmentType: getValues(`${PHASE_TAP_CHANGER}.${EQUIPMENT}.${TYPE}`),
+                                        voltageLevelId: getValues(`${PHASE_TAP_CHANGER}.${VOLTAGE_LEVEL}.${ID}`),
                                     }),
                                     [ADDITIONAL_PROPERTIES]: getConcatenatedProperties(twt as Equipment, getValues),
                                 }),
@@ -833,9 +815,9 @@ const TwoWindingsTransformerModificationDialog = ({
             studyUuid,
             currentNodeUuid,
             currentRootNetworkUuid,
-            getValues,
             reset,
             isRatioTapChangerEnabled,
+            getValues,
             getRatioTapChangerSteps,
             isPhaseTapChangerEnabled,
             getPhaseTapChangerSteps,
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-steps.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-steps.tsx
index bd1b7a8537..ba45e0ba0b 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-steps.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-steps.tsx
@@ -21,12 +21,13 @@ import TapChangerSteps from '../tap-changer-steps';
 import { parseIntData } from '../../../../dialog-utils';
 import { DndColumn, DndColumnType } from '@gridsuite/commons-ui';
 import { CurrentTreeNode } from 'components/graph/tree-node.type';
-import { PHASE_TAP, PhaseTapChangerData, TwoWindingsTransformerEditData } from '../../two-windings-transformer.types';
+import { PHASE_TAP, TapChangerMapInfos } from '../../two-windings-transformer.types';
+import { TwoWindingsTransformerModificationInfo } from 'services/network-modification-types';
 
 export interface PhaseTapChangerPaneStepsProps {
     disabled?: boolean;
-    previousValues?: PhaseTapChangerData;
-    editData?: TwoWindingsTransformerEditData;
+    previousValues?: TapChangerMapInfos;
+    editData?: TwoWindingsTransformerModificationInfo;
     currentNode: CurrentTreeNode;
     isModification?: boolean;
 }
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-utils.ts b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-utils.ts
index 9e7208bb13..8734c164be 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-utils.ts
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane-utils.ts
@@ -45,7 +45,11 @@ import {
     getRegulatingTerminalFormData,
 } from '../../../../regulating-terminal/regulating-terminal-form-utils';
 import { PHASE_REGULATION_MODES, REGULATION_TYPES, SIDE } from 'components/network/constants';
-import { TwoWindingsTransformerData, PhaseTapChangerData, TapChangerStep } from '../../two-windings-transformer.types';
+import {
+    TapChangerMapInfos,
+    TapChangerStep,
+    TwoWindingsTransformerMapInfos,
+} from '../../two-windings-transformer.types';
 
 const getRegulatingTerminalPhaseTapChangerValidationSchema = () => ({
     [VOLTAGE_LEVEL]: yup
@@ -163,6 +167,10 @@ const phaseTapChangerValidationSchema = (isModification: boolean, id: string) =>
     }),
 });
 
+export type PhaseTapChangerFormSchema = yup.InferType<
+    ReturnType<typeof phaseTapChangerValidationSchema>[typeof PHASE_TAP_CHANGER]
+>;
+
 export const getPhaseTapChangerValidationSchema = (isModification = false, id = PHASE_TAP_CHANGER) => {
     return phaseTapChangerValidationSchema(isModification, id);
 };
@@ -247,7 +255,7 @@ export const getPhaseTapChangerFormData = (
 type PhaseRegulationMode = (typeof PHASE_REGULATION_MODES)[keyof typeof PHASE_REGULATION_MODES] | undefined;
 
 export const getComputedPhaseTapChangerRegulationMode = (
-    phaseTapChangerFormValues?: PhaseTapChangerData
+    phaseTapChangerFormValues?: TapChangerMapInfos
 ): PhaseRegulationMode => {
     if (
         phaseTapChangerFormValues?.[REGULATION_MODE] === PHASE_REGULATION_MODES.OFF.id ||
@@ -270,7 +278,7 @@ export const getComputedPhaseTapChangerRegulationMode = (
     return undefined;
 };
 
-export const getPhaseTapRegulationSideId = (twt?: TwoWindingsTransformerData): string | null => {
+export const getPhaseTapRegulationSideId = (twt?: TwoWindingsTransformerMapInfos): string | null => {
     const phaseTapChangerValues = twt?.phaseTapChanger;
     if (!phaseTapChangerValues || !twt) {
         return null;
@@ -283,7 +291,7 @@ export const getPhaseTapRegulationSideId = (twt?: TwoWindingsTransformerData): s
 
 type RegulationType = (typeof REGULATION_TYPES)[keyof typeof REGULATION_TYPES] | null;
 
-export const getComputedPhaseRegulationType = (twt?: TwoWindingsTransformerData): RegulationType => {
+export const getComputedPhaseRegulationType = (twt?: TwoWindingsTransformerMapInfos): RegulationType => {
     if (!twt?.[PHASE_TAP_CHANGER]?.regulatingTerminalConnectableId) {
         return null;
     }
@@ -293,12 +301,14 @@ export const getComputedPhaseRegulationType = (twt?: TwoWindingsTransformerData)
     return REGULATION_TYPES.LOCAL;
 };
 
-export const getComputedPhaseRegulationTypeId = (twt?: TwoWindingsTransformerData): string | null => {
+export const getComputedPhaseRegulationTypeId = (twt?: TwoWindingsTransformerMapInfos): string | null => {
     const regulationType = getComputedPhaseRegulationType(twt);
     return regulationType?.id ?? null;
 };
 
-export const getComputedPreviousPhaseRegulationType = (previousValues?: TwoWindingsTransformerData): string | null => {
+export const getComputedPreviousPhaseRegulationType = (
+    previousValues?: TwoWindingsTransformerMapInfos
+): string | null => {
     const previousRegulationType = getComputedPhaseRegulationType(previousValues);
     return previousRegulationType?.id ?? null;
 };
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane.tsx
index c07238558f..25498bb054 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/phase-tap-changer-pane/phase-tap-changer-pane.tsx
@@ -29,7 +29,7 @@ import { useMemo } from 'react';
 import GridItem from '../../../../commons/grid-item';
 import GridSection from '../../../../commons/grid-section';
 import RegulatedTerminalSection from '../regulated-terminal-section';
-import { PhaseTapChangerData, PhaseTapChangerPaneProps } from '../../two-windings-transformer.types';
+import { TapChangerMapInfos, TapChangerPaneProps } from '../../two-windings-transformer.types';
 
 const PhaseTapChangerPane = ({
     id = PHASE_TAP_CHANGER,
@@ -40,7 +40,7 @@ const PhaseTapChangerPane = ({
     previousValues,
     editData,
     isModification = false,
-}: PhaseTapChangerPaneProps) => {
+}: TapChangerPaneProps) => {
     const intl = useIntl();
 
     const phaseTapChangerEnabledWatch = useWatch({
@@ -55,7 +55,7 @@ const PhaseTapChangerPane = ({
         name: `${id}.${REGULATION_TYPE}`,
     });
 
-    const getPhaseTapChangerRegulationModeLabel = (phaseTapChangerFormValues?: PhaseTapChangerData | null) => {
+    const getPhaseTapChangerRegulationModeLabel = (phaseTapChangerFormValues?: TapChangerMapInfos | null) => {
         const computedRegulationMode = getComputedPhaseTapChangerRegulationMode(phaseTapChangerFormValues ?? undefined);
         if (computedRegulationMode) {
             return intl.formatMessage({
@@ -64,7 +64,7 @@ const PhaseTapChangerPane = ({
         }
     };
 
-    const getRegulatingPreviousValue = (field: string, tap?: PhaseTapChangerData) => {
+    const getRegulatingPreviousValue = (field: string, tap?: TapChangerMapInfos) => {
         if (
             (tap?.[REGULATION_MODE] === PHASE_REGULATION_MODES.ACTIVE_POWER_CONTROL.id &&
                 field === FLOW_SET_POINT_REGULATING_VALUE) ||
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane-steps.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane-steps.tsx
index 345bb7c970..10474c1020 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane-steps.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane-steps.tsx
@@ -20,11 +20,11 @@ import { parseIntData } from '../../../../dialog-utils';
 import { DndColumn, DndColumnType } from '@gridsuite/commons-ui';
 import { CurrentTreeNode } from 'components/graph/tree-node.type';
 import TapChangerSteps from '../tap-changer-steps';
-import { RATIO_TAP, RatioTapChangerData } from '../../two-windings-transformer.types';
+import { RATIO_TAP, TapChangerMapInfos } from '../../two-windings-transformer.types';
 
 export interface RatioTapChangerPaneStepsProps {
     disabled?: boolean;
-    previousValues?: RatioTapChangerData;
+    previousValues?: TapChangerMapInfos;
     editData?: Record<string, unknown>;
     currentNode: CurrentTreeNode;
     isModification?: boolean;
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane-utils.ts b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane-utils.ts
index af0c55944d..f55bbabab5 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane-utils.ts
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane-utils.ts
@@ -41,7 +41,7 @@ import {
     getRegulatingTerminalFormData,
 } from '../../../../regulating-terminal/regulating-terminal-form-utils';
 import { RATIO_REGULATION_MODES, REGULATION_TYPES, SIDE } from 'components/network/constants';
-import { TapChangerStep, TwoWindingsTransformerData } from '../../two-windings-transformer.types';
+import { TapChangerStep, TwoWindingsTransformerMapInfos } from '../../two-windings-transformer.types';
 import { TwtEquipmentInfos } from 'components/tooltips/equipment-popover-type';
 
 const getRegulatingTerminalRatioTapChangerValidationSchema = () => ({
@@ -183,6 +183,10 @@ const ratioTapChangerValidationSchema = (isModification: boolean, id: string) =>
     }),
 });
 
+export type RatioTapChangerFormSchema = yup.InferType<
+    ReturnType<typeof ratioTapChangerValidationSchema>[typeof RATIO_TAP_CHANGER]
+>;
+
 export const getRatioTapChangerValidationSchema = (isModification = false, id = RATIO_TAP_CHANGER) => {
     return ratioTapChangerValidationSchema(isModification, id);
 };
@@ -264,7 +268,7 @@ export const getRatioTapChangerFormData = (
     },
 });
 
-export const getComputedRegulationType = (twt: TwoWindingsTransformerData) => {
+export const getComputedRegulationType = (twt: TwoWindingsTransformerMapInfos) => {
     if (
         !twt?.[RATIO_TAP_CHANGER]?.[LOAD_TAP_CHANGING_CAPABILITIES] ||
         !twt?.[RATIO_TAP_CHANGER]?.regulatingTerminalConnectableId
@@ -278,12 +282,12 @@ export const getComputedRegulationType = (twt: TwoWindingsTransformerData) => {
     }
 };
 
-export const getComputedRegulationTypeId = (twt: TwoWindingsTransformerData) => {
+export const getComputedRegulationTypeId = (twt: TwoWindingsTransformerMapInfos) => {
     const regulationType = getComputedRegulationType(twt);
     return regulationType?.id || null;
 };
 
-export const getComputedRegulationMode = (twt: TwoWindingsTransformerData | TwtEquipmentInfos) => {
+export const getComputedRegulationMode = (twt: TwoWindingsTransformerMapInfos | TwtEquipmentInfos) => {
     const ratioTapChangerValues = twt?.ratioTapChanger;
     if (!ratioTapChangerValues) {
         return null;
@@ -295,7 +299,7 @@ export const getComputedRegulationMode = (twt: TwoWindingsTransformerData | TwtE
     }
 };
 
-export const getInitialTwtRatioRegulationModeId = (twt: TwoWindingsTransformerData) => {
+export const getInitialTwtRatioRegulationModeId = (twt: TwoWindingsTransformerMapInfos) => {
     // if onLoadTapChangingCapabilities is set to false or undefined, we set the regulation mode to null
     if (!twt?.ratioTapChanger?.hasLoadTapChangingCapabilities) {
         return null;
@@ -305,16 +309,16 @@ export const getInitialTwtRatioRegulationModeId = (twt: TwoWindingsTransformerDa
     return computedRegulationMode?.id || null;
 };
 
-export const getComputedRegulationModeId = (twt: TwoWindingsTransformerData) => {
+export const getComputedRegulationModeId = (twt: TwoWindingsTransformerMapInfos) => {
     return getComputedRegulationMode(twt)?.id || null;
 };
 
-export const getComputedPreviousRatioRegulationType = (previousValues: TwoWindingsTransformerData) => {
+export const getComputedPreviousRatioRegulationType = (previousValues: TwoWindingsTransformerMapInfos) => {
     const previousRegulationType = getComputedRegulationType(previousValues);
     return previousRegulationType?.id || null;
 };
 
-export const getComputedTapSide = (twt: TwoWindingsTransformerData) => {
+export const getComputedTapSide = (twt: TwoWindingsTransformerMapInfos) => {
     const ratioTapChangerValues = twt?.ratioTapChanger;
     if (!ratioTapChangerValues || !twt) {
         return null;
@@ -326,6 +330,6 @@ export const getComputedTapSide = (twt: TwoWindingsTransformerData) => {
     }
 };
 
-export const getComputedTapSideId = (twt: TwoWindingsTransformerData) => {
+export const getComputedTapSideId = (twt: TwoWindingsTransformerMapInfos) => {
     return getComputedTapSide(twt)?.id || null;
 };
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane.tsx
index cbe8640b06..374d6a2155 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/ratio-tap-changer-pane/ratio-tap-changer-pane.tsx
@@ -36,9 +36,9 @@ import GridItem from '../../../../commons/grid-item';
 import GridSection from '../../../../commons/grid-section';
 import RegulatedTerminalSection from '../regulated-terminal-section';
 import {
-    TwoWindingsTransformerData,
-    RatioTapChangerData,
-    RatioTapChangerPaneProps,
+    TapChangerMapInfos,
+    TapChangerPaneProps,
+    TwoWindingsTransformerMapInfos,
 } from '../../two-windings-transformer.types';
 
 const RatioTapChangerPane = ({
@@ -50,7 +50,7 @@ const RatioTapChangerPane = ({
     previousValues,
     editData,
     isModification = false,
-}: RatioTapChangerPaneProps) => {
+}: TapChangerPaneProps) => {
     const { trigger, setValue, getValues } = useFormContext();
     const intl = useIntl();
 
@@ -64,7 +64,7 @@ const RatioTapChangerPane = ({
         return undefined;
     };
 
-    const getRatioTapChangerRegulationModeLabel = (ratioTapChangerFormValues?: RatioTapChangerData | null) => {
+    const getRatioTapChangerRegulationModeLabel = (ratioTapChangerFormValues?: TapChangerMapInfos | null) => {
         if (!ratioTapChangerFormValues) {
             return undefined;
         }
@@ -105,7 +105,7 @@ const RatioTapChangerPane = ({
     }, [previousValues, regulationTypeWatch]);
 
     const findAndSetVoltageLevelFromPrevious = useCallback(
-        (previousValues: TwoWindingsTransformerData | undefined, voltageLevelOptions: Identifiable[]) => {
+        (previousValues: TwoWindingsTransformerMapInfos | undefined, voltageLevelOptions: Identifiable[]) => {
             const prevVl = voltageLevelOptions.find(
                 (vl) => vl.id === previousValues?.ratioTapChanger?.regulatingTerminalVlId
             );
@@ -124,7 +124,7 @@ const RatioTapChangerPane = ({
     );
 
     const setEquipmentFromPrevious = useCallback(
-        (previousValues: TwoWindingsTransformerData | undefined) => {
+        (previousValues: TwoWindingsTransformerMapInfos | undefined) => {
             const prevEquipmentId = previousValues?.ratioTapChanger?.regulatingTerminalConnectableId;
             if (prevEquipmentId) {
                 const prevEquipmentType = previousValues?.ratioTapChanger?.regulatingTerminalConnectableType;
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/tap-changer-steps.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/tap-changer-steps.tsx
index 2d556e46d3..e48838c871 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/tap-changer-steps.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/tap-changer-pane/tap-changer-steps.tsx
@@ -33,7 +33,7 @@ import { compareStepsWithPreviousValues, computeHighTapPosition } from 'componen
 import { isNodeBuilt } from 'components/graph/util/model-functions';
 import { transformIfFrenchNumber } from '../../tabular/tabular-common.js';
 import { CurrentTreeNode } from 'components/graph/tree-node.type';
-import { RuleType, TapChangerData, TapChangerStep } from '../two-windings-transformer.types';
+import { RuleType, TapChangerMapInfos, TapChangerStep } from '../two-windings-transformer.types';
 
 export interface TapChangerStepsProps {
     tapChanger: string;
@@ -47,7 +47,7 @@ export interface TapChangerStepsProps {
     resetButtonMessageId: string;
     handleImportRow: (val: Record<string, string>) => Record<string, string | number>;
     disabled?: boolean;
-    previousValues?: TapChangerData;
+    previousValues?: TapChangerMapInfos;
     editData?: Record<string, unknown>;
     currentNode: CurrentTreeNode;
     isModification?: boolean;
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts b/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
index ee997ccdac..797b9ea28c 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
@@ -4,10 +4,10 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
-import { CommonBranchEquipmentInfos } from 'components/tooltips/equipment-popover-type';
 import { Identifiable } from '@gridsuite/commons-ui';
 import { CurrentTreeNode } from 'components/graph/tree-node.type';
 import {
+    B,
     BUS_OR_BUSBAR_SECTION,
     CONNECTED,
     CONNECTION_DIRECTION,
@@ -15,29 +15,28 @@ import {
     CONNECTION_POSITION,
     CONNECTIVITY_1,
     CONNECTIVITY_2,
-    CURRENT_LIMITER_REGULATING_VALUE,
-    ENABLE_OLG_MODIFICATION,
-    ENABLED,
-    EQUIPMENT,
-    FLOW_SET_POINT_REGULATING_VALUE,
+    G,
     HIGH_TAP_POSITION,
     ID,
     LOAD_TAP_CHANGING_CAPABILITIES,
     LOW_TAP_POSITION,
-    OPERATIONAL_LIMITS_GROUPS,
-    PHASE_TAP_CHANGER,
-    RATIO_TAP_CHANGER,
+    MEASUREMENT_P1,
+    MEASUREMENT_P2,
+    MEASUREMENT_Q1,
+    MEASUREMENT_Q2,
+    PHASE_TAP_CHANGER_STATUS,
+    R,
+    RATED_S,
+    RATED_U1,
+    RATED_U2,
+    RATIO_TAP_CHANGER_STATUS,
     REGULATING,
     REGULATING_TERMINAL_CONNECTABLE_ID,
     REGULATING_TERMINAL_CONNECTABLE_TYPE,
     REGULATING_TERMINAL_VOLTAGE_LEVEL_ID,
     REGULATION_MODE,
-    REGULATION_SIDE,
-    REGULATION_TYPE,
     REGULATION_VALUE,
     SELECTED,
-    SELECTED_OPERATIONAL_LIMITS_GROUP_ID1,
-    SELECTED_OPERATIONAL_LIMITS_GROUP_ID2,
     STEPS,
     STEPS_ALPHA,
     STEPS_CONDUCTANCE,
@@ -49,182 +48,171 @@ import {
     TAP_POSITION,
     TARGET_DEADBAND,
     TARGET_V,
+    TO_BE_ESTIMATED,
+    VALIDITY,
+    VALUE,
     VOLTAGE_LEVEL,
+    X,
 } from 'components/utils/field-constants';
 import { UUID } from 'node:crypto';
 import { ConnectablePositionFormInfos } from 'components/dialogs/connectivity/connectivity.type';
-import { CurrentLimitsData } from 'services/study/network-map.type';
-import { OperationalLimitsGroupFormSchema } from 'components/dialogs/limits/operational-limits-groups-types';
-import { Property } from '../common/properties/property-utils';
-import { AttributeModification, OperationalLimitsGroup } from 'services/network-modification-types';
-import { CharacteristicsValues } from './characteristics-pane/two-windings-transformer-characteristics-pane-utils';
+import { LimitsProperty, TwoWindingsTransformerModificationInfo } from 'services/network-modification-types';
 
 export const PHASE_TAP = 'dephasing';
 export const RATIO_TAP = 'ratio';
 
 export type RuleType = typeof PHASE_TAP | typeof RATIO_TAP;
 
-export interface TapChangerStep {
-    [STEPS_RESISTANCE]: number;
-    [STEPS_REACTANCE]: number;
-    [STEPS_CONDUCTANCE]: number;
-    [STEPS_SUSCEPTANCE]: number;
-    [STEPS_RATIO]: number;
-    [STEPS_ALPHA]?: number;
-    [STEPS_TAP]?: number;
+export interface TapChangerStep extends TapChangerStepMapInfos {
     [SELECTED]?: boolean;
 }
 
-export interface TapChangerData {
-    [ENABLED]?: boolean;
-    [HIGH_TAP_POSITION]?: number;
-    [REGULATING]?: boolean;
-    [LOW_TAP_POSITION]?: number;
-    [REGULATING_TERMINAL_CONNECTABLE_ID]?: string;
-    [REGULATING_TERMINAL_CONNECTABLE_TYPE]?: string;
-    [REGULATING_TERMINAL_VOLTAGE_LEVEL_ID]?: string;
-    [STEPS]?: TapChangerStep[];
-    [TAP_POSITION]?: number;
-    [TARGET_DEADBAND]?: number;
-    terminalRefConnectableId?: string;
-    terminalRefConnectableVlId?: string;
-    terminalRefConnectableType?: string;
-    [REGULATION_MODE]?: string;
-    [REGULATION_VALUE]?: number;
-    [REGULATION_TYPE]?: string;
-    [REGULATION_SIDE]?: string;
-    [LOAD_TAP_CHANGING_CAPABILITIES]?: boolean;
-    loadTapChangingCapabilities?: boolean;
-    [TARGET_V]?: number | null;
-    [EQUIPMENT]?: Record<string, unknown>;
-    [VOLTAGE_LEVEL]?: Identifiable | null;
-    [CURRENT_LIMITER_REGULATING_VALUE]?: number;
-    [FLOW_SET_POINT_REGULATING_VALUE]?: number;
-}
-
-export interface RatioTapChangerData extends TapChangerData {}
-
-export interface PhaseTapChangerData extends TapChangerData {
-    [FLOW_SET_POINT_REGULATING_VALUE]?: number;
-    [CURRENT_LIMITER_REGULATING_VALUE]?: number;
-}
-
 export interface TapChangerPaneProps {
     id?: string;
     studyUuid: UUID;
     currentNode: CurrentTreeNode;
     currentRootNetworkUuid: UUID;
     voltageLevelOptions?: Identifiable[];
-    previousValues?: TwoWindingsTransformerData;
-    editData?: TwoWindingsTransformerEditData;
+    previousValues?: TwoWindingsTransformerMapInfos;
+    editData?: TwoWindingsTransformerModificationInfo;
     isModification?: boolean;
 }
 
-export type PhaseTapChangerPaneProps = TapChangerPaneProps;
-export type RatioTapChangerPaneProps = TapChangerPaneProps;
-
-export interface TwoWindingsTransformerData extends CommonBranchEquipmentInfos {
-    uuid?: UUID;
-    equipmentId?: string;
-    equipmentName?: string;
-    g?: number;
-    b?: number;
-    ratedU1?: number;
-    ratedU2?: number;
-    ratedS?: number;
-    busOrBusbarSectionId1?: string;
-    busOrBusbarSectionId2?: string;
-    connectionDirection1?: string;
-    connectionDirection2?: string;
-    connectablePosition1?: ConnectablePositionFormInfos;
-    connectablePosition2?: ConnectablePositionFormInfos;
-    connectionName1?: string;
-    connectionName2?: string;
-    connectionPosition1?: number;
-    connectionPosition2?: number;
-    currentLimits?: CurrentLimitsData[] | null;
-    voltageLevelId1?: string;
-    voltageLevelId2?: string;
-    connected1?: boolean;
-    connected2?: boolean;
-    operationalLimitsGroups?: OperationalLimitsGroupFormSchema[];
-    selectedOperationalLimitsGroupId1?: string;
-    selectedOperationalLimitsGroupId2?: string;
-    [RATIO_TAP_CHANGER]?: RatioTapChangerData;
-    [PHASE_TAP_CHANGER]?: PhaseTapChangerData;
-    properties?: Property[] | null;
-    [key: string]: unknown;
+// Creation form types
+export interface EntityIdReference {
+    [ID]: string;
+}
+
+export type ConnectivityFormSchema = {
+    [VOLTAGE_LEVEL]: EntityIdReference | null;
+    [BUS_OR_BUSBAR_SECTION]: EntityIdReference | null;
+    [CONNECTION_DIRECTION]: string | null;
+    [CONNECTION_NAME]: string;
+    [CONNECTION_POSITION]: number | null;
+    [CONNECTED]: boolean | null;
+};
+
+export type CharacteristicsFormSchema = {
+    [R]: number | null;
+    [X]: number | null;
+    [G]: number | null;
+    [B]: number | null;
+    [RATED_S]: number | null;
+    [RATED_U1]: number | null;
+    [RATED_U2]: number | null;
+};
+export type CharacteristicsCreationFormSchema = CharacteristicsFormSchema & {
+    [CONNECTIVITY_1]: ConnectivityFormSchema;
+    [CONNECTIVITY_2]: ConnectivityFormSchema;
+};
+
+export interface MeasurementFormSchema {
+    [VALUE]: number | null;
+    [VALIDITY]: boolean | null;
+}
+
+export interface ToBeEstimatedFormSchema {
+    [RATIO_TAP_CHANGER_STATUS]: boolean | null;
+    [PHASE_TAP_CHANGER_STATUS]: boolean | null;
+}
+
+export interface StateEstimationFormSchema {
+    [MEASUREMENT_P1]: MeasurementFormSchema;
+    [MEASUREMENT_Q1]: MeasurementFormSchema;
+    [MEASUREMENT_P2]: MeasurementFormSchema;
+    [MEASUREMENT_Q2]: MeasurementFormSchema;
+    [TO_BE_ESTIMATED]: ToBeEstimatedFormSchema;
+}
+
+// modification form types
+
+// Types from network map server response
+
+interface TwoWindingsTransformerToBeEstimatedInfos {
+    ratioTapChangerStatus?: boolean;
+    phaseTapChangerStatus?: boolean;
 }
 
-export interface ConnectivityFormData {
-    [VOLTAGE_LEVEL]?: { [ID]?: string };
-    [BUS_OR_BUSBAR_SECTION]?: { [ID]?: string };
-    [CONNECTION_NAME]?: string;
-    [CONNECTION_DIRECTION]?: string;
-    [CONNECTION_POSITION]?: number | null;
-    [CONNECTED]?: boolean | null;
+interface MeasurementsInfos {
+    value?: number;
+    validity: boolean;
 }
 
-export interface CharacteristicsFormData extends CharacteristicsValues {
-    [CONNECTIVITY_1]?: ConnectivityFormData;
-    [CONNECTIVITY_2]?: ConnectivityFormData;
+export interface TemporaryLimitMapInfos {
+    name: string;
+    value?: number;
+    acceptableDuration?: number;
 }
 
-export interface LimitsFormData {
-    [ENABLE_OLG_MODIFICATION]?: boolean;
-    [OPERATIONAL_LIMITS_GROUPS]?: OperationalLimitsGroupFormSchema[];
-    [SELECTED_OPERATIONAL_LIMITS_GROUP_ID1]?: string | null;
-    [SELECTED_OPERATIONAL_LIMITS_GROUP_ID2]?: string | null;
+export interface CurrentLimitsMapInfos {
+    id?: string;
+    permanentLimit?: number;
+    temporaryLimits?: TemporaryLimitMapInfos[];
+    temporaryLimitsByName?: Record<string, TemporaryLimitMapInfos>;
+    applicability: string;
+    limitsProperties?: LimitsProperty[];
+}
+
+export interface TapChangerStepMapInfos {
+    [STEPS_RESISTANCE]: number;
+    [STEPS_REACTANCE]: number;
+    [STEPS_CONDUCTANCE]: number;
+    [STEPS_SUSCEPTANCE]: number;
+    [STEPS_RATIO]: number;
+    [STEPS_ALPHA]?: number;
+    [STEPS_TAP]?: number;
 }
 
-export interface TapChangerEditData {
-    [ENABLED]?: AttributeModification<boolean>;
-    [LOAD_TAP_CHANGING_CAPABILITIES]?: AttributeModification<boolean>;
-    [REGULATING]?: AttributeModification<boolean>;
-    [REGULATION_MODE]?: AttributeModification<string>;
-    [REGULATION_TYPE]?: AttributeModification<string>;
-    [REGULATION_SIDE]?: AttributeModification<string>;
-    [TARGET_V]?: AttributeModification<number>;
-    [TARGET_DEADBAND]?: AttributeModification<number>;
-    [LOW_TAP_POSITION]?: AttributeModification<number>;
-    [TAP_POSITION]?: AttributeModification<number>;
-    [STEPS]?: TapChangerStep[] | null;
-    regulationValue?: AttributeModification<number>;
-    terminalRefConnectableId?: AttributeModification<string>;
-    terminalRefConnectableType?: AttributeModification<string>;
-    terminalRefConnectableVlId?: AttributeModification<string>;
+export interface TapChangerMapInfos {
+    [LOW_TAP_POSITION]: number;
+    [TAP_POSITION]: number;
+    [HIGH_TAP_POSITION]: number;
+    [REGULATING]?: boolean;
+    [LOAD_TAP_CHANGING_CAPABILITIES]?: boolean;
+    [TARGET_V]?: number;
+    [TARGET_DEADBAND]?: number;
+    [REGULATION_MODE]?: string;
+    [REGULATION_VALUE]?: number;
+    [REGULATING_TERMINAL_CONNECTABLE_ID]?: string;
+    [REGULATING_TERMINAL_CONNECTABLE_TYPE]?: string;
+    [REGULATING_TERMINAL_VOLTAGE_LEVEL_ID]?: string;
+    [STEPS]?: TapChangerStepMapInfos[];
 }
 
-export interface TwoWindingsTransformerEditData {
-    uuid?: UUID;
-    equipmentId?: string;
-    equipmentName?: AttributeModification<string>;
-    r?: AttributeModification<number>;
-    x?: AttributeModification<number>;
-    g?: AttributeModification<number>;
-    b?: AttributeModification<number>;
-    ratedS?: AttributeModification<number>;
-    ratedU1?: AttributeModification<number>;
-    ratedU2?: AttributeModification<number>;
-    voltageLevelId1?: AttributeModification<string>;
-    voltageLevelId2?: AttributeModification<string>;
-    busOrBusbarSectionId1?: AttributeModification<string>;
-    busOrBusbarSectionId2?: AttributeModification<string>;
-    connectionName1?: AttributeModification<string>;
-    connectionName2?: AttributeModification<string>;
-    connectionDirection1?: AttributeModification<string>;
-    connectionDirection2?: AttributeModification<string>;
-    connectionPosition1?: AttributeModification<number>;
-    connectionPosition2?: AttributeModification<number>;
-    connected1?: AttributeModification<boolean>;
-    connected2?: AttributeModification<boolean>;
-    operationalLimitsGroups?: OperationalLimitsGroup[];
-    selectedOperationalLimitsGroupId1?: AttributeModification<string>;
-    selectedOperationalLimitsGroupId2?: AttributeModification<string>;
-    [ENABLE_OLG_MODIFICATION]?: boolean;
-    [RATIO_TAP_CHANGER]?: TapChangerEditData;
-    [PHASE_TAP_CHANGER]?: TapChangerEditData;
-    ratioTapChangerToBeEstimated?: AttributeModification<boolean>;
-    phaseTapChangerToBeEstimated?: AttributeModification<boolean>;
-    properties?: Property[] | null;
+export interface TwoWindingsTransformerMapInfos extends Identifiable {
+    properties?: Record<string, string>;
+    voltageLevelId1: string;
+    voltageLevelName1: string;
+    voltageLevelId2: string;
+    voltageLevelName2: string;
+    terminal1Connected: boolean;
+    terminal2Connected: boolean;
+    p1?: number;
+    q1?: number;
+    p2?: number;
+    q2?: number;
+    i1?: number;
+    i2?: number;
+    currentLimits?: CurrentLimitsMapInfos[];
+    selectedOperationalLimitsGroupId1?: string;
+    selectedOperationalLimitsGroupId2?: string;
+    phaseTapChanger?: TapChangerMapInfos;
+    ratioTapChanger?: TapChangerMapInfos;
+    g: number;
+    b: number;
+    r: number;
+    x: number;
+    ratedU1: number;
+    ratedU2: number;
+    ratedS?: number;
+    connectablePosition1: ConnectablePositionFormInfos;
+    connectablePosition2: ConnectablePositionFormInfos;
+    busOrBusbarSectionId1?: string;
+    busOrBusbarSectionId2?: string;
+    operatingStatus?: string;
+    measurementP1?: MeasurementsInfos;
+    measurementQ1?: MeasurementsInfos;
+    measurementP2?: MeasurementsInfos;
+    measurementQ2?: MeasurementsInfos;
+    toBeEstimated?: TwoWindingsTransformerToBeEstimatedInfos;
 }
diff --git a/src/services/network-modification-types.ts b/src/services/network-modification-types.ts
index 4586e9a79d..03185c9c89 100644
--- a/src/services/network-modification-types.ts
+++ b/src/services/network-modification-types.ts
@@ -224,12 +224,57 @@ export interface StaticVarCompensatorCreationInfo {
     properties?: Property[] | null;
 }
 
+export interface TapChangerModificationInfos {
+    enabled: AttributeModification<boolean> | null;
+    regulationType: AttributeModification<string> | null;
+    regulationSide: AttributeModification<string> | null;
+    lowTapPosition: AttributeModification<number> | null;
+    tapPosition: AttributeModification<number> | null;
+    isRegulating: AttributeModification<boolean> | null;
+    targetDeadband: AttributeModification<number> | null;
+    terminalRefConnectableId: AttributeModification<string> | null;
+    terminalRefConnectableType: AttributeModification<string> | null;
+    terminalRefConnectableVlId: AttributeModification<string> | null;
+    steps: TapChangerStepCreationInfos[] | null;
+    hasLoadTapChangingCapabilities: AttributeModification<boolean> | null;
+}
+
+export interface RatioTapChangerModificationInfos extends TapChangerModificationInfos {
+    targetV: AttributeModification<number> | null;
+}
+
+export interface PhaseTapChangerModificationInfos extends TapChangerModificationInfos {
+    regulationMode: AttributeModification<string> | null;
+    regulationValue: AttributeModification<number> | null;
+}
+
+export interface CurrentTemporaryLimitModificationInfos {
+    name: AttributeModification<string> | null;
+    value: AttributeModification<number> | null;
+    acceptableDuration: AttributeModification<number> | null;
+    modificationType: string | null;
+}
+
+export interface CurrentLimitsModificationInfos {
+    permanentLimit: number | null;
+    temporaryLimits: CurrentTemporaryLimitModificationInfos[] | null;
+}
+
+export interface OperationalLimitsGroupModificationInfos {
+    id: string;
+    currentLimits: CurrentLimitsModificationInfos | null;
+    modificationType?: string | null;
+    temporaryLimitsModificationType?: string | null;
+    limitsProperties?: LimitsPropertyInfos[] | null;
+    applicability: string | null;
+}
+
 export interface TwoWindingsTransformerModificationInfo {
     studyUuid: string;
     nodeUuid: UUID;
     modificationUuid?: string;
-    twoWindingsTransformerId: string;
-    twoWindingsTransformerName: AttributeModification<string> | null;
+    equipmentId: string;
+    equipmentName: AttributeModification<string> | null;
     r: AttributeModification<number> | null;
     x: AttributeModification<number> | null;
     g: AttributeModification<number> | null;
@@ -237,24 +282,21 @@ export interface TwoWindingsTransformerModificationInfo {
     ratedS: AttributeModification<number> | null;
     ratedU1: AttributeModification<number> | null;
     ratedU2: AttributeModification<number> | null;
-    operationalLimitsGroups: OperationalLimitsGroup[];
-    selectedLimitsGroup1: AttributeModification<string> | null;
-    selectedLimitsGroup2: AttributeModification<string> | null;
+    selectedOperationalLimitsGroupId1: AttributeModification<string> | null;
+    selectedOperationalLimitsGroupId2: AttributeModification<string> | null;
     [ENABLE_OLG_MODIFICATION]: boolean;
-    voltageLevelId1?: string;
-    busOrBusbarSectionId1?: string;
-    voltageLevelId2?: string;
-    busOrBusbarSectionId2?: string;
-    ratioTapChanger: Record<string, any> | null;
-    phaseTapChanger: Record<string, any> | null;
+    voltageLevelId1?: string | null;
+    busOrBusbarSectionId1?: string | null;
+    voltageLevelId2?: string | null;
+    busOrBusbarSectionId2?: string | null;
     connectionName1?: string | null;
     connectionDirection1?: string | null;
     connectionName2?: string | null;
     connectionDirection2?: string | null;
-    connectionPosition1?: string | null;
-    connectionPosition2?: string | null;
-    connected1?: boolean;
-    connected2?: boolean;
+    connectionPosition1?: number | null;
+    connectionPosition2?: number | null;
+    terminal1Connected?: boolean | null;
+    terminal2Connected?: boolean | null;
     properties: Property[] | null;
     p1MeasurementValue?: number | null;
     p1MeasurementValidity?: boolean | null;
@@ -266,6 +308,13 @@ export interface TwoWindingsTransformerModificationInfo {
     q2MeasurementValidity?: boolean | null;
     ratioTapChangerToBeEstimated?: boolean | null;
     phaseTapChangerToBeEstimated?: boolean | null;
+
+    operationalLimitsGroupsModificationType?: string | null;
+    operationalLimitsGroups: OperationalLimitsGroupModificationInfos[] | null;
+    ratioTapChanger: RatioTapChangerModificationInfos | null;
+    phaseTapChanger: PhaseTapChangerModificationInfos | null;
+    uuid?: string;
+    activated?: boolean | null;
 }
 
 export interface OperationalLimitsGroup {
@@ -613,29 +662,77 @@ export interface LineModificationInfos {
     q2MeasurementValidity: boolean | null;
 }
 
+export interface LimitsPropertyInfos {
+    name: string;
+    value: string;
+}
+
+export interface CurrentTemporaryLimitCreationInfos {
+    name: string | null;
+    value: number | null;
+    acceptableDuration: number | null;
+}
+
+export interface CurrentLimitsInfos {
+    permanentLimit: number | null;
+    temporaryLimits: CurrentTemporaryLimitCreationInfos[] | null;
+}
+
+export interface OperationalLimitsGroupInfos {
+    id: string | null;
+    currentLimits: CurrentLimitsInfos | null;
+    applicability: string | null;
+    limitsProperties?: LimitsPropertyInfos[] | null;
+}
+
+export interface TapChangerStepCreationInfos {
+    index: number;
+    rho: number;
+    r: number;
+    x: number;
+    g: number;
+    b: number;
+    alpha?: number;
+}
+export interface TapChangerCreationInfos {
+    lowTapPosition: number;
+    tapPosition: number;
+    isRegulating: boolean;
+    targetDeadband: number | null;
+    terminalRefConnectableId: string | null;
+    terminalRefConnectableType: string | null;
+    terminalRefConnectableVlId: string | null;
+    steps: TapChangerStepCreationInfos[];
+    hasLoadTapChangingCapabilities: boolean;
+}
+
+export interface RatioTapChangerCreationInfos extends TapChangerCreationInfos {
+    targetV: number | null;
+}
+
+export interface PhaseTapChangerCreationInfos extends TapChangerCreationInfos {
+    regulationMode: string | null;
+    regulationValue: number | null;
+}
+
 export interface TwoWindingsTransformerCreationInfo {
     studyUuid: string;
     nodeUuid: UUID;
     isUpdate: boolean;
-    modificationUuid: string;
-    twoWindingsTransformerId: string;
-    twoWindingsTransformerName: string | null;
-    r: number;
+    uuid: string;
+    equipmentId: string;
+    equipmentName: string | null;
+    r: number | null;
     x: number;
     g: number;
     b: number;
     ratedS: number | null;
     ratedU1: number;
     ratedU2: number;
-    limitsGroups: OperationalLimitsGroup[];
-    selectedLimitsGroup1: string;
-    selectedLimitsGroup2: string;
     voltageLevelId1: string;
     busOrBusbarSectionId1: string;
     voltageLevelId2: string;
     busOrBusbarSectionId2: string;
-    ratioTapChanger: any;
-    phaseTapChanger: any;
     connectionName1: string | null;
     connectionDirection1: string | null;
     connectionName2: string | null;
@@ -645,6 +742,13 @@ export interface TwoWindingsTransformerCreationInfo {
     connected1: boolean;
     connected2: boolean;
     properties: Property[] | null;
+
+    ratioTapChanger: RatioTapChangerCreationInfos | null;
+    phaseTapChanger: PhaseTapChangerCreationInfos | null;
+
+    operationalLimitsGroups: OperationalLimitsGroupInfos[] | null;
+    selectedOperationalLimitsGroupId1: string | null;
+    selectedOperationalLimitsGroupId2: string | null;
 }
 
 export interface AttachedSubstationCreationInfo {
diff --git a/src/services/study/network-modifications.ts b/src/services/study/network-modifications.ts
index e958710303..ef36c2e8d8 100644
--- a/src/services/study/network-modifications.ts
+++ b/src/services/study/network-modifications.ts
@@ -932,8 +932,8 @@ export function modifyLine({
 export function createTwoWindingsTransformer({
     studyUuid,
     nodeUuid,
-    twoWindingsTransformerId,
-    twoWindingsTransformerName,
+    equipmentId,
+    equipmentName,
     r,
     x,
     g,
@@ -941,9 +941,9 @@ export function createTwoWindingsTransformer({
     ratedS,
     ratedU1,
     ratedU2,
-    limitsGroups,
-    selectedLimitsGroup1,
-    selectedLimitsGroup2,
+    operationalLimitsGroups,
+    selectedOperationalLimitsGroupId1,
+    selectedOperationalLimitsGroupId2,
     voltageLevelId1,
     busOrBusbarSectionId1,
     voltageLevelId2,
@@ -951,7 +951,7 @@ export function createTwoWindingsTransformer({
     ratioTapChanger,
     phaseTapChanger,
     isUpdate,
-    modificationUuid,
+    uuid,
     connectionName1,
     connectionDirection1,
     connectionName2,
@@ -961,12 +961,11 @@ export function createTwoWindingsTransformer({
     connected1,
     connected2,
     properties,
-}: Partial<TwoWindingsTransformerCreationInfo> &
-    Pick<TwoWindingsTransformerCreationInfo, 'modificationUuid' | 'nodeUuid'>) {
+}: TwoWindingsTransformerCreationInfo) {
     let createTwoWindingsTransformerUrl = getNetworkModificationUrl(studyUuid, nodeUuid);
 
     if (isUpdate) {
-        createTwoWindingsTransformerUrl += '/' + encodeURIComponent(modificationUuid);
+        createTwoWindingsTransformerUrl += '/' + encodeURIComponent(uuid);
         console.info('Updating two windings transformer creation');
     } else {
         console.info('Creating two windings transformer creation');
@@ -980,8 +979,8 @@ export function createTwoWindingsTransformer({
         },
         body: JSON.stringify({
             type: MODIFICATION_TYPES.TWO_WINDINGS_TRANSFORMER_CREATION.type,
-            equipmentId: twoWindingsTransformerId,
-            equipmentName: twoWindingsTransformerName,
+            equipmentId,
+            equipmentName,
             r: r,
             x: x,
             g: g,
@@ -989,9 +988,9 @@ export function createTwoWindingsTransformer({
             ratedS: ratedS,
             ratedU1: ratedU1,
             ratedU2: ratedU2,
-            operationalLimitsGroups: limitsGroups,
-            selectedOperationalLimitsGroupId1: selectedLimitsGroup1,
-            selectedOperationalLimitsGroupId2: selectedLimitsGroup2,
+            operationalLimitsGroups,
+            selectedOperationalLimitsGroupId1,
+            selectedOperationalLimitsGroupId2,
             voltageLevelId1: voltageLevelId1,
             busOrBusbarSectionId1: busOrBusbarSectionId1,
             voltageLevelId2: voltageLevelId2,
@@ -1015,8 +1014,8 @@ export function modifyTwoWindingsTransformer({
     studyUuid,
     nodeUuid,
     modificationUuid = undefined,
-    twoWindingsTransformerId,
-    twoWindingsTransformerName,
+    equipmentId,
+    equipmentName,
     r,
     x,
     g,
@@ -1025,8 +1024,8 @@ export function modifyTwoWindingsTransformer({
     ratedU1,
     ratedU2,
     operationalLimitsGroups,
-    selectedLimitsGroup1,
-    selectedLimitsGroup2,
+    selectedOperationalLimitsGroupId1,
+    selectedOperationalLimitsGroupId2,
     enableOLGModification,
     ratioTapChanger,
     phaseTapChanger,
@@ -1040,8 +1039,8 @@ export function modifyTwoWindingsTransformer({
     connectionDirection2 = undefined,
     connectionPosition1 = undefined,
     connectionPosition2 = undefined,
-    connected1 = undefined,
-    connected2 = undefined,
+    terminal1Connected = undefined,
+    terminal2Connected = undefined,
     properties: propertiesForBackend,
     p1MeasurementValue,
     p1MeasurementValidity,
@@ -1072,8 +1071,8 @@ export function modifyTwoWindingsTransformer({
         },
         body: JSON.stringify({
             type: MODIFICATION_TYPES.TWO_WINDINGS_TRANSFORMER_MODIFICATION.type,
-            equipmentId: twoWindingsTransformerId,
-            equipmentName: twoWindingsTransformerName,
+            equipmentId,
+            equipmentName,
             r: r,
             x: x,
             g: g,
@@ -1082,8 +1081,8 @@ export function modifyTwoWindingsTransformer({
             ratedU1: ratedU1,
             ratedU2: ratedU2,
             operationalLimitsGroups: operationalLimitsGroups,
-            selectedOperationalLimitsGroupId1: selectedLimitsGroup1,
-            selectedOperationalLimitsGroupId2: selectedLimitsGroup2,
+            selectedOperationalLimitsGroupId1,
+            selectedOperationalLimitsGroupId2,
             [ENABLE_OLG_MODIFICATION]: enableOLGModification,
             [OLGS_MODIFICATION_TYPE]: enableOLGModification
                 ? OPERATIONAL_LIMITS_GROUPS_MODIFICATION_TYPE.REPLACE
@@ -1100,8 +1099,8 @@ export function modifyTwoWindingsTransformer({
             connectionDirection2: toModificationOperation(connectionDirection2),
             connectionPosition1: toModificationOperation(connectionPosition1),
             connectionPosition2: toModificationOperation(connectionPosition2),
-            terminal1Connected: toModificationOperation(connected1),
-            terminal2Connected: toModificationOperation(connected2),
+            terminal1Connected: toModificationOperation(terminal1Connected),
+            terminal2Connected: toModificationOperation(terminal2Connected),
             properties: propertiesForBackend,
             p1MeasurementValue: toModificationOperation(p1MeasurementValue),
             p1MeasurementValidity: toModificationOperation(p1MeasurementValidity),

From f7a2be5a470ab98a5cc63a4503fd5f7347c60176 Mon Sep 17 00:00:00 2001
From: achour94 <berrahmaachour@gmail.com>
Date: Mon, 26 Jan 2026 16:06:10 +0100
Subject: [PATCH 6/9] fix

Signed-off-by: achour94 <berrahmaachour@gmail.com>
---
 .../two-windings-transformer-modification-dialog.tsx          | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
index 1921fc99ec..9e1b1a751c 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
@@ -167,7 +167,6 @@ import {
     StateEstimationFormSchema,
     TwoWindingsTransformerMapInfos,
 } from '../two-windings-transformer.types';
-import { LineModificationFormInfos } from '../../line/modification/line-modification-type';
 import { BranchInfos, CurrentLimitsData } from 'services/study/network-map.type';
 import { ToBeEstimatedInfo } from './2wt-to-be-estimated/to-be-estimated.type';
 import {
@@ -177,6 +176,7 @@ import {
     TwoWindingsTransformerModificationInfo,
 } from 'services/network-modification-types';
 import { OperationalLimitsGroupFormSchema } from 'components/dialogs/limits/operational-limits-groups-types';
+import { LineModificationFormSchema } from '../../line/modification/line-modification-type';
 
 export interface TwoWindingsTransformerModificationDialogProps {
     studyUuid: UUID;
@@ -744,7 +744,7 @@ const TwoWindingsTransformerModificationDialog = ({
                                                   [ENABLE_OLG_MODIFICATION]: formValues.limits[ENABLE_OLG_MODIFICATION],
                                                   [OPERATIONAL_LIMITS_GROUPS]:
                                                       getOpLimitsGroupInfosFromBranchModification(
-                                                          formValues as unknown as LineModificationFormInfos
+                                                          formValues as LineModificationFormSchema
                                                       ),
                                               }
                                             : {

From 8b497d009bc7165c64c6dccb88081ae7466d4eca Mon Sep 17 00:00:00 2001
From: achour94 <berrahmaachour@gmail.com>
Date: Mon, 26 Jan 2026 16:31:18 +0100
Subject: [PATCH 7/9] fix

Signed-off-by: achour94 <berrahmaachour@gmail.com>
---
 ...-transformer-characteristics-pane-utils.ts | 21 +++++++++----------
 ...mer-creation-characteristics-pane-utils.ts |  4 ++--
 ...o-windings-transformer-creation-dialog.tsx |  2 +-
 ...ndings-transformer-modification-dialog.tsx | 10 ++++-----
 4 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane-utils.ts b/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane-utils.ts
index b5d3c9a329..4b6e54cc90 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane-utils.ts
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane-utils.ts
@@ -7,16 +7,7 @@
 
 import { CHARACTERISTICS, G, B, RATED_S, RATED_U1, RATED_U2, R, X } from 'components/utils/field-constants';
 import yup from 'components/utils/yup-config';
-
-export interface CharacteristicsValues {
-    [R]?: number | null;
-    [X]?: number | null;
-    [G]?: number | null;
-    [B]?: number | null;
-    [RATED_S]?: number | null;
-    [RATED_U1]?: number | null;
-    [RATED_U2]?: number | null;
-}
+import { CharacteristicsFormSchema } from '../two-windings-transformer.types';
 
 type AdditionalValidationFields = Record<string, yup.AnySchema>;
 type AdditionalDataFields = Record<string, unknown>;
@@ -64,7 +55,15 @@ export const getCharacteristicsEmptyFormData = (additionalFields = {}) => {
 };
 
 export const getCharacteristicsFormData = (
-    { r = null, x = null, g = null, b = null, ratedS = null, ratedU1 = null, ratedU2 = null }: CharacteristicsValues,
+    {
+        r = null,
+        x = null,
+        g = null,
+        b = null,
+        ratedS = null,
+        ratedU1 = null,
+        ratedU2 = null,
+    }: CharacteristicsFormSchema,
     additionalFields = {}
 ) => {
     return {
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane-utils.ts b/src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane-utils.ts
index 5ae1688ea8..58f208202a 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane-utils.ts
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/creation/characteristics-pane/two-windings-transformer-creation-characteristics-pane-utils.ts
@@ -11,11 +11,11 @@ import {
     getConnectivityWithPositionValidationSchema,
 } from '../../../../connectivity/connectivity-form-utils';
 import {
-    CharacteristicsValues,
     getCharacteristicsEmptyFormData,
     getCharacteristicsFormData,
     getCharacteristicsValidationSchema,
 } from '../../characteristics-pane/two-windings-transformer-characteristics-pane-utils';
+import { CharacteristicsFormSchema } from '../../two-windings-transformer.types';
 
 const twoWindingsTransformerValidationSchema = () =>
     getCharacteristicsValidationSchema(false, {
@@ -47,7 +47,7 @@ export const getTwoWindingsTransformerFormData = ({
     ratedU2 = null,
     connectivity1 = null,
     connectivity2 = null,
-}: CharacteristicsValues & {
+}: CharacteristicsFormSchema & {
     connectivity1?: Record<string, unknown> | null;
     connectivity2?: Record<string, unknown> | null;
 }) =>
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
index 381076c01a..5736e4d3d6 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/creation/two-windings-transformer-creation-dialog.tsx
@@ -381,7 +381,7 @@ const TwoWindingsTransformerCreationDialog = ({
                         b: convertInputValue(FieldType.B, twt.b),
                         ratedU1: twt.ratedU1,
                         ratedU2: twt.ratedU2,
-                        ratedS: twt.ratedS,
+                        ratedS: twt.ratedS ?? null,
                         ...getConnectivityFormData(
                             {
                                 busbarSectionId: twt.busOrBusbarSectionId1,
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
index 9e1b1a751c..8235b0d9b3 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
@@ -294,13 +294,13 @@ const TwoWindingsTransformerModificationDialog = ({
                     ...getConnectivityFormData(createConnectivityData(twtModification, 2), CONNECTIVITY_2),
                 },
                 ...getCharacteristicsFormData({
-                    r: twtModification.r?.value,
-                    x: twtModification.x?.value,
+                    r: twtModification.r?.value ?? null,
+                    x: twtModification.x?.value ?? null,
                     g: convertInputValue(FieldType.G, twtModification.g?.value),
                     b: convertInputValue(FieldType.B, twtModification.b?.value),
-                    ratedU1: twtModification.ratedU1?.value,
-                    ratedU2: twtModification.ratedU2?.value,
-                    ratedS: twtModification.ratedS?.value,
+                    ratedU1: twtModification.ratedU1?.value ?? null,
+                    ratedU2: twtModification.ratedU2?.value ?? null,
+                    ratedS: twtModification.ratedS?.value ?? null,
                 }),
                 ...getStateEstimationEditData(STATE_ESTIMATION, twtModification),
                 ...getAllLimitsFormData(

From 2f1e3c0791b2eb27d9df376a2638f1e0cb1ffbc9 Mon Sep 17 00:00:00 2001
From: achour94 <berrahmaachour@gmail.com>
Date: Mon, 26 Jan 2026 16:39:02 +0100
Subject: [PATCH 8/9] fix

Signed-off-by: achour94 <berrahmaachour@gmail.com>
---
 .../two-windings-transformer.types.ts                         | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts b/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
index 797b9ea28c..67f815ce94 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
@@ -78,7 +78,7 @@ export interface TapChangerPaneProps {
     isModification?: boolean;
 }
 
-// Creation form types
+// Creation/Modification form types
 export interface EntityIdReference {
     [ID]: string;
 }
@@ -124,8 +124,6 @@ export interface StateEstimationFormSchema {
     [TO_BE_ESTIMATED]: ToBeEstimatedFormSchema;
 }
 
-// modification form types
-
 // Types from network map server response
 
 interface TwoWindingsTransformerToBeEstimatedInfos {

From 5a0d7a8cd33b6e4133843914c1ec9298456f325a Mon Sep 17 00:00:00 2001
From: David BRAQUART <david.braquart@rte-france.com>
Date: Tue, 10 Feb 2026 18:04:06 +0100
Subject: [PATCH 9/9] fix after merge with conflicts

Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
---
 .../two-windings-transformer-characteristics-pane.tsx        | 1 +
 .../two-windings-transformer-modification-dialog.tsx         | 5 ++++-
 .../two-windings-transformer.types.ts                        | 5 ++---
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.tsx
index e2b6dae914..d45781e84e 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/characteristics-pane/two-windings-transformer-characteristics-pane.tsx
@@ -20,6 +20,7 @@ import { B, CHARACTERISTICS, G, R, RATED_S, RATED_U1, RATED_U2, X } from 'compon
 import { FormattedMessage } from 'react-intl';
 import GridItem from '../../../commons/grid-item';
 import { TwoWindingsTransformerMapInfos } from '../two-windings-transformer.types';
+import GridSection from '../../../commons/grid-section';
 
 export interface TwoWindingsTransformerCharacteristicsPaneProps {
     id?: string;
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
index 09c5edfdc3..57082331b0 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.tsx
@@ -790,7 +790,10 @@ const TwoWindingsTransformerModificationDialog = ({
                                         equipmentType: getValues(`${PHASE_TAP_CHANGER}.${EQUIPMENT}.${TYPE}`),
                                         voltageLevelId: getValues(`${PHASE_TAP_CHANGER}.${VOLTAGE_LEVEL}.${ID}`),
                                     }),
-                                    [FieldConstants.ADDITIONAL_PROPERTIES]: getConcatenatedProperties(twt as EquipmentWithProperties, getValues),
+                                    [FieldConstants.ADDITIONAL_PROPERTIES]: getConcatenatedProperties(
+                                        twt as EquipmentWithProperties,
+                                        getValues
+                                    ),
                                 }),
                                 { keepDirty: true }
                             );
diff --git a/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts b/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
index 67f815ce94..1b9c32ed7d 100644
--- a/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
+++ b/src/components/dialogs/network-modifications/two-windings-transformer/two-windings-transformer.types.ts
@@ -4,7 +4,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
-import { Identifiable } from '@gridsuite/commons-ui';
+import { Identifiable, FieldConstants } from '@gridsuite/commons-ui';
 import { CurrentTreeNode } from 'components/graph/tree-node.type';
 import {
     B,
@@ -50,7 +50,6 @@ import {
     TARGET_V,
     TO_BE_ESTIMATED,
     VALIDITY,
-    VALUE,
     VOLTAGE_LEVEL,
     X,
 } from 'components/utils/field-constants';
@@ -107,7 +106,7 @@ export type CharacteristicsCreationFormSchema = CharacteristicsFormSchema & {
 };
 
 export interface MeasurementFormSchema {
-    [VALUE]: number | null;
+    [FieldConstants.VALUE]: number | null;
     [VALIDITY]: boolean | null;
 }